From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84D8C4345F for ; Wed, 1 May 2024 14:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5106B0085; Wed, 1 May 2024 10:42:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54EA96B0087; Wed, 1 May 2024 10:42:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EEBE6B0088; Wed, 1 May 2024 10:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 215AF6B0085 for ; Wed, 1 May 2024 10:42:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A7CB280B85 for ; Wed, 1 May 2024 14:42:04 +0000 (UTC) X-FDA: 82070091768.13.0472A70 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf01.hostedemail.com (Postfix) with ESMTP id 05C634000B for ; Wed, 1 May 2024 14:42:02 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fpayZpH1; spf=pass (imf01.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714574523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=QWu0hcmQYixAs4X/1S4ZEhgKxoQgCqRdjgR7BLis12I=; b=7WqD+o6xwxpw6ZbeM832X5N6veJyYlisct9SjiN2FtAakVujHr+RwA2gSZKxPY+S6NTagf mILq5+j/61/uVzhf40q3GLCBpqOmgKThLYrYYedd630+B1DkmuPIc9e9Bun42jz38PBnr5 3j6yau17/RtapGWbJIToLr0OM9WQnJM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fpayZpH1; spf=pass (imf01.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714574523; a=rsa-sha256; cv=none; b=vGf1dY7lfNjpVkOdcYu8iyGM8FZBX7mDqcxIcHliqCGzJpjXDxtCWUQ15PrXXo6jgRzzZj 3NFqL6Kte/AUPu8eJAb90L23CE7XWj41/lg4vjcv8aoZWCVRoHsJ+5cEQ0o6UawIeSNMQa EbxOX/behCAcjfewdHtGEqX0LSlaYYI= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6ee12766586so678541b3a.0 for ; Wed, 01 May 2024 07:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714574522; x=1715179322; darn=kvack.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=QWu0hcmQYixAs4X/1S4ZEhgKxoQgCqRdjgR7BLis12I=; b=fpayZpH1kB2bj3VuE7p/8mkg97H54t+HM6mZSr8/z6qkSllcJ/OI+DIXNqdbwgnZVy 0K8G//j9101nLhEPrN4is3iyg9PSWOSBO13+oI/YrEmPBkNh+ME7GsB2opVVxdYGpJ8H m/5YEip/N4Uoo4oPK5kD4iuFvCULoDeCh5j7Tll36iqkqSW2bWHOv34DiziDFCOE+oEx vp+hFu3zAP4L37FEA7wZnVHbTwYh3UMWI2iRAEGMXIIFEmcX37qoG7csUy6jrjiGWWX+ 0wNvQJ8zdHmWzCw8NP+iPzL2JKJpIYNp6aQXIeK3Oc5YnPeuX4Rw4c4ww2tBVAm2iPsK 7onQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714574522; x=1715179322; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QWu0hcmQYixAs4X/1S4ZEhgKxoQgCqRdjgR7BLis12I=; b=U38oNn/JmfHCcWdoY4BhXYdWrhOGEvcVoMHYFrVMEteTyOMYxANmxmAySCdDZr9nMo ZB02cNtZQIUJy2+YfjLglUDfmT35aeziPqxb0aUndwl9C0m0oWzoYH4BPU12sKFkm5vh x2hL2oXxNN96LmuXyiuNl/5SbvY8c852RA3NwWCMAlKZWUgNl8Dg64ZxQUSh3QeMKNrr VqJexGNcP9zOiCrpUx8agey9W4bfZloKA3yeyKsv5623uovwva2qTTkUIdngw8PHiRYG W13AqZyWFjB35Rgul8WogEG1DbWYUc+alVnSbvhWghQJLQSsOuYhYAeIB3QTzxSLQwsk H4mQ== X-Forwarded-Encrypted: i=1; AJvYcCUBAYH0Bqe3koPaNPC4ewS85o7WSJXPcRZT3VNlX7RolXSld+xpl3mqCx4733AgEgV7Pr126zKg0akQLKHG3p/6+gs= X-Gm-Message-State: AOJu0YzNXqsSqIO31fZOzs9mHtSAWRRGeFvz7xZJVvai1Dfg7dXSFhKu Li4Mk4nWEuKBl6rEBU3i1WWi3+YZkCjbFCU7W9CKUJanYQ3MUtlZ X-Google-Smtp-Source: AGHT+IGU7duUTElL35l5TS5yKDvJK9y5574CYJ5VoN+Egsb1ISGasGHrZHHgLoeL4IlHddUjwiDm5A== X-Received: by 2002:a05:6a20:914d:b0:1af:6088:10fc with SMTP id x13-20020a056a20914d00b001af608810fcmr4553269pzc.13.1714574521775; Wed, 01 May 2024 07:42:01 -0700 (PDT) Received: from dw-tp ([171.76.84.250]) by smtp.gmail.com with ESMTPSA id p52-20020a056a0026f400b006ede45680a6sm22684900pfw.59.2024.05.01.07.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 07:42:01 -0700 (PDT) Date: Wed, 01 May 2024 20:11:54 +0530 Message-Id: <87edal4mrx.fsf@gmail.com> From: Ritesh Harjani (IBM) To: Zhang Yi , linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, hch@infradead.org, djwong@kernel.org, david@fromorbit.com, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v4 04/34] ext4: drop iblock parameter In-Reply-To: <20240410142948.2817554-5-yi.zhang@huaweicloud.com> X-Rspamd-Queue-Id: 05C634000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hjimyzu9agzips9z8xds6y3a1c9pnskh X-HE-Tag: 1714574522-239476 X-HE-Meta: U2FsdGVkX18xBLwTR2bl382v3n4lpKjsN+jm7FghqxU8PoU4qhScLkSdYiU7sbOlOutk7LvynvNBME5NZvwumxNRBHpupCJhR5vlqRSDI2skuTz+kb3V5AJoAX9A0OP2UBgrT3gd4z8XhsGyTlJVzbKp8vTB5VFPB7hqzvski/rGvujExhM0YAWW5X5TEn9F4Hjfa4CpnTouPsbn2KMnQ7b7FgG4euu6yxkSQunapNsAonXWAPwIIzBmzptLkpfyBVfQcT/2uKl4zjvPumBuH0CTxbWRkkQrFX9qLgMe8zBjV7nXtS1XrffCQoxye3gM8AxXs0I7IUKHFgKSINixUFFugW2FRnObN06IMZKY0Yz+vnF0geAhz4Qz8lUEAQwlNXIufGaN5UkvX6uKkmylDmtfu+/jyo6mT+3F7sSE9wCst/e5o0T1IanYuYwIGfjunJ30fSK4eUTyaIKP2QOmviU6epNNJves3AUBtZAG4QWHdz4XdddyB1H/5L1zUasUW9IWY317smu/iU6JTxJ5tNeohXsq1z5gpivenM4xeEcoz5Q1cXn4xVBLamCqRvQZuTKvZtHMAcQ3Qem7If26sukG/Ay0JawRh0o2MLAlVPFlKl+MEWQjpthBpn8rjTchWL+mL9XeTqFUgz0HROZo+hicmY+7noHQ7FtRM77JPzJIeuBcDFjSl0o1fcsYoiJN7YFWlPea8w2oiBqbahD+iOPZU6Zq/a03QKHayxrv1212I3J3a8PJB81fe4y72H6EGXRaUhVQVaynGPLMg27913Jh+Po11pgj3r6LQ/d0UGFab7igw+XNBOFcW6aLfbj7GQKP7pHGbGbmDZJJHyqZCx+KdtjEPxF+UXQGtWFvOEBCWMOtyrHPcibv2wvLqHnc0ZQhIPu64rm1+fnqVMH6zwkH1L602GgkFSjJZPz6XbChGwPwCmerjQu2NVgHskbGv4pXkAgJ7Ml6Y6eDJ8c PABNf4mH IqIIGNu8f1y9rhY4nQTGLq2LjHRaIkC6RIRjGYRmQRPYeD3uXCFM1/xnFpeTz2Vj+sWYhciMoA5179A+Rsj4NaPVJm5THhjXFg3Ms4mMt+tP0bBqhlz6+3cs2S0hL6mEjFJ2KysF37cT23+7j2au+ZjSMPeXFaRHil+jlRqBqd0V0BoOF+RDZGi4m1bEq9GcU8egsIzNV/0NRBX63hQCJX8fO4+OHe6c+GNd3NtR7LPbx3L5dExj057gNv8dgCoRwUBtGY+5m2bBKNyzGnuSULQmnf75Wp5m7JTY9hCYepkPtzqbpEz+qwDDaM71qIzr2mH0qeTKgL+egp7zkqZ0xrvuvAsSP65UMsAfWjnE6uAhk6dlVtyYUfAX+i4em9mIx3emhDCJ+AULXz8doyPXpjFnacyLsBFBwEnDUBwUsGpzPBSULe9eAPJp/A0kA9lh3IKkIjH7aGdXDmTxGQA9c8HhBjb9/0KwswexbGKk4Ha293fCP3MRUnUxI0iRXXVIw1QL1hSwR8DwaTy/JRnBeUhBKTdzf0rp6Ul/KKiSLc0t/gDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.035342, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zhang Yi writes: > From: Zhang Yi > > The start block of the delalloc extent to be inserted is equal to > map->m_lblk, just drop the duplicate iblock input parameter. > That is indeed correct. Let's drop the unnecessary function argument. Please feel free to add - Ritesh Harjani (IBM) > Signed-off-by: Zhang Yi > --- > fs/ext4/inode.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-)