From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B312C001DC for ; Mon, 31 Jul 2023 16:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB8FD6B00FD; Mon, 31 Jul 2023 12:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E69AE6B00FE; Mon, 31 Jul 2023 12:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32046B00FF; Mon, 31 Jul 2023 12:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C35A76B00FD for ; Mon, 31 Jul 2023 12:11:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2596A02C8 for ; Mon, 31 Jul 2023 16:11:31 +0000 (UTC) X-FDA: 81072397182.15.42AED73 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id E21E0180016 for ; Mon, 31 Jul 2023 16:11:29 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=YCHvdedU; dkim=pass header.d=linutronix.de header.s=2020e header.b=J0tyD6cX; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690819890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VPQ3fAPQWDrjXqLR7sLkRXFSfT5Axv/t++ZFAKa1vPk=; b=32x/px0sygdsDXp6nigR/5OFcZbIiSFmvNwKs09r3eIE3k41KXcdfcS4FHYnuJ24SvooBs Dlc1Cd2NEppE1iUyyBuZC+ycGdPY0czeae2htTwDuHVVNbg1Obwo7R3ly/0yuInJvwJHZo MpNEFnnZjWNAuvXE77c84Y04brKNelQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690819890; a=rsa-sha256; cv=none; b=P+3cVtPwukxGHL76D+9AIwLAVZ1W1HD+dLQidu5r6MSeUg58O/ln2oVO2/HBqB/ypuD1nG PXwZJB4VQEZfJGjq/8dLhKE9qEv/veys4r3gW0BvCTdmV5dHB378j8KLgZrdOS8zcGtxHh nHgfw+vmlG3W1jP7zruuG4t5HHfg3lM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=YCHvdedU; dkim=pass header.d=linutronix.de header.s=2020e header.b=J0tyD6cX; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690819888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VPQ3fAPQWDrjXqLR7sLkRXFSfT5Axv/t++ZFAKa1vPk=; b=YCHvdedUGbTtdsUBSqVP5Uw9Mcx1CwPAFnkmNMZtycuurfk4nzE3k/VaYOe9StNEpek6fW 4tZQI1qZ/8HYR4CHRVz+oSHc297wmYaQtr1Lxsq68JXMsWsZ3rqwa3/FjtNvJo3XGidbJk NLZF8ebij6hSGvXSn/YmZn1zszvVymPr+dCKqJIC0pPqQ3p1wSWWtgcY/Jes8i92oRRUYj KDEXDgkjQ/3xUJ3r2dNNjLf74LSNkxO8MOvixdltvkf5eHStJ0c4MEIso6BbjcbxA4kiVJ cTexDkwgKV+WoiBmfucifc+RwdDhRuvnkLHjAcRDKt1pFA0UxvV88/ucWGg3tw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690819888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VPQ3fAPQWDrjXqLR7sLkRXFSfT5Axv/t++ZFAKa1vPk=; b=J0tyD6cXAhafaPfAXbWslIuDhV+ckGLy8BKgnEOUONS7UsIzCrAWQb2hlbxnG7rcEPQV+Q gDwjvGqWQ5hdNEAw== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags In-Reply-To: <20230721105743.819362688@infradead.org> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> Date: Mon, 31 Jul 2023 18:11:27 +0200 Message-ID: <87edkonjrk.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: E21E0180016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nc7m1q713j7xdstjxe6g7up5ootsk3kt X-HE-Tag: 1690819889-881501 X-HE-Meta: U2FsdGVkX19kSDnYiDjT7MDZN2tZ1TSO83W0yyuM+GaNOxGYsurISH5Nhdtjn0/YZhPUeb13IztIjK1cEP8qY/CtXtd4VGB+y2QOy4NiuYCNckcRIDQ4RTOqKWe5wP05XriEmPR6LykYYZ4G1VfnhGMpFaunJESbAl2OdkeBazOAbRvqOc8R3H9lXQepoP4syYtxPIgtwlfhx1/xFLrF6utlea3zGecsQAXerczhJTIBgGDiogOlolUnLWqn6sE5+tsGYO36vNfP4tLV3Yd59Qem218EyjpHPA2DPXu2sHg3S3HdTdx6SX/L819ki3HxllPMRFRCxmt2IDIVEQgm2OqsrR0cnZ5eJqQyaO35HIt6sebO0ThqkCr/t6A0Xh+EEJaWEFCeZwI7BbGQnHFMauqqc6CfC8iq+j2wb9wCAbYCpKNxj01TJk856gJf8FtuGrL0K2NR1e7ojSNqECVMH+2FusIpVFYeWhZJnk2MzorZDI8m/C+l1q0W2YN7LzlgP1LqZSP9L8TT1MJ5fDPvhEygiNCl795h4ywTKmRiZTWlQZr3Z/OoHcBXBPvBq+2VUg1JctFYtIg+5SKzq1ddLkqz3B6al9pHFV+V2qjSSkSy6ugh6w84HQrk9rcbyFqls1j46ha8Aevs48/Tq86ktAQtu5/S+DKXmywYlcnTxE2MTUQGt9UMBmO8BO3kApIGdoDYBIuYPCsphA98dfiW/GO2VKx6Xot/Q0S1LXbucNDlU6859EeQCLLndOupy/ChBZuLtQ7LsRwTW9hgBl7pCNPTcL2GySvXqlLdjns4A948s0HUvp3c+WRJnIdKSbskWJChUNQ/IVUblaHXqX5N3NdxK/CpdtN61wQIyluO60He6xiOe0sU9Nld8TmKXlOPElefVHFz2KOLz9RXgCGLRqjuQGk3HhUN5utRSXPTiK0OFr7VAKRxi0ER2AkiRyRpEY/HhZOo0XSBp06kji1 nSp2JRW+ d2N32pw+GSsra63HgNgRLml0CqFf7ci8M7JMfVFKhDbQqUic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: > +#define FUTEX2_8 0x00 > +#define FUTEX2_16 0x01 > #define FUTEX2_32 0x02 > - /* 0x04 */ > +#define FUTEX2_64 0x03 > +#define FUTEX2_NUMA 0x04 > /* 0x08 */ > /* 0x10 */ > /* 0x20 */ > --- a/kernel/futex/syscalls.c > +++ b/kernel/futex/syscalls.c > @@ -183,7 +183,7 @@ SYSCALL_DEFINE6(futex, u32 __user *, uad > return do_futex(uaddr, op, val, tp, uaddr2, (unsigned long)utime, val3); > } > > -#define FUTEX2_MASK (FUTEX2_32 | FUTEX2_PRIVATE) > +#define FUTEX2_MASK (FUTEX2_64 | FUTEX2_PRIVATE) > > /** > * futex_parse_waitv - Parse a waitv array from userspace > @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute > if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved) > return -EINVAL; With the above aux.flags with FUTEX2_32 set will result in -EINVAL. I don't think that's intentional. Thanks, tglx