public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: lsf-pc@lists.linux-foundation.org,  linux-mm@kvack.org,
	 Michal Hocko <mhocko@suse.com>,
	 Dan Williams <dan.j.williams@intel.com>,
	 John Hubbard <jhubbard@nvidia.com>,  Zi Yan <ziy@nvidia.com>,
	 Bharata B Rao <bharata@amd.com>,
	 Dave Jiang <dave.jiang@intel.com>,
	 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
	 Alistair Popple <apopple@nvidia.com>,
	Christoph Lameter <cl@gentwo.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Linus Torvalds <torvalds@linux-foundation.org>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	 Mel Gorman <mgorman@suse.de>,  Jon Grimm <jon.grimm@amd.com>,
	 Gregory Price <gourry.memverge@gmail.com>,
	 Wei Xu <weixugc@google.com>,
	 Johannes Weiner <hannes@cmpxchg.org>,
	 SeongJae Park <sj@kernel.org>,
	 David Hildenbrand <david@redhat.com>,
	peterz@infradead.org,  a.manzanares@samsung.com
Subject: Re: [LSF/MM/BPF TOPIC] Locally attached memory tiering
Date: Mon, 13 May 2024 15:48:14 +0800	[thread overview]
Message-ID: <87frumcfup.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <sekh6rzzxdf4rjtk7z4rlxek2lp6x5ua35333lfjaax7mkh7pk@gxxskmzkjkzw> (Davidlohr Bueso's message of "Sun, 12 May 2024 18:49:25 -0700")

Davidlohr Bueso <dave@stgolabs.net> writes:

> On Thu, 09 May 2024, Huang, Ying wrote:
>
>>With the default configuration, current NUMA balancing based promotion
>>solution will almost try to promote any faulting pages.  To select hot
>>pages to promote and control thrashing between NUMA nodes, the promote
>>rate limit needs to be configured.  For example, via,
>>
>>echo 200 > /proc/sys/kernel/numa_balancing_promote_rate_limit_MBps
>>
>>200MB hot pages will be selected and promoted every second.  Can you try it?
>
> Yes, I've played with this tunnable and, just like the LRU approach, it
> shows nice micro wins (less amount of promotions/demotions) but little for
> actual benchmark improvements at a higher level, merely noise level or
> very sublte wins. In fact, the actual data from that series for this
> parameter was a ~2% pmbench win with the rate limiting, but a 69% promotion
> rate descrease.

Thanks a lot for update!

IIUC, page promotion/demotion only helps performance if there are hot
pages in the slow memory and cold pages in the hot memory.  This may be
not true for quite some workloads configurations.

For example, the default allocation mechanism is local first.  In the
context of memory tiering, it's the fast memory first.  In various
workloads, it's quite normal that hot pages will be allocated firstly.
This makes it unnecessary to optimize the page placement until there's
some configuration changes in the system.

So, to evaluate the optimization, we need to

1) check the overhead of the optimization when page placement is almost
optimal already.

2) find configurations where the page placement isn't good enough, and
check whether memory tiering optimization works.

> And this is really my point, how much effort do we want to put in optimizing
> software mechanisms for hot page detection? Are there other benchmarks we
> should be using? And perhaps doing the async promotion and not incurring in
> the numa balancing overhead and comparing the cost of migration before
> promoting would yield some better numbers, but that also might be easy to
> get wrong when compared to the relative hotness of the page.

I believe that there are still quite some spaces to optimize the
software mechanisms.  The current implementation is as simple as
possible in fact.

--
Best Regards,
Huang, Ying


  parent reply	other threads:[~2024-05-13  7:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240509173529uscas1p1b6e43b169514d36915cd2bc8aabc4200@uscas1p1.samsung.com>
2024-05-07  3:37 ` [LSF/MM/BPF TOPIC] Locally attached memory tiering David Rientjes
2024-05-07 11:52   ` Michal Hocko
2024-05-07 20:09     ` David Rientjes
2024-05-08  4:14   ` Huang, Ying
2024-05-10  3:10     ` David Rientjes
2024-05-08 21:39   ` Davidlohr Bueso
2024-05-09  1:42     ` Huang, Ying
2024-05-13  1:49       ` Davidlohr Bueso
2024-05-13  3:28         ` Bharata B Rao
2024-05-13  7:48         ` Huang, Ying [this message]
2024-05-09 17:35   ` Adam Manzanares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frumcfup.fsf@yhuang6-desk2.ccr.corp.intel.com \
    --to=ying.huang@intel.com \
    --cc=a.manzanares@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=apopple@nvidia.com \
    --cc=bharata@amd.com \
    --cc=cl@gentwo.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=david@redhat.com \
    --cc=gourry.memverge@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=jhubbard@nvidia.com \
    --cc=jon.grimm@amd.com \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=sj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=weixugc@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox