From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57604C7EE2F for ; Mon, 12 Jun 2023 17:28:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE4C96B0074; Mon, 12 Jun 2023 13:28:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D957F8E0005; Mon, 12 Jun 2023 13:28:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C36638E0003; Mon, 12 Jun 2023 13:28:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B4DE76B0074 for ; Mon, 12 Jun 2023 13:28:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B20214013A for ; Mon, 12 Jun 2023 17:28:39 +0000 (UTC) X-FDA: 80894780358.15.080EF1B Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B0B11C0013 for ; Mon, 12 Jun 2023 17:28:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=YrPFyhVi; spf=pass (imf18.hostedemail.com: domain of tsahu@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=tsahu@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686590917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cx95bW4SbB5z+l0ikJhaFb6aZ3vBFxncXDXQHurb2E0=; b=UehXMV0PwgAre4cEkq5SwXll0DhLiR4VZw+5QSS4PVoykrMbcmbuzsPu7V2oYtR3Qq0Rf/ Z7HAp+sbuhJp2YTfxZ+zsHqOfbL/WBbqJHiBNeRxWCMlgm+9j7urFERQAygxmFoSC17jWR +x44dxIPbtfW3WXpOE0esmsE/t9GCl8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686590917; a=rsa-sha256; cv=none; b=JQ3dkJA7DIayvZA5b2o0lL4gF2yUBh3vWlHmXs7295s1QMkmlD7/KDF9wtAEX/pNl3bYlx +4kuQOPIPwfOvD0Ny1nPz5QU5+MdHIc5ScfCcf92xLMNzzOZAWFTKH83c0j1DWjEm4CqUK BG5IAMeAIj78Mftrcshdqtj+y7QAaJk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=YrPFyhVi; spf=pass (imf18.hostedemail.com: domain of tsahu@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=tsahu@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35CHJqel015170; Mon, 12 Jun 2023 17:28:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=pp1; bh=cx95bW4SbB5z+l0ikJhaFb6aZ3vBFxncXDXQHurb2E0=; b=YrPFyhVi/dngQxTSkjS1ED+9QZPuGe/RTSHZkbdvn6/TwxowFX6SC/U44tWz1rV3D2Df x0fn2ZYEYY3YZPPKxz9NPaxwaqYSbml0MwCKy7jRDvETM89Lmtauv12h7E94wPIRbIib mFT0Kw/i8eA/1CjS5R+AjuQbx7UbfKV2RYms8dBOTRC5kUm8ZuYda6rBkwt1H9KjoZDy gVQY8jmmEpOftWdKpf5Wtluv2KS/g1Oxfw/xkPh7tchN+GLL1gDhkMTvBmCFPFoSipE0 H2sYHsM8yKFnkmMRRR8wXngwPPF/0b7N4RCTf5O6sw4VuFQTH5oBacwTDJ/jrqcW19c5 eA== Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r67ns059f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 17:28:32 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35CEpIqJ014911; Mon, 12 Jun 2023 17:28:30 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma03fra.de.ibm.com (PPS) with ESMTPS id 3r4gt517yb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jun 2023 17:28:30 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35CHSS2g15794826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Jun 2023 17:28:28 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 36B6220043; Mon, 12 Jun 2023 17:28:28 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B965320040; Mon, 12 Jun 2023 17:28:26 +0000 (GMT) Received: from tarunpc (unknown [9.43.32.94]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 12 Jun 2023 17:28:26 +0000 (GMT) From: Tarun Sahu To: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, willy@infradead.org, aneesh.kumar@linux.ibm.com, Sidhartha Kumar Subject: Re: [PATCH] mm: remove set_compound_page_dtor() In-Reply-To: <20230612163405.99345-1-sidhartha.kumar@oracle.com> References: <20230612163405.99345-1-sidhartha.kumar@oracle.com> Date: Mon, 12 Jun 2023 22:58:24 +0530 Message-ID: <87fs6w7fpj.fsf@linux.ibm.com> Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fKL54VRqqH0EXOA78_Sbn6K_iourvIkC X-Proofpoint-ORIG-GUID: fKL54VRqqH0EXOA78_Sbn6K_iourvIkC X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-12_06,2023-06-12_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 clxscore=1015 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306120147 X-Rspamd-Queue-Id: 4B0B11C0013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: snfnw11p9dey4c15puw61mazmtw3ah61 X-HE-Tag: 1686590917-470841 X-HE-Meta: U2FsdGVkX1+0txr2s+bGBrSpi/ePmqVuCMFYj/A0knGyHr8GERqyj2BgleuvtdGC8ITkhKWfqMsA92l8L6WHDFeVz7QM2ZjRfchTWZFGvuAhvrJQWvpIyqklO04tTvk4iexLoEmPEfGlyMOU0deKN/tG9KxjY1AFOzgQCe/i93jwhwE9ZZrjpJPyTeZ86CCZyXNUSlIJPVpf8TBkdsslqg6hPSP55judr7WWeZVMuZ+l2RSO8lxOTalUQNj+2ZyC5x+U6aAZ4z6wGPW/itIBA5Zz/CToCwZtGb9qimcpfb8gBf5l1xaKEpy8d7x5AdlWTiaVkLhd42fdgFr0lx1FDcLVwfKu704Xv5ry2T+S/r+YWFFTYvMZ04Rpe8VvFYrgr90dhySYXkZPlQE2UUDtFPEO+lxsJHhCkfl/6A3zWnlCTL1Y7h6vv36u6QnhHgCrs5W785HHIdpJn0Tfw+LAQIrjrThXGcIkGAeRIPBMP7JiTQYBO7gsH5p8ELOG3aKI2gtfxFqIXKKmOfAFygLcGtXTE/ltT9JteHYplHMSVE+vxdUxDt6s6tPriSewsbrxD863h6SWfTZpq8oT4PTAoZtGsG1SoX++ho2PpvskCRith6RaSitmvGUj6/+Bp8j5Z7Qsd6SkGQ1j3tWz/IeLipsgCEGOFZVNZYhSLkGPb+k4GDhqKInleP7o+PswxgkFUfW3pOdAV1lA/hOvA/Lrbh3f24tqlLFLrTKlulGY9R0A0mgkKqcCYApTfyYaRRPUzBGBnYz5nNZFRaYmB3n+UOXbi3QPTK9mS+Rdlkt+6KlrFutauhzKLDBXAS9IsK+Py2b85kdQmemIFu3VhuN4PNO+NsOf2gXycGdQpB+C67S0DcRdET8K3Ilot3Uu+nf6/hdTM0TLldKf73/Ndi9CidXqAgNX3DS+KECLI70MkMjbiBMtp5H6m1vC1VGtV+gpylg+iUscnPd2WOs82xF +/8L8/db dFiLe6Mx/muMoNMkGirIWWNRA2LJoXEbj4SJbhlq1Ug7SOy8vwLsd1SdNNn9pv1cgfzwWvPyv3yn8Nn/SrQiH2KetRZK7djjgfV+j9dteETWoepNzyzek9Ge4f1YpfI1xnZ875NoIlgvODIGco+bBkfr4SUbEVJr+JBwiv66aFVdhGOKGDpiEsQ8PpRJ3ZCGlKspmQeLEXB8qzHLaSwO0ohLgrcxzYbY+YFS83CobzzTO1qg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: LGTM; Sidhartha Kumar writes: > All users can use the folio equivalent so this function can be safely > removed. > > Signed-off-by: Sidhartha Kumar > --- > > rebased on 06/12/23 mm-unstable + Tarun's patch[1] > [1]: https://lore.kernel.org/linux-mm/20230612093514.689846-1-tsahu@linux.ibm.com/ > > include/linux/mm.h | 10 ---------- > mm/huge_memory.c | 2 +- > mm/internal.h | 2 +- > 3 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 4a1aec5e4b83c..485224cd62ffb 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1223,16 +1223,6 @@ enum compound_dtor_id { > }; > extern compound_page_dtor * const compound_page_dtors[NR_COMPOUND_DTORS]; > > -static inline void set_compound_page_dtor(struct page *page, > - enum compound_dtor_id compound_dtor) > -{ > - struct folio *folio = (struct folio *)page; > - > - VM_BUG_ON_PAGE(compound_dtor >= NR_COMPOUND_DTORS, page); > - VM_BUG_ON_PAGE(!PageHead(page), page); > - folio->_folio_dtor = compound_dtor; > -} > - > static inline void folio_set_compound_dtor(struct folio *folio, > enum compound_dtor_id compound_dtor) > { > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 31bc8fa768e3d..76f970aa5b4da 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -583,7 +583,7 @@ void prep_transhuge_page(struct page *page) > > VM_BUG_ON_FOLIO(folio_order(folio) < 2, folio); > INIT_LIST_HEAD(&folio->_deferred_list); > - set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR); > + folio_set_compound_dtor(folio, TRANSHUGE_PAGE_DTOR); > } > > static inline bool is_transparent_hugepage(struct page *page) > diff --git a/mm/internal.h b/mm/internal.h > index 61acceface45f..a64967bfcd2ab 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -406,7 +406,7 @@ static inline void prep_compound_head(struct page *page, unsigned int order) > { > struct folio *folio = (struct folio *)page; > > - set_compound_page_dtor(page, COMPOUND_PAGE_DTOR); > + folio_set_compound_dtor(folio, COMPOUND_PAGE_DTOR); > folio_set_order(folio, order); > atomic_set(&folio->_entire_mapcount, -1); > atomic_set(&folio->_nr_pages_mapped, 0); Reviewed-by: Tarun Sahu