From: Thomas Gleixner <tglx@linutronix.de>
To: Yury Norov <yury.norov@gmail.com>,
linux-kernel@vger.kernel.org,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Alexey Klimov <aklimov@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrii Nakryiko <andrii@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ben Segall <bsegall@google.com>, Christoph Lameter <cl@linux.com>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dennis Zhou <dennis@kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Eric Dumazet <edumazet@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Ingo Molnar <mingo@redhat.com>,
Isabella Basso <isabbasso@riseup.net>,
John Fastabend <john.fastabend@gmail.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Juergen Gross <jgross@suse.com>,
Juri Lelli <juri.lelli@redhat.com>, KP Singh <kpsingh@kernel.org>,
Kees Cook <keescook@chromium.org>,
Martin KaFai Lau <kafai@fb.com>, Mel Gorman <mgorman@suse.de>,
Miroslav Benes <mbenes@suse.cz>,
Nathan Chancellor <nathan@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Song Liu <songliubraving@fb.com>,
Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Vlastimil Babka <vbabka@suse.cz>, Yonghong Song <yhs@fb.com>,
Yury Norov <yury.norov@gmail.com>,
linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 11/16] time: optimize tick_check_preferred()
Date: Sat, 06 Aug 2022 10:30:53 +0200 [thread overview]
Message-ID: <87fsi9rcxu.ffs@tglx> (raw)
In-Reply-To: <20220718192844.1805158-12-yury.norov@gmail.com>
On Mon, Jul 18 2022 at 12:28, Yury Norov wrote:
> tick_check_preferred() calls cpumask_equal() even if
> curdev->cpumask == newdev->cpumask. Fix it.
What's to fix here? It's a pointless operation in a slow path and all
your "fix' is doing is to make the code larger.
Thanks,
tglx
next prev parent reply other threads:[~2022-08-06 8:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 19:28 [PATCH 00/16] Introduce DEBUG_BITMAP config option and bitmap_check_params() Yury Norov
2022-07-18 19:28 ` [PATCH 01/16] lib/bitmap: add bitmap_check_params() Yury Norov
2022-07-18 21:01 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 02/16] lib/bitmap: don't call bitmap_set() with len == 0 Yury Norov
2022-07-18 21:06 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 03/16] lib/test_bitmap: don't test bitmap_set if nbits " Yury Norov
2022-07-18 21:08 ` Andy Shevchenko
2022-08-09 12:37 ` Rasmus Villemoes
2022-07-18 19:28 ` [PATCH 04/16] lib/test_bitmap: test test_bitmap_arr{32,64} starting from nbits == 1 Yury Norov
2022-07-18 21:09 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 05/16] lib/test_bitmap: disable compile-time test if DEBUG_BITMAP() is enabled Yury Norov
2022-07-18 21:10 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 06/16] lib/test_bitmap: delete meaningless test for bitmap_cut Yury Norov
2022-07-18 21:11 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 07/16] smp: optimize smp_call_function_many_cond() Yury Norov
2022-07-18 21:26 ` Peter Zijlstra
2022-07-18 21:36 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 08/16] smp: optimize smp_call_function_many_cond() for more Yury Norov
2022-07-18 21:29 ` Peter Zijlstra
2022-07-20 17:06 ` Yury Norov
2022-07-18 21:37 ` Andy Shevchenko
2022-07-18 19:28 ` [PATCH 09/16] irq: don't copy cpu affinity mask if source is equal to destination Yury Norov
2022-07-18 21:30 ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 10/16] sched: optimize __set_cpus_allowed_ptr_locked() Yury Norov
2022-07-18 21:34 ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 11/16] time: optimize tick_check_preferred() Yury Norov
2022-08-06 8:30 ` Thomas Gleixner [this message]
2022-08-08 11:42 ` Thomas Gleixner
2022-08-08 16:38 ` Yury Norov
2022-08-09 12:29 ` Rasmus Villemoes
2022-07-18 19:28 ` [PATCH 12/16] time: optimize tick_check_percpu() Yury Norov
2022-07-18 19:28 ` [PATCH 13/16] time: optimize tick_setup_device() Yury Norov
2022-07-18 21:35 ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 14/16] mm/percpu: optimize pcpu_alloc_area() Yury Norov
2022-07-19 4:25 ` Dennis Zhou
2022-07-18 19:28 ` [PATCH 15/16] sched/topology: optimize topology_span_sane() Yury Norov
2022-07-18 21:37 ` Peter Zijlstra
2022-07-18 19:28 ` [PATCH 16/16] lib: create CONFIG_DEBUG_BITMAP parameter Yury Norov
2022-07-18 21:39 ` Andy Shevchenko
2022-07-20 16:49 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsi9rcxu.ffs@tglx \
--to=tglx@linutronix.de \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexandr.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@iogearbox.net \
--cc=dennis@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=isabbasso@riseup.net \
--cc=jgross@suse.com \
--cc=john.fastabend@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=mbenes@suse.cz \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yhs@fb.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).