From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20B8C25B06 for ; Sat, 6 Aug 2022 08:30:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25EA76B0072; Sat, 6 Aug 2022 04:30:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20DD48E0001; Sat, 6 Aug 2022 04:30:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FE126B0074; Sat, 6 Aug 2022 04:30:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0093C6B0072 for ; Sat, 6 Aug 2022 04:30:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C2C1880782 for ; Sat, 6 Aug 2022 08:30:56 +0000 (UTC) X-FDA: 79768497312.30.2648A36 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 1EC92C0117 for ; Sat, 6 Aug 2022 08:30:55 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1659774653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=E1CMU6Dl6hEHJsFFfONIFG26dG22lAy7Is0O1sAUYTeZ1srkiAZEe7JFtbZNyesMnJfwOG hUl5AvC0Q8mnm7GZzQ3J9/Iia437hi/gbtkY9hUoRA2lsMHbLgyX0UVJfWQtPEGx9PIkOy rVD4sGRedtJ32HjEjEm9vP2eUpVmvdQFXNbNNIwQ5GRxdCI4/pWC1nCj+dC83MG0pvimJs CRA9OKRL9jFO8rI43SoZSPV0YOAncDpoI6HG3tT/L+O7pxrJWFyCgdOHNayh2shIlZhFXa efXnddpctbWVUHH8KUnM/OgSzjMbs4JEdGxiriLaW5qE/huno18y5Yk2LZPGoQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1659774653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=+4GPKoy6VlEqy5c/lQ6BDMSTFeovlKihb/Hs4NPgW3pr8Uvtc+BYZDVGQyr5zslyvGvo1n CF9bgtDm4R23oZCA== To: Yury Norov , linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , Yury Norov , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 11/16] time: optimize tick_check_preferred() In-Reply-To: <20220718192844.1805158-12-yury.norov@gmail.com> References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-12-yury.norov@gmail.com> Date: Sat, 06 Aug 2022 10:30:53 +0200 Message-ID: <87fsi9rcxu.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=E1CMU6Dl; dkim=pass header.d=linutronix.de header.s=2020e header.b=+4GPKoy6; spf=pass (imf22.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659774656; a=rsa-sha256; cv=none; b=fGyH2lJ2geC2i+eVyF8gCdWL3MA8iIIBGvZB/V4Z2N9jTWJkmh5QS0ANz1QYBIN8Xe38Ni BOq6a9uwxkBZsyWPSuv2ZgEWRi/4oEJ9WT0qrfLM2CMk0kv5jOEhsVF+HS37QpH9IUEgHj EAfqCiA8SzgiNONd9425cbvHK4e07iQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659774656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=cV/7G5yYI+rC8aazQDvUo62BjEtceX2erbxSDiwwLOHjWN1NhJe2QMhUFAZqqSF0gz2zEH XAMckoNAnumOxPEKMh+T2RRzKx27GEYenWmiDRER/p5KYxq3VAyDeSjrapZ9ux3JfgTbHf yc+4uw+mLidj+81EQPoh9fjQ5boCbTI= X-Rspamd-Server: rspam09 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=E1CMU6Dl; dkim=pass header.d=linutronix.de header.s=2020e header.b=+4GPKoy6; spf=pass (imf22.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Stat-Signature: iehwqk4497hxcc6r7tsk4wqduzmbsfej X-Rspamd-Queue-Id: 1EC92C0117 X-HE-Tag: 1659774655-47666 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 18 2022 at 12:28, Yury Norov wrote: > tick_check_preferred() calls cpumask_equal() even if > curdev->cpumask == newdev->cpumask. Fix it. What's to fix here? It's a pointless operation in a slow path and all your "fix' is doing is to make the code larger. Thanks, tglx