From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D21C77B7F for ; Tue, 16 May 2023 08:18:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 915B4900003; Tue, 16 May 2023 04:18:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C588900002; Tue, 16 May 2023 04:18:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DBD3900003; Tue, 16 May 2023 04:18:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E710900002 for ; Tue, 16 May 2023 04:18:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 20BB74018A for ; Tue, 16 May 2023 08:18:41 +0000 (UTC) X-FDA: 80795416842.21.0F34C87 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 40A89100002 for ; Tue, 16 May 2023 08:18:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=NKvtSAPG; dkim=pass header.d=linutronix.de header.s=2020e header.b=h1UUO3M6; spf=pass (imf05.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684225119; a=rsa-sha256; cv=none; b=nmie8HV9gpn9hcB2wfWb+jEZNKlhseu9f06eNShKgTFTMbvsj7+WWh3eiVJjDM6qhdR0Ik 9w+NJdNbGXnshJaqYSnwvk/sESzLps4s2llye7X7JUEfTdkhihJ6qjO0/dXZn4D1/KIq6h 8Q0WsdIF8M/ceoCI/oGrK8GT8/4DsJE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=NKvtSAPG; dkim=pass header.d=linutronix.de header.s=2020e header.b=h1UUO3M6; spf=pass (imf05.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684225119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y/RF0+4saSFJWcIwD0B4SoOuVVvFYLVuS5i7ESpWY5c=; b=dAO3TRBWEq1eaQv76zZs8AdhmjeQOm9mlniPbUDOaeuZX8CQQZ8+5sZmryjcXdAhuvgWy3 3wtft6e9LkCSsYcyq+DY2IiuXg/DZ8n2PAZAUcNRxnNPETpNv5ei0aBEdSdOhpBtkhgeP8 4GlDtPj4iSwaXsOTkEb50ZB5AvknPiU= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684225116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y/RF0+4saSFJWcIwD0B4SoOuVVvFYLVuS5i7ESpWY5c=; b=NKvtSAPGawXLbgxpMU6eesKqHtY2Wdmp7gluRnAnVyvYLzNIBidg2+3eFuWT+BOIuYLa7R xB2rWhzPesXy0Wq6nlJbW9MOSE4tTMwbsTwx4Sr0Uqx6Y68lSvpiLectTHcqX77OL+UyL5 Gde3db8FNb8+6nBCAXLs/CSSjB0IuM5XC962RHhV+ajFpkNgQR8aYfis2LvbJ1RkuNj3M4 s1sQhoI5bjgMzPGQ/TjzHL23Ed4PnV2Ssn25Fw02q4EbKn3JqwXyER6d74jmr44v+cJAGV WlAey4Hz8CgQJV6yu1nYV3VcRRB3em6KVOUY/4d0nDVOVDraDOj96bjDg34GlQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684225116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y/RF0+4saSFJWcIwD0B4SoOuVVvFYLVuS5i7ESpWY5c=; b=h1UUO3M6yKAEoZ0Qpclg6SHetbfiovPfeFGnvfwRSOFJvkzM2e25Fte/95FfhPCbSRbQiO cZaCYF6GS3MifaCw== To: "Russell King (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: Excessive TLB flush ranges In-Reply-To: <87r0rg93z5.ffs@tglx> References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> Date: Tue, 16 May 2023 10:18:36 +0200 Message-ID: <87ilcs8zab.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: 5ak9hhqce3zzp9fgwpm6id7omsf96i87 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 40A89100002 X-HE-Tag: 1684225118-788741 X-HE-Meta: U2FsdGVkX1+IlxMwOfFbfLvRq0cKA5BKRW+oFz1Z9IYZ+lVaYrDRdC0p7FOnFo5MIw/TTyKNpxjYm2XAp38BLmg9DSWvZWBnASv5rDPfk90dvx2Fup6L1vWWQwKCl+g2fYzaO62dc5DWA0e7PeQTUjtPs8+wKiCuKm4GXIu5wAIFV+4fHJxvyfdUwk+e+Duakk8wFrssj3CuylhNeW9pEx0e5DQhHu39trhZ5FSG9xVTCY4UYnqCoXFSjg9MtDvWUirPXMu/cr6nxZ58XwrWatYoqdJHzz3a3myW4HKZjlzVJqe0C0jUfyYjh9+bciRjo8lsAeWEYG0g8jPpPSYLzA/4wmMEfb2wEcqa3NFMuUZ5BVHN1FDeggFbwFx91ILHbv46kD4tQmWXnRQxiwa8Kwm1zU8oWAOQz5GJM4smAiJX/vZhr/HrAX86Nf7ng6Vha/kXQxFL7shQdRhX1v2ljCMsEdBMYE2IyH+EIaJ2EvAK+kN1X9v1fLfeanTjP5YakDm8CcMx1bXXQmwjy2yDuWhkJe/UyDnkooCkuqbJiXTXYJ2zfK+J163qMIcAS3qKmB5D/aEm3Zj70NnfWNJUiIL8+ZDA9NW1M64fV58B8wA7HQ2eG8u1a3kvUiu0QN8isnm7eeYHwK7GN6rjYF9htje438af1+DjFBryMZYD2m0JxIfJQn/S8SeTn4PIDExmU5458Hi6aPt25r5gbyQQVDq6hmAaHt2hXY1LgJjlFjpVkjrlT2ax65nLUPmXgsHeKINER0MgdWPIh9EjQS126575qozYzGsElxaH3MQqjAEJtMSrCXs11OPZepn54q89I2iYyiIrKUAclajmyHiakasIaKTjLVAhdqvcWN9v32VjvIUvO5rVjPrsCS1AsW2mPKP5RYDizfM5hbKwwDhsn/dBYKymU67APrMkMknrl7fd5pPEMCCITcjKMVe3pQEKmZ1THAqCpqC/rbVlxoW oarQVnyx ITYVomIIXSreAVOK6R8oluJNt7K6gsqUL82PlSTdTJ86yjy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16 2023 at 08:37, Thomas Gleixner wrote: > On Mon, May 15 2023 at 22:31, Russell King wrote: >>> + list_for_each_entry(va, list, list) { >>> + /* flush range by one by one 'invlpg' */ >>> + for (addr = va->va_start; addr < va->va_end; addr += PAGE_SIZE) >>> + flush_tlb_one_kernel(addr); >> >> Isn't this just the same as: >> flush_tlb_kernel_range(va->va_start, va->va_end); > > Indeed. Actually not. At least not on x86 where it'd end up with 3 IPIs for that case again, instead of having one which walks the list on each CPU. Thanks, tglx