Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap()

Christoph Hellwig
2024-08-15T05:02:47Z

On Wed, Aug 14, 2024 at 04:11:31PM +0200, Thomas Gleixner wrote:
> > Various architectures had either an early ioremap variant that got
> > silently ignored here, or magic carveout that don't get remapped at all.
> > None of this should currently apply to x86, though.
>
> So I'm inclined to have:
>
> if (WARN_ON_ONCE(is_ioremap_addr(addr)))
> return;
>
> in the x86 variant then.

And we should do the same for the generic code eventually after
accounting for all exceptions. Those should these days mostly be
handled before hand and have explicit address ranges as well, but it'll
need some time to figure all that out.