From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B2DC433EF for ; Sat, 14 May 2022 08:37:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80CD16B0073; Sat, 14 May 2022 04:37:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BC756B0075; Sat, 14 May 2022 04:37:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 684428D0001; Sat, 14 May 2022 04:37:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5735E6B0073 for ; Sat, 14 May 2022 04:37:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 17972BB5 for ; Sat, 14 May 2022 08:37:29 +0000 (UTC) X-FDA: 79463694618.08.49E905B Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 8A1081800CA for ; Sat, 14 May 2022 08:37:19 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652517446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gT7kvFRN/C45ruQBTGaFvxVwWlGbId47OUjeiXRcTM=; b=Apdt16C17m0cIokAHKk4o2PXGYmSa5bG8UGDgg9e5ZelgxTo5fwgdUSzWuBa6q9NAmr5gj TUhg/kOzc624Gfy91z5tNip3dZuFfBTknJW/ONihJOayv3pxBALZnQzP2BISY/k8ZWIXcV rmo55JL5dQyiZNnMh3S/idR0R1WOnZHnbQK8TmEql5jA9aU9dBAtajYX8vjjo7nvkl7KBP oLIaMZesyk6jN0sPeaeiRP9lpRfuxxjT8mPzYZSgtu5bgDRyGl0b+4Hmx13WJnxnFLxvI4 FOZv/qkLzPsAlRQGjfwLkwSGROZkoJ4asoAhwvW2HzrWd/x1vq/HPpSmR0PCMw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652517446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gT7kvFRN/C45ruQBTGaFvxVwWlGbId47OUjeiXRcTM=; b=1GtN2iV9LZWcMhkCxXjgcde7PntaqmRfol14sgZP7miE6WluolGTRDMTex4IeDVOK0LUuC 6KQg7nvF3l8e4RAQ== To: "Edgecombe, Rick P" , "kirill.shutemov@linux.intel.com" Cc: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "hjl.tools@gmail.com" , "linux-mm@kvack.org" , "dave.hansen@linux.intel.com" , "aryabinin@virtuozzo.com" , "dvyukov@google.com" , "x86@kernel.org" , "ak@linux.intel.com" , "Lutomirski, Andy" , "glider@google.com" Subject: Re: [RFCv2 03/10] x86: Introduce userspace API to handle per-thread features In-Reply-To: <543eb3ff98f624c6cfa1d450ac3e9ae8934c7c38.camel@intel.com> References: <20220511022751.65540-1-kirill.shutemov@linux.intel.com> <20220511022751.65540-5-kirill.shutemov@linux.intel.com> <20220513230958.dbxp6m3y3lnq74qb@black.fi.intel.com> <543eb3ff98f624c6cfa1d450ac3e9ae8934c7c38.camel@intel.com> Date: Sat, 14 May 2022 10:37:25 +0200 Message-ID: <87k0aose62.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Apdt16C1; dkim=pass header.d=linutronix.de header.s=2020e header.b=1GtN2iV9; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8A1081800CA X-Rspam-User: X-Stat-Signature: x8dtrcqxfe5gegshc9c8kjxrp1h9cin6 X-HE-Tag: 1652517439-667084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 13 2022 at 23:50, Edgecombe, Rick P wrote: > On Sat, 2022-05-14 at 02:09 +0300, Kirill A. Shutemov wrote: >> On Fri, May 13, 2022 at 05:34:12PM +0000, Edgecombe, Rick P wrote: >> > On Fri, 2022-05-13 at 16:09 +0200, Alexander Potapenko wrote: >> > > > + >> > > > + /* Handle ARCH_THREAD_FEATURE_ENABLE */ >> > > > + >> > > > + task->thread.features |= features; >> > > > +out: >> > > > + return task->thread.features; >> > > >> > > Isn't arch_prctl() supposed to return 0 on success? >> > >> > Hmm, good point. Maybe we'll need a struct to pass info in and out. >> >> But values >0 are unused. I don't see why can't we use them. > > Hmm, I don't know what it would break since it is a new "code" > argument. But the man page says: > "On success, arch_prctl() returns 0; on error, -1 is returned, and > errno is set to indicate the error." > > So just change the man pages? > "On success, arch_prctl() returns positive values; on error, -1 is > returned, and errno is set to indicate the error." Why? prctl(GET, &out) is the pattern used all over the place. Thanks, tglx