From: Jonathan Corbet <corbet@lwn.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>, linux-doc@vger.kernel.org
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: arch_pgtable_helpers: demote pgtable list headings
Date: Tue, 05 Apr 2022 10:15:10 -0600 [thread overview]
Message-ID: <87k0c3ecc1.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220326131313.691027-1-bagasdotme@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> Demote pgtable list headings from title heading to chapter heading.
This is a classic example of the sort of changelog that says *what* the
patch does (which we can also see from the patch itself) but not *why*.
Why do these headings need to be changed?
Thanks,
jon
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> Documentation/vm/arch_pgtable_helpers.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/vm/arch_pgtable_helpers.rst b/Documentation/vm/arch_pgtable_helpers.rst
> index f8b225fc919047..cbaee9e592410f 100644
> --- a/Documentation/vm/arch_pgtable_helpers.rst
> +++ b/Documentation/vm/arch_pgtable_helpers.rst
> @@ -13,7 +13,7 @@ Following tables describe the expected semantics which can also be tested during
> boot via CONFIG_DEBUG_VM_PGTABLE option. All future changes in here or the debug
> test need to be in sync.
>
> -======================
> +
> PTE Page Table Helpers
> ======================
>
> @@ -79,7 +79,7 @@ PTE Page Table Helpers
> | ptep_set_access_flags | Converts into a more permissive PTE |
> +---------------------------+--------------------------------------------------+
>
> -======================
> +
> PMD Page Table Helpers
> ======================
>
> @@ -153,7 +153,7 @@ PMD Page Table Helpers
> | pmdp_set_access_flags | Converts into a more permissive PMD |
> +---------------------------+--------------------------------------------------+
>
> -======================
> +
> PUD Page Table Helpers
> ======================
>
> @@ -209,7 +209,7 @@ PUD Page Table Helpers
> | pudp_set_access_flags | Converts into a more permissive PUD |
> +---------------------------+--------------------------------------------------+
>
> -==========================
> +
> HugeTLB Page Table Helpers
> ==========================
>
> @@ -235,7 +235,7 @@ HugeTLB Page Table Helpers
> | huge_ptep_set_access_flags | Converts into a more permissive HugeTLB |
> +---------------------------+--------------------------------------------------+
>
> -========================
> +
> SWAP Page Table Helpers
> ========================
>
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
> --
> An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-04-05 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 13:13 [PATCH] Documentation: arch_pgtable_helpers: demote pgtable list headings Bagas Sanjaya
2022-04-05 16:15 ` Jonathan Corbet [this message]
2022-04-06 4:55 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0c3ecc1.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=axboe@kernel.dk \
--cc=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).