From: Andreas Hindborg <a.hindborg@kernel.org>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christoph Lameter" <cl@gentwo.org>,
"David Rientjes" <rientjes@google.com>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Tamir Duberstein" <tamird@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Harry Yoo" <harry@kernel.org>, "Hao Li" <hao.li@linux.dev>,
"Daniel Gomez" <da.gomez@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v4 06/11] rust: xarray: add `find_next` and `find_next_mut`
Date: Thu, 27 Aug 2026 11:49:37 +0200 [thread overview]
Message-ID: <87mru728r2.fsf@t14s.mail-host-address-is-not-set> (raw)
In-Reply-To: <BEA4B094-7587-45C8-801C-A6F49E574EA6@collabora.com>
Daniel Almeida <daniel.almeida@collabora.com> writes:
> Hi Andreas,
>
> I wonder if we can't hoist most of these calls accessing self.state.state to
> the XArrayState directly? For example, I see this in a couple of places:
>
> + bindings::xas_result(
> + &mut self.state.state,
> + bindings::xa_zero_to_null(bindings::xas_store(
> + &mut self.state.state,
> + core::ptr::null_mut(),
> + )),
> + )
>
>
> How about XArrayState::replace(new: *mut c_void) -> *mut c_void?
>
> Also:
>
> + state.state.xa_node = bindings::XAS_RESTART as *mut bindings::xa_node;
> + state.state.xa_index = 0;
>
> Could be e.g.: "restart_at(index)”.
>
>
> WDYT?
I think that is a good suggestion, I will do that.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2026-08-27 9:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 19:58 [PATCH v4 00/11] rust: xarray: add entry API with preloading Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 01/11] rust: xarray: minor formatting fixes Andreas Hindborg
2026-08-26 21:42 ` Daniel Almeida
2026-06-04 19:58 ` [PATCH v4 02/11] rust: xarray: add debug format for `StoreError` Andreas Hindborg
2026-06-05 15:15 ` Tamir Duberstein
2026-06-09 8:06 ` Andreas Hindborg
2026-08-26 21:43 ` Daniel Almeida
2026-06-04 19:58 ` [PATCH v4 03/11] rust: xarray: add `XArrayState` Andreas Hindborg
2026-06-05 15:15 ` Tamir Duberstein
2026-06-09 8:38 ` Andreas Hindborg
2026-08-27 0:55 ` Daniel Almeida
2026-08-27 9:48 ` Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 04/11] rust: xarray: use `xas_load` instead of `xa_load` in `Guard::load` Andreas Hindborg
2026-08-27 0:59 ` Daniel Almeida
2026-06-04 19:58 ` [PATCH v4 05/11] rust: xarray: simplify `Guard::load` Andreas Hindborg
2026-06-05 15:15 ` Tamir Duberstein
2026-06-09 8:39 ` Andreas Hindborg
2026-08-27 1:04 ` Daniel Almeida
2026-06-04 19:58 ` [PATCH v4 06/11] rust: xarray: add `find_next` and `find_next_mut` Andreas Hindborg
2026-06-05 15:15 ` Tamir Duberstein
2026-08-25 12:43 ` Andreas Hindborg
2026-08-27 1:14 ` Daniel Almeida
2026-08-27 9:49 ` Andreas Hindborg [this message]
2026-06-04 19:58 ` [PATCH v4 07/11] rust: xarray: add entry API Andreas Hindborg
2026-06-05 15:15 ` Tamir Duberstein
2026-08-25 12:49 ` Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 08/11] rust: mm: add abstractions for allocating from a `sheaf` Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 09/11] rust: mm: sheaf: allow use of C initialized static caches Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 10/11] xarray, radix-tree: enable sheaf support for kmem_cache Andreas Hindborg
2026-06-04 19:58 ` [PATCH v4 11/11] rust: xarray: add preload API Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mru728r2.fsf@t14s.mail-host-address-is-not-set \
--to=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cl@gentwo.org \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox