From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D32C25B75 for ; Wed, 15 May 2024 05:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB688D0070; Wed, 15 May 2024 01:41:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E43898D004F; Wed, 15 May 2024 01:41:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE47C8D0070; Wed, 15 May 2024 01:41:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AEEEC8D004F for ; Wed, 15 May 2024 01:41:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 72A5A1C1A70 for ; Wed, 15 May 2024 05:41:58 +0000 (UTC) X-FDA: 82119533916.18.5A94A88 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 77DC3100004 for ; Wed, 15 May 2024 05:41:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TUVIDYBV; spf=pass (imf05.hostedemail.com: domain of bjorn@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715751716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TNKUNrV79q8bDm3/v/Z/EAKKmqJ57RDlAkQ14BHbbLA=; b=qVcJc4IlW07faFZGqSNPJa6g6myY1/3eUVpVfbMAE0BBrMGT9SYBZ2ZDOKJfrRQUBX+c3H BnmgTa2Y7L+KeT0I8Ts1sI37g5OElftlP7ZUjLZc+9kurIIrJf/kOasM6hSuU0ax/84qaP VGSVcr1ikBZPcJBQcu3B7xRoYshKkAM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715751716; a=rsa-sha256; cv=none; b=dtAbvPUR7dPvYz4pAgZrc5HXbNHJWv4s0QdMBWIFkZbh43AEO+LJ0PWNHlS+Pnv8TJzqpD tCe+OcI+oK/JgtXnxarrZWNeCR8ZMQTnDcGGF4zYS9YruexjJKvPCOMEYMxdTMigCzQE8O tNYhRlN5wM5FKKGAzp15x4I3k536mEE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TUVIDYBV; spf=pass (imf05.hostedemail.com: domain of bjorn@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 136D7CE02C5; Wed, 15 May 2024 05:41:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C70C116B1; Wed, 15 May 2024 05:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715751711; bh=mmF1KeXBL7U8C83N3jzFBWR9OlDzinn1tPvhQxIcJoQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TUVIDYBV82kiQ+MFfP94+TJanOMTxDKNqpExsyY9WyUZ6gqtJJodG6QmXkZONJXu6 1aK0ScbFd5P7+OEvorRw1zak3jD3s7josaNFDIOSM+aAHbyC82x0oBfodS6bxHnsMy FPKE6S+7j/+G3Dq8AJw8dGiJaHb175oVUGu0KEjaFR+ZTgHymuInC4OSeDzGTmIKVE kc5kWNkFxUxTTMla+TmklOYF4jdwnWpSAE4BNWIi1Eg7XQX9dgykMF3lx348dpGUf3 91UIiOXPBMy79Wt/kYXkcI+Yx0xixEsVwhv5FjyfPazlBlTv79liNDyERSF+kyo5XH uo2vBxfXbfz/g== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Oscar Salvador Cc: Alexandre Ghiti , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 4/8] riscv: mm: Add memory hotplugging support In-Reply-To: References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-5-bjorn@kernel.org> Date: Wed, 15 May 2024 07:41:47 +0200 Message-ID: <87msork4x0.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 77DC3100004 X-Rspam-User: X-Stat-Signature: 16dkjmcazaf3rwr8wphif6nxbo3xoxpz X-HE-Tag: 1715751716-499379 X-HE-Meta: U2FsdGVkX1+/JZnQaN2QVaHvhOK67fwmdtl8pQADyoh49u2K+lLZ5QysNpFyxO7vadGTl4LxN2QNpll6pq2Tquy8CFC4eN2Syo+HqeNPY2r1OCZUmp+9vGy7BNPxU0kOtayt2IENu5maJDasSblnLYPrn9JHmND06IQf/rIg8Tb4nqtL+KeEayGsrHc3N81192bbKoJpR/C7/UNcAIqw6hNYOi8fGQUh9VdSd6IOSv+ypLj/YpAY5KFMXeO1RDRWzWd+Qgrl31hCZtiXqOmvot1OM81hXxvgEb2FBHjS0918K+L7oxAXy/doRGZvQ+wAOT4Br/N2C47Fdt6k5tJ9XhLmw5r9fAyEk8XW7GLoi3vgBxlZid7E8dr4jgBDF36c/gSZszT7aVCxG02zx9lxvQp9RRTjs3nYrYeX0qS+dA6Nf2XuX6q5cpPDOqtrCniRO7mLwz0nMXMByUwej98jkmthrvn/9ADK65YOM9iJ97pdurDo4eElkmfWgFj5giNhLOgrzTium9qmI/nT02SURafbZ+5LNetbFK5CtASUuCW9XmMBxKekHOWJBUG6dHm6yB3dJYZbhrLlkUsFoQjswbl8CQ1rW89u1aRW8nzVFgOTTYhaW80yRVSNsdVfPCNqfdChcf/CkrxBv0ya3j/g01duYaNKgIDLa/YlGvBiAqjyMif0Oq0DfysQhxU/AvxsEulrcncul5L1DAJfYuJAAyxjXgsy5bnChdWaZsU5uB0xLLyVeGJrw2lMkx/jczy25gmvLUdMl09pwEeq/i8b2nicz5QTR92N4X/7wTGfWvW9E/nC2yeswQQpo6dJSFfp4as5DwCMiVuxlTXmKxwodM57o14ZIPCVWnE7IPRfC0MOpE7x399U2a8bXbYLtsDCCnEKKl43U4swhl19zzmC2zwZzTEsZbHccvLafkSRsLmu5/XKkj6IihNt1KJv7PyFLPpALgd8vCMI0GGG7Tm +F0YcU3W 3k0fOQAEpHKPho2AyM7Ocps3P9H+TnaLkHXWrJjIQlQ8c5+bH4YTTULkJRVe3xJ/2KEwKXPHHAWMIZbrs3VHU6FS84HHreFnkEiUiHMnHi24VHIzVSAC9v8sWzLM9bxhYvj//bZ7ooWNFPHEwgvh/bdg7PtWvvuh7aKbmxVm2tMpkKDliIxEWgw3cwljcRvA54n5nsdwmx85TzxJEUmQifrm6AvN5KTQPUCm0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Oscar Salvador writes: > On Tue, May 14, 2024 at 04:04:42PM +0200, Bj=C3=B6rn T=C3=B6pel wrote: >> +static void __meminit free_vmemmap_storage(struct page *page, size_t si= ze, >> + struct vmem_altmap *altmap) >> +{ >> + if (altmap) >> + vmem_altmap_free(altmap, size >> PAGE_SHIFT); >> + else >> + free_pages((unsigned long)page_address(page), get_order(size)); > > David already pointed this out, but can check > arch/x86/mm/init_64.c:free_pagetable(). > > You will see that we have to do some magic for bootmem memory (DIMMs > which were not hotplugged but already present) Thank you! >> +#ifdef CONFIG_SPARSEMEM_VMEMMAP >> +void __ref vmemmap_free(unsigned long start, unsigned long end, struct = vmem_altmap *altmap) >> +{ >> + remove_pgd_mapping(start, end, true, altmap); >> +} >> +#endif /* CONFIG_SPARSEMEM_VMEMMAP */ >> +#endif /* CONFIG_MEMORY_HOTPLUG */ > > I will comment on the patch where you add support for hotplug and the > dependency, but on a track in LSFMM today, we decided that most likely > we will drop memory-hotplug support for !CONFIG_SPARSEMEM_VMEMMAP > environments. > So, since you are adding this plain fresh, please consider to tight the > hotplug dependency to CONFIG_SPARSEMEM_VMEMMAP. > As a bonus, you will only have to maintain one flavour of functions. Ah, yeah, I saw it mentioned on the LSF/MM/BPF topics. Less is definitely more -- I'll make the next version depend on SPARSEMEM_VMEMMAP. Bj=C3=B6rn