From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx145.postini.com [74.125.245.145]) by kanga.kvack.org (Postfix) with SMTP id F034F6B005C for ; Wed, 21 Aug 2013 05:54:30 -0400 (EDT) Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Aug 2013 19:37:32 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 801DD2BB0053 for ; Wed, 21 Aug 2013 19:54:26 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7L9cT0s2883900 for ; Wed, 21 Aug 2013 19:38:29 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7L9sPlV028316 for ; Wed, 21 Aug 2013 19:54:26 +1000 From: "Aneesh Kumar K.V" Subject: Re: [PATCH v2 06/20] mm, hugetlb: return a reserved page to a reserved pool if failed In-Reply-To: <1376040398-11212-7-git-send-email-iamjoonsoo.kim@lge.com> References: <1376040398-11212-1-git-send-email-iamjoonsoo.kim@lge.com> <1376040398-11212-7-git-send-email-iamjoonsoo.kim@lge.com> Date: Wed, 21 Aug 2013 15:24:13 +0530 Message-ID: <87mwobgyii.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim , Andrew Morton Cc: Rik van Riel , Mel Gorman , Michal Hocko , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton Joonsoo Kim writes: > If we fail with a reserved page, just calling put_page() is not sufficient, > because put_page() invoke free_huge_page() at last step and it doesn't > know whether a page comes from a reserved pool or not. So it doesn't do > anything related to reserved count. This makes reserve count lower > than how we need, because reserve count already decrease in > dequeue_huge_page_vma(). This patch fix this situation. You may want to document you are using PagePrivate for tracking reservation and why it is ok to that. > > Signed-off-by: Joonsoo Kim > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6c8eec2..3f834f1 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -572,6 +572,7 @@ retry_cpuset: > if (!vma_has_reserves(vma, chg)) > break; > > + SetPagePrivate(page); > h->resv_huge_pages--; > break; > } > @@ -626,15 +627,20 @@ static void free_huge_page(struct page *page) > int nid = page_to_nid(page); > struct hugepage_subpool *spool = > (struct hugepage_subpool *)page_private(page); > + bool restore_reserve; > > set_page_private(page, 0); > page->mapping = NULL; > BUG_ON(page_count(page)); > BUG_ON(page_mapcount(page)); > + restore_reserve = PagePrivate(page); > > spin_lock(&hugetlb_lock); > hugetlb_cgroup_uncharge_page(hstate_index(h), > pages_per_huge_page(h), page); > + if (restore_reserve) > + h->resv_huge_pages++; > + > if (h->surplus_huge_pages_node[nid] && huge_page_order(h) < MAX_ORDER) { > /* remove the page from active list */ > list_del(&page->lru); > @@ -2616,6 +2622,8 @@ retry_avoidcopy: > spin_lock(&mm->page_table_lock); > ptep = huge_pte_offset(mm, address & huge_page_mask(h)); > if (likely(pte_same(huge_ptep_get(ptep), pte))) { > + ClearPagePrivate(new_page); > + > /* Break COW */ > huge_ptep_clear_flush(vma, address, ptep); > set_huge_pte_at(mm, address, ptep, > @@ -2727,6 +2735,7 @@ retry: > goto retry; > goto out; > } > + ClearPagePrivate(page); > > spin_lock(&inode->i_lock); > inode->i_blocks += blocks_per_huge_page(h); > @@ -2773,8 +2782,10 @@ retry: > if (!huge_pte_none(huge_ptep_get(ptep))) > goto backout; > > - if (anon_rmap) > + if (anon_rmap) { > + ClearPagePrivate(page); > hugepage_add_new_anon_rmap(page, vma, address); > + } > else > page_dup_rmap(page); > new_pte = make_huge_pte(vma, page, ((vma->vm_flags & VM_WRITE) > -- > 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org