From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29774C5321E for ; Mon, 26 Aug 2024 13:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6BDB6B007B; Mon, 26 Aug 2024 09:24:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F3FF6B0082; Mon, 26 Aug 2024 09:24:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8953A6B0083; Mon, 26 Aug 2024 09:24:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6757C6B007B for ; Mon, 26 Aug 2024 09:24:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1850916024C for ; Mon, 26 Aug 2024 13:24:58 +0000 (UTC) X-FDA: 82494467076.24.19AAF62 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 1C02140008 for ; Mon, 26 Aug 2024 13:24:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=zp1vNc4D; dkim=pass header.d=linutronix.de header.s=2020e header.b=MVBUGdIS; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf07.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724678627; a=rsa-sha256; cv=none; b=v6AiOTZSehELP3/XTt+TvS59E+G20bK/gs5sFj4yVqv0DBf7GX715KCr+SWgzyt62HZ9Xo bZe/G3UDdIz/i+tDJ6cmn60e7RdYDrPbC+/wtGAOIukgdK6AAYoUgA6oiRwtPOYY1FSsvZ i678sne1SatktanuSesFzDz6AtRs21g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=zp1vNc4D; dkim=pass header.d=linutronix.de header.s=2020e header.b=MVBUGdIS; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf07.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724678627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JtERtJKi/CA36m/GEM8qvROm+v91KuIncw1OX4BkHbo=; b=J2XlSrIxuxPJgbFM1sqb/9lkhMohrEYpaHO3Mm7zA+izW9nAXUCPPx6SuptiJ1tZ0IZTYV qpn8BYexYYCeLW7u4WKE0I+mitcu5LlXCQ5WMW6g6G/K26tOsfkLyqa66xeNdS4U1QPMHA 8KEPb749rrr2weos9VDK+QEU31bCUp4= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1724678693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JtERtJKi/CA36m/GEM8qvROm+v91KuIncw1OX4BkHbo=; b=zp1vNc4DuEN5YGFJn0TnAQLg0tqSuVcJT1LF7fJXWGjIq9boLoE67t0jweEecdUb7sF4GH GCQYB9HU/g83IdP8iePIB0ST+nfgjNktYKMIjUz3LlV/WiJcdqrTixPcGf8q5uk9fA4AJk w6fD2O1Yn3O5X0dRndrBmcvUrBU9IQbcMRg2frAPJ2wSc4l2YQ1FFd73rJq1/y6Vj/xxgH 0esO02GAS3JjVqcgZix9NqNsLH/qRLm4AhSWJl3hwYmpMbN4YgqIT9Dr7UFLXgC7zxx7qp lBn8E0DLeyhkRVJ4UXNT+sBw3oZUwmdUgkhGWPGAQ6TSpslNcaibuIH3xKyBgw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1724678693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JtERtJKi/CA36m/GEM8qvROm+v91KuIncw1OX4BkHbo=; b=MVBUGdIS3uO0WmN8EGfXIZc+hb2K87xkQVti0VUBQTGVjM7a9DhmIGZGaQAw3NK+w8pyab 59i8js1pWL3G7UAg== To: Christophe Leroy , "Jason A. Donenfeld" Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom In-Reply-To: <51adbe91-3c3a-4baa-bb39-29df98a6eea5@csgroup.eu> References: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> <7e519ba2-0293-4320-84bf-44f930fc286d@csgroup.eu> <51adbe91-3c3a-4baa-bb39-29df98a6eea5@csgroup.eu> Date: Mon, 26 Aug 2024 15:24:52 +0200 Message-ID: <87plpvct7f.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1C02140008 X-Stat-Signature: 6az8ec3g3foupbao6516ojhdomhnby8u X-Rspam-User: X-HE-Tag: 1724678695-144054 X-HE-Meta: U2FsdGVkX1+NUzgMvXV8TlnzOtuUSGBVr10VE/4VvsQZnNmZIfgcV8rXni1zMoqAnnjtVOUxXdWb/K2BGALSJcLGxLNGH07f28PuNjSTKpd3oGKk1bV9axiUYnsG+4Rg3XYWR1XygBPEJ2cfARHauN1bHLF/XSC6tzow1jfo1EUmUx+VCgfYtmSxobw0oDpej/OFPIhGHS55X+UnkGiEtDNctg2ECKuQrxG/cNO67LT8k0kYcmvIz/EwrIjS4sHSan+k67PtDoHbopde0yK1geC3YSAYXdih/S9Orh0EVSVaLduXuxWWklfugixF9XCOp/SSUSaNvLIlf/sEiHkArRgGSm+dSk8GP3kYqnQ1BiQk4m9eYxmNftedg8jJeODtEX9PFqpyO2CAwL9vECvVOaHNfTvhMgwXn0XVxvFgaOU7CCcZZWm73sF0riPIMKsxgtyD5IFoh7f260WSSjcukBno7ivIA8G8r3GXyIiW6bN9dGn/3vq2PL9d9VhcbyyR5CqVBEQnxHC/BhaOPh6x1+y1M+w494wy67J1D0mrOCDV3VneLKyR/XRd3PDcAXVamzOz44/f3YKtDnJZsbTZd+RdvG+2qKY8mh1mHb0DOksrcLaHO7Y1LpvToIDrSiinPXGwOJ/vQTjx4gg/b36rsbzzfpzknSFE5KqO8iea3uqDMFhl0bp0s718T6iVWZKey0E436encHViPX9XiMHenX6GsSvWC8PUX/v2v5LxQkeY1iYvQMBgbpFOtYuaMd/xejKFoe4nfoJqJsLXXk7YntRBbByoRUid6xghQIaWpl5vYFen3S2qpv3AVK6KJPS7j24TY8/4/HO77RSrniyh8ZruKoeOSKE6WXVGKmhy23Nfal2XTxFmxLJ87eWCuLnbZXc5hk1v/IyEaWNo+YS7vGakMtnrhr54vr0R1J6rcUzupz2yXzRsSI7kHIm0S50LSRb7ou32i9Ug5CO2qsY oYQlhavj I2RhEaPsHnxe3l892gGPassUIUJoFMYD9byc4rcWC/4dlzp4fxsWuBFjnWz6Qdn9RysTCA+80obFKl6WAZP7b/iZizGvIcXE/UU0uNrAHTPWq85SYtZ8FJFOFzcFjqW3X2ubsvMVm2CqKD6z+aut29BeSd9jXhr608dS+TExU6/vaJGVtUvTTIbEx9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26 2024 at 12:45, Christophe Leroy wrote: > Le 26/08/2024 =C3=A0 10:58, Jason A. Donenfeld a =C3=A9crit=C2=A0: >> On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: >>> >>> >>> Le 26/08/2024 =C3=A0 10:07, Jason A. Donenfeld a =C3=A9crit=C2=A0: >>>> On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: >>>>>=20=20=20=20 >>>>> +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) >>>>> +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) >>>> >>>> If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SI= ZE >>>> instead of _PAGE_SIZE? But if that's the case, why not put the vdso >>>> definition of PAGE_SIZE into some vdso header included by this file? >>> >>> It was working ok on powerpc but on x86 I got: >>=20 >> Seems like there might be some more fiddling to do, then? Or did you >> conclude it's impossible? > > Maybe someone who knows x86 in details could helps but after a first=20 > look I gave up because it looks very x86 specific, indeed that's=20 > x86/asm/vdso/gettimeofday.h that pulls several x86/asm/ headers , and=20 > the same type of issue might arise for any new architecture coming in. Of course :) > For me it looked cleaner to just do as commit cffaefd15a8f ("vdso: Use=20 > CONFIG_PAGE_SHIFT in vdso/datapage.h") and not use PAGE_SIZE at all. But= =20 > I didn't want to directly use (1UL << CONFIG_PAGE_SHIFT) and (~(1UL <<=20 > (CONFIG_PAGE_SHIFT - 1))) in the code directly hence the new macros with= =20 > a leading underscore to avoid any conflict with existing macros. #ifndef PAGE_SIZE # define #endif Perhaps? Thanks, tglx