From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A981C433ED for ; Mon, 17 May 2021 13:56:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F079611BF for ; Mon, 17 May 2021 13:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F079611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 172F26B0036; Mon, 17 May 2021 09:56:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1229E6B006E; Mon, 17 May 2021 09:56:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8FCE6B0070; Mon, 17 May 2021 09:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id B37306B0036 for ; Mon, 17 May 2021 09:56:07 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 557D71803671E for ; Mon, 17 May 2021 13:56:07 +0000 (UTC) X-FDA: 78150871974.33.D945303 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf01.hostedemail.com (Postfix) with ESMTP id 9F0C2500152D for ; Mon, 17 May 2021 13:56:04 +0000 (UTC) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14HDWvgp032222; Mon, 17 May 2021 09:55:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Us9UKM1phQm8WG0lDFhJ4ywiIounM6yTagUbweo+Yz0=; b=mXPHfhSRW7asfKCJTIohzx1mPjAhng1Ti8CIbkvFKLmQDeC/LpGxn9JcKSc3m5wlT5oL 0jUHiDNVW496/gv24QfH+bGftI3SVi9QGAEVrf/5zC4E86aEpHC4kldAP3HA9sSleDRy 391dS9UAOCoRID3nhwzKi/qxTe0EOXZF95o3YKr4rTM83dLB1ihjvtfqE+EK1lGet+/d sptpsGCsbAdil8DscFyFdn+CapWGAtYMT13FY4o2zIca4ygPOpgPfti/poyfpL4qyZe6 XlHII5YLo8/FKYVMig9frXIgbYKrn5HOIhTDxS3pJdymyY4KAY3YkFzQWLJIQDAVZxVa qA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 38krxj1wxu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 May 2021 09:55:54 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 14HDXbwm034065; Mon, 17 May 2021 09:55:54 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 38krxj1wxp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 May 2021 09:55:54 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 14HDqWFM014822; Mon, 17 May 2021 13:55:53 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04dal.us.ibm.com with ESMTP id 38j5x9kd2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 May 2021 13:55:53 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14HDtqDO32375066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 May 2021 13:55:52 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38A92BE079; Mon, 17 May 2021 13:55:52 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B7FF2BE069; Mon, 17 May 2021 13:55:48 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.199.40.240]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 17 May 2021 13:55:48 +0000 (GMT) X-Mailer: emacs 28.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Guenter Roeck Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy Subject: Re: [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument In-Reply-To: References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-6-aneesh.kumar@linux.ibm.com> <20210515163525.GA1106462@roeck-us.net> Date: Mon, 17 May 2021 19:25:46 +0530 Message-ID: <87pmxpqxb1.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: AAIc0caZr1voZgopm7zPOn0y3KoI9oAF X-Proofpoint-GUID: 28_3rmCyY6EIbEGvsKbm1T0JpgCp8-3M Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-17_05:2021-05-17,2021-05-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 clxscore=1015 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105170096 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mXPHfhSR; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf01.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9F0C2500152D X-Stat-Signature: 5k553trxqr3q553fz4b8teh1aehhbnnc X-HE-Tag: 1621259764-191953 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Guenter Roeck writes: > On 5/17/21 1:40 AM, Aneesh Kumar K.V wrote: >> On 5/15/21 10:05 PM, Guenter Roeck wrote: >>> On Thu, Apr 22, 2021 at 11:13:19AM +0530, Aneesh Kumar K.V wrote: ... >>> =C2=A0 extern void radix__local_flush_all_mm(struct mm_struct *mm); >>>> diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush.h b/arch/powe= rpc/include/asm/book3s/64/tlbflush.h >>>> index 215973b4cb26..f9f8a3a264f7 100644 >>>> --- a/arch/powerpc/include/asm/book3s/64/tlbflush.h >>>> +++ b/arch/powerpc/include/asm/book3s/64/tlbflush.h >>>> @@ -45,13 +45,30 @@ static inline void tlbiel_all_lpid(bool radix) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hash__tlbiel_al= l(TLB_INVAL_SCOPE_LPID); >>>> =C2=A0 } >>>> +static inline void flush_pmd_tlb_pwc_range(struct vm_area_struct *vma, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned lo= ng start, >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned lo= ng end, >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool flush_= pwc) >>>> +{ >>>> +=C2=A0=C2=A0=C2=A0 if (radix_enabled()) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return radix__flush_pmd_tl= b_range(vma, start, end, flush_pwc); >>>> +=C2=A0=C2=A0=C2=A0 return hash__flush_tlb_range(vma, start, end); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^^^^^^^^^^^^^^= ^^^^^^^^^^^^^^^^^^^^^^^^ >>> >>>> +} >>=20 >> In this specific case we won't have=C2=A0 build errors because, >>=20 >> static inline void hash__flush_tlb_range(struct vm_area_struct *vma, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long start, un= signed long end) >> { >>=20 > > Sorry, you completely lost me. > > Building parisc:allnoconfig ... failed > -------------- > Error log: > In file included from arch/parisc/include/asm/cacheflush.h:7, > from include/linux/highmem.h:12, > from include/linux/pagemap.h:11, > from include/linux/ksm.h:13, > from mm/mremap.c:14: > mm/mremap.c: In function 'flush_pte_tlb_pwc_range': > arch/parisc/include/asm/tlbflush.h:20:2: error: 'return' with a value, in= function returning void As replied here https://lore.kernel.org/mm-commits/8eedb441-a612-1ec8-8bf7-b40184de9f6f@lin= ux.ibm.com/ That was the generic header change in the patch. I was commenting about the ppc64 specific change causing build failures. -aneesh