Re: [PATCH v2 1/6] fs/readdir: Fix filldir() and filldir64() use of user_access_begin()

Linus Torvalds
2020-01-22T18:24:52Z

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

[ Sorry about HTML crud, on mobile right now ]

On Wed, Jan 22, 2020, 09:52 Christophe Leroy <christophe.leroy@c-s.fr>
wrote:

>
> - struct linux_dirent __user * dirent;
> + struct linux_dirent __user * dirent, *dirent0;

Patch looks better, but those names are horrid.

Please just use "prev" for the previous dirent, and leave the current one
as "dirent".

I think that's going to be a lot more legible. But no numbering.

Linus

[-- Attachment #2: Type: text/html, Size: 952 bytes --]