Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page()

Huang, Ying
2024-12-01T05:38:01Z

Hi, Andrew,

Andrew Morton <akpm@linux-foundation.org> writes:

> On Thu, 31 Oct 2024 16:39:53 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
>
>> However, on ARM64, it does introduce some regression for clearing pages
>> from end to start. That needs to be addressed. I guess that the
>> regression can be resolved via using more clearing from start to end
>> (but not all). For example, can you take a look at the patch below?
>> Which uses the similar framework as before, but clear each small trunk
>> (mpage) from start to end. You can adjust MPAGE_NRPAGES to check when
>> the regression can be restored.
>>
>> WARNING: the patch is only build tested.
>
> I'm holding this patch in mm-unstable because it's unclear (to me) that
> this regression has been adequately addressed?

Yes. This patch isn't ready to be merged yet. More works are needed to
root cause the problem and implement the proper fix. I guess that
Kefeng will continue to work on this.

---
Best Regards,
Huang, Ying