Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page()

Andrew Morton
2024-12-06T01:47:09Z

On Mon, 2 Dec 2024 09:03:45 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> >>> WARNING: the patch is only build tested.
> >>
> >> I'm holding this patch in mm-unstable because it's unclear (to me) that
> >> this regression has been adequately addressed?
> >
> > Yes. This patch isn't ready to be merged yet. More works are needed to
> > root cause the problem and implement the proper fix. I guess that
> > Kefeng will continue to work on this.
>
> Sorry for the late, I've been buried in other tasks.
>
> The two bugfix patches in the next should be merged firstly, which is
> not related about the performance issue.
>
> 84ddd1450383 mm: use aligned address in copy_user_gigantic_page()
> 9fbd869b19b8 mm: use aligned address in clear_gigantic_page()
>
>
> and according to the suggestion of Ying, I am trying to fix the
> performance issue on arm64(will in new series), but I need to check no
> regression on other arm64's machine, will send the new patches once
> the test is complete.
>
> So Andrew, please help to pick up the above two bugfix patches to
> v6.13-rcX if no objection.

I added cc:stable to both and moved them into mm-hotfixes-unstable,
targeting an upstream merge next week.

"mm: use aligned address in clear_gigantic_page()":
https://lkml.kernel.org/r/20241028145656.932941-1-wangkefeng.wang@huawei.com

"mm: use aligned address in copy_user_gigantic_page()":