From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3AEC4332F for ; Mon, 6 Nov 2023 06:07:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 740146B01A0; Mon, 6 Nov 2023 01:07:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EFD66B01A1; Mon, 6 Nov 2023 01:07:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DFA36B01A2; Mon, 6 Nov 2023 01:07:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B6F56B01A0 for ; Mon, 6 Nov 2023 01:07:02 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 160161603C7 for ; Mon, 6 Nov 2023 06:07:02 +0000 (UTC) X-FDA: 81426496284.28.038BE4B Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf25.hostedemail.com (Postfix) with ESMTP id E0343A0014 for ; Mon, 6 Nov 2023 06:06:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=blvpfEmG; dmarc=none; spf=pass (imf25.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699250820; a=rsa-sha256; cv=none; b=GPHpRRanFcspCvpeeZ5UdOZRErXGQPqEWWZC4STy30t9u32aW30LKSfFD9vHH4ZmhlBTV2 PZFDiljswU/27gCqm7LDJmAgqa1muZ4ozxQA2t2Y5zAg7ZOcZJ2UsktvLuueP+quPP04bi O9BHcg4Hy9a3omgGRgVWisGn6Ef5noc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=blvpfEmG; dmarc=none; spf=pass (imf25.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699250820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gv51mywp9ecOX1RzxcZintnhCsjrqp3x4ZC5Y3ZTTNk=; b=B0ru7cRBvmez8V0bFfTIBVrUhc/fLhx906gomgyiN+7GI052U6xU9/wYwwU/IZYpIdRnBT DP8HJ0tre2t0JqlN2ZUwv+IxOU0W7pXRvl2sSiMohELT1rWKLfMETdSYLweJt2cIbM+BWk QODZBIel8n32qlQhAEDU5iSZN4SPpEo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1699250815; bh=gv51mywp9ecOX1RzxcZintnhCsjrqp3x4ZC5Y3ZTTNk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=blvpfEmGE+F3r0Fuw6ybL9XiF7bRdCdhL0xCmScANvLLocPL5eJpTsbOysaUJychF 9EVAypYfGN5Jpnw6/bjQzpz1yuCnsIyx6XqfLeFhc3LrdL9N/13gadKies37NVe4Al uDtIAebgpKKAdDyR2iFoRS81YIlEagqJsBD2ZK37QryXxjmaxT7Dn42mP+0wohL7pj /1M1OoP8ZgitJbhdYR86vIpvWyWq0GyaIJ/3ra1rsw5pvN2eKIi8i7H1gDsAhMk8JR 6RqMDqBcz7czNexkVLMY4E3vrCZVXe055JmCuKUjOfcgrtYCC+0NvxT9tylfoqE3yw MJbvWOb49lHYA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SP18B6F9xz4wd0; Mon, 6 Nov 2023 17:06:50 +1100 (AEDT) From: Michael Ellerman To: Anshuman Khandual , "Daniel Walker (danielwa)" , Christophe Leroy , "Aneesh Kumar K . V" , david@redhat.com Cc: "David Beazley (dbeazley)" , "xe-linux-external(mailer list)" , "linux-mm@kvack.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: mm/debug_vm_pgtable.c:860 warning triggered In-Reply-To: References: Date: Mon, 06 Nov 2023 17:06:46 +1100 Message-ID: <87sf5jqutl.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E0343A0014 X-Stat-Signature: zgy7f4fcoktdi8mi1hs78w8oiznuz8eg X-HE-Tag: 1699250819-478569 X-HE-Meta: U2FsdGVkX1/ZgojFwHfc1D/W1bRFcng7kAUi3y8iaQMqrapuZ3+V7UMvZpJcplCMGmOfvxDkhCWrmy6CbYJ4Q+OVHmAbn6rVN+0/TJv72RHCKV9+uolz3J4IfnUGeBV1x2foanx9QP4XZZ88GLhEk35JOxM/WVMTRLG7cDJjWhS1jS+h4EDf0IKI4+cHpiqewlJWjSpU6GL3XRSoGv83CJHeFmdVQsr+LukVTdPM0GYAfmODrSY9abQ04PMSZxhx1FUA5cBvSV3stBQK+2BLEdxnXZcGlX6Ud12cuQ6YA26aikjrmerNTCE8xl23PHBlFmYaW2iBQ5HCayBxdK+0P1nAQbCIvAcd3+n+Undq0qmWZjdFswack7DKRGtvi6b55Z7PsABnhHeZiTAb6Pd5mhD0HGFUetiCUeqm9/JSoHH8FSHJ4tPXmjvmvomSEhMul7W9Xzhak7o9X7KGQww0b+byUYcmKj49gnFf5OkSvcXqqYDNpH4Jbp3bXcKF1ZFu+uh3gHbRhC6btCFzLzVi3iMZh/DhYRt8/vzMWrR7AchY05ItaRKAkjglOFO5vfZsjLdRglGMLJtCtiXPGYYGlFwE7sQ7zbFmYfVGz05qARiidB+aidrbkN0LTwfBq3U4VnryqejFer2h4qT9gULezNsOINj2KTmFs2WBapbJpyHiRLt7T743HTGTmva9ofht1Bv8sPMZRppDtxv8dblBu4bEHmJ510Kvg+rOs8azXMBesvyZAPW80pA+EqYGD/pbeMgG7UwalHJ2hHK3AIqUAlzBsuMZo9j4WPiZfrf4CUEWLh3+fpwv4eYKOJLu/VEPZIVrAxbSgTMsTv1/P7ckJc1uYkAG+QgS55F2Ap1RIpgr9aEGaMEm2XvEXQVlyVoHm6jNtM7pq3lIWxBmDmulGM1WVdGv4g5vAa2rjzwQMgBscM6fPRf/OOrGNbSknfbxSmPSC6RcG+VbNQduF01 VXeICjcT gJ4fWHIPSET1TV+yYr5NiyboCypPlmTCqi1mQw7FYhQmkoagStjml0hv31tNJXmrDQw8pDEo+c4z0A97QRf4o9j4zwH2Z4GkJV+YChYduj9ZT/riuNhZouiwe1HkeWrfogSYArTtMz3pGUI74CWcv/rOdIwN19YHJh65HEibAuvV1Qr+Wljzaux7EQQZ0jtHUKCn/DkQltL5wXRl+LG+JU/rJMQHDJ+JGNCIL+hwBLTLrkQs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Anshuman Khandual writes: > Hello Daniel, > > This test just ensures that PFN is preserved during pte <--> swap pte transformations > , and the warning here seems to have been caused by powerpc platform specific helpers > and/or its pte_t representation. Adding powerpc folks and platform mailing list here. Doesn't the test need a similar treatment to: 2321ba3e3733 ("mm/debug_vm_pgtable: more pte_swp_exclusive() sanity checks") Which said: Especially, the pfn_pte() is dodgy when the swap PTE layout differs heavily from ordinary PTEs. Let's properly construct a swap PTE from swap type+offset. cheers