From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Khazhismel Kumykov <khazhy@google.com>,
Linux MM <linux-mm@kvack.org>,
kernel@collabora.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 2/3] shmem: Introduce /sys/fs/tmpfs support
Date: Wed, 23 Mar 2022 14:04:21 -0400 [thread overview]
Message-ID: <87sfr8r1ei.fsf@collabora.com> (raw)
In-Reply-To: <CAOQ4uxhLQp4ujuR8k16k9EfeOC2TiwwiCeVGYOzpViwRpa5oqw@mail.gmail.com> (Amir Goldstein's message of "Wed, 23 Mar 2022 01:58:07 +0200")
Amir Goldstein <amir73il@gmail.com> writes:
>> +static int shmem_register_sysfs(struct super_block *sb)
>> +{
>> + int err;
>> + struct shmem_sb_info *sbinfo = SHMEM_SB(sb);
>> + __kernel_fsid_t fsid = uuid_to_fsid(sb->s_uuid.b);
>> +
>> + init_completion(&sbinfo->s_kobj_unregister);
>> + err = kobject_init_and_add(&sbinfo->s_kobj, &tmpfs_sb_ktype, shmem_root,
>> + "%x%x", fsid.val[0], fsid.val[1]);
>
> uuid (and fsid) try to be unique across tmpfs instances from different times.
> You don't need that.
> I think you'd rather use s_dev (minor number) which is unique among all tmpfs
> instances at a given time and also much easier from user scripts to read from
> (e.g. stat or /proc/self/mountinfo).
>
> That's btw the same number is used as an entry in /sys/fs/fuse/connections
> (fusectl pseudo fs).
Hi Amir, thanks for the review.
Sounds good. I will follow up with a new version that uses
MINOR(sb->s_dev).
Thank you,
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2022-03-23 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 22:27 [PATCH 0/3] shmem: Allow userspace monitoring of tmpfs for lack of space Gabriel Krisman Bertazi
2022-03-22 22:27 ` [PATCH 1/3] shmem: Keep track of out-of-memory and out-of-space errors Gabriel Krisman Bertazi
2022-03-22 22:27 ` [PATCH 2/3] shmem: Introduce /sys/fs/tmpfs support Gabriel Krisman Bertazi
2022-03-22 23:58 ` Amir Goldstein
2022-03-23 18:04 ` Gabriel Krisman Bertazi [this message]
2022-03-22 22:27 ` [PATCH 3/3] shmem: Expose space and accounting error count Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfr8r1ei.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=hughd@google.com \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).