linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Huang\, Ying" <ying.huang@intel.com>
To: Michal Hocko <mhocko@kernel.org>, Minchan Kim <minchan@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Tim Chen <tim.c.chen@intel.com>,
	Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Date: Wed, 27 Sep 2017 09:36:39 +0800	[thread overview]
Message-ID: <87shf8c47s.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <20170926132129.dbtr2mof35x4j4og@dhcp22.suse.cz> (Michal Hocko's message of "Tue, 26 Sep 2017 15:21:29 +0200")

Michal Hocko <mhocko@kernel.org> writes:

> On Thu 21-09-17 09:33:10, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@intel.com>
>> 
>> This patch adds a new Kconfig option VMA_SWAP_READAHEAD and wraps VMA
>> based swap readahead code inside #ifdef CONFIG_VMA_SWAP_READAHEAD/#endif.
>> This is more friendly for tiny kernels.
>
> How (much)?

OK.  I will measure it.

>> And as pointed to by Minchan
>> Kim, give people who want to disable the swap readahead an opportunity
>> to notice the changes to the swap readahead algorithm and the
>> corresponding knobs.
>
> Why would anyone want that?
>
> Please note that adding new config options make the already complicated
> config space even more problematic so there should be a good reason to
> add one. Please make sure your justification is clear on why this is
> worth the future maintenance and configurability burden.

Hi, Minchan,

Could you give more information on this?

Best Regards,
Huang, Ying

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-09-27  1:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21  1:33 [PATCH] mm, swap: Make VMA based swap readahead configurable Huang, Ying
2017-09-25  5:41 ` Minchan Kim
2017-09-25  5:54   ` Huang, Ying
2017-09-25  6:17     ` Minchan Kim
2017-09-25  6:24       ` Huang, Ying
2017-09-25  6:30         ` Minchan Kim
2017-09-26 13:21 ` Michal Hocko
2017-09-27  1:36   ` Huang, Ying [this message]
2017-09-27  5:04   ` Minchan Kim
2017-09-27  7:48     ` Michal Hocko
2017-09-27  8:04       ` Minchan Kim
2017-09-27  8:35         ` Michal Hocko
2017-09-27 13:15           ` Minchan Kim
2017-09-27 13:22             ` Michal Hocko
2017-09-27 13:41               ` Minchan Kim
2017-09-27 13:50                 ` Michal Hocko
2017-09-27 14:10                   ` Minchan Kim
2017-09-27 14:17                     ` Michal Hocko
2017-09-28  1:02                       ` Huang, Ying
2017-10-02  7:23                         ` Michal Hocko
2017-10-02 15:45                         ` Dave Hansen
2017-10-02 21:49                           ` Andrew Morton
2017-10-06 12:28                             ` huang ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shf8c47s.fsf@yhuang-dev.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=shli@kernel.org \
    --cc=tim.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).