From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2CDC36010 for ; Fri, 4 Apr 2025 09:53:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF30A6B0005; Fri, 4 Apr 2025 05:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7C946B0006; Fri, 4 Apr 2025 05:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCCC76B0007; Fri, 4 Apr 2025 05:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC8EC6B0005 for ; Fri, 4 Apr 2025 05:53:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 72BF31C80CB for ; Fri, 4 Apr 2025 09:53:37 +0000 (UTC) X-FDA: 83295899274.17.33C6C91 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 28407180003 for ; Fri, 4 Apr 2025 09:53:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OHtDeaV0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743760415; a=rsa-sha256; cv=none; b=C2tLR6pEaCYOLNvSSS4jwss1IsHvbsjdUZ0NeQ43NKYhAJGd6Sfv61H/hX7TJjF1hAzWZD ErBYpA85T9ZDaoxuUie4iq4mjkXDdTdcU8G+FJUm+i0slv/zeo2lMaRv3ghmtPrTI9Q0L+ AKFC7AAtedjcvFDr5IKrZbRRdXZhrP0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OHtDeaV0; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743760415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HdWSNGczK/oHOsUXrvCtXljE3LTIKWDRZhedIIJJVgc=; b=HY5ekrZCNtfdsr2st3dLjy+tRL8O8vgCZNSFvr/8y3m77N1kks5OxVxBV3BbuXJQ2kHW0l M/YmNYuAvVDxL+Z+UfOZs3zV9ZcoEZC9QoSc2wrnFD/gpp7ouMT9BKrAGgG6x7W6L+F7Z+ 4LJaR7jtN2YJkl6EIZobUd62dKYeTfc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743760414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HdWSNGczK/oHOsUXrvCtXljE3LTIKWDRZhedIIJJVgc=; b=OHtDeaV0SR4k/NNVepxTQRXXWsfk6UgysEai2tKrTTChOa/bPP11TVs+mMyNJ5CajgwNdX 7wnkHA/hYlQlHUeKP/aPCvHObsCz1kpy6p+t344OdLN8NjK39ht2ICOaIXE4ifp/zoygPI /uga6KsSOuzdJDt59W5Yntc+M/Se3bk= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-WsvG5kPrOyqV1lYINKr-UQ-1; Fri, 04 Apr 2025 05:53:30 -0400 X-MC-Unique: WsvG5kPrOyqV1lYINKr-UQ-1 X-Mimecast-MFC-AGG-ID: WsvG5kPrOyqV1lYINKr-UQ_1743760409 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ac3df3f1193so146900866b.2 for ; Fri, 04 Apr 2025 02:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743760409; x=1744365209; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LVGQCiVyZHkGXnn98AxsiJpRPwaHkCR4E26XV5UfwnI=; b=hvWtuSJV84LoC3Tl1g4wBb2bK08szcvsW/gVoxO5GXAcUkq1jswe6Lk/ZNRo67ckSq WN/ei42HWPAPVvbo9V2LRRDqQtUz0p4jxeI7xatsshuUxqdSt4OdhDSvS8a8xTLy5iXV dw749tbOKAV8sQh4plN7p1AZqo1SOzj5w9iw5jPiM5ZUcnKDLfEAhyKKo/8xff9PZPlA nnRnW37Xz7ryMIz///aBgyNNJNR/T17RwJgtXhKVk6ymeSkkymZZ8Q2KKFIm0Q8/2hbf ZbfokICtTE9cLFy/7tpLLebrqZ/m5Bm0TWvh7PowLjPDMJdUEg4LIv6UAywZUcT2iMqX w7YQ== X-Forwarded-Encrypted: i=1; AJvYcCUk0rU2jWhLGLCd2REiBtsvAPFzOedxlgMRq6IHK/9UGsGOlBBsQiyZtL0kiJWE9ng6k43bXgCA1A==@kvack.org X-Gm-Message-State: AOJu0Ywi1EyvM38PDwYqDS2jbeRbuH8nzrcNx0ddB9T0Gl9ZU09jrzC4 ee4geM6rweXo6G/ilcbpZzMIBH8hAl70k8kRYv9ygBL/lqal0rFZ+fhUFzuuKEjmlgbNRHBhAF7 AwTDEODG3M0g05zyZSA8BruUroh6EArqRBMkW4ft7n09ZZzIF X-Gm-Gg: ASbGncsriqLaaorvUf84zQOtSi5iMkB6DPmTBVqg51j0aA42+iyoFVhi0e6Hbtrh534 GpFi2CtDiPDupaggg6lfjIh0evCQFgsyXyfephYIgC9aa1OWr02zSnc4Plbyqgu/9zeY1Oua+Cw 3DebU3eiRXXuB9/xC/TJv2gSfdvKJIWH4K4osbMgdlT/XJhqZ3JXMuBTpMrCnjU1rckfUDyeBA3 DHB8zc/bDa/OQSvuecGOK3cBmGHqyG1cozNnROVubY/HxLiI0pa6K5gN0JPh1s8zxpfJqMomQGG vLbfWJAiNwh3e0xxL4+cM3bFGj+CG9eytA8HoCOy X-Received: by 2002:a17:907:2da1:b0:abf:6db5:c9a9 with SMTP id a640c23a62f3a-ac7d6e07489mr142802766b.39.1743760409208; Fri, 04 Apr 2025 02:53:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1XTUa7Ek2WhdvH5WJS2AIV0agLDZZ/Z+JEVHEXzqYzD3Mqsj3alR3nhhtT2rdlTKU/t/FhQ== X-Received: by 2002:a17:907:2da1:b0:abf:6db5:c9a9 with SMTP id a640c23a62f3a-ac7d6e07489mr142800266b.39.1743760408780; Fri, 04 Apr 2025 02:53:28 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c0185726sm224898366b.137.2025.04.04.02.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 02:53:28 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id C858818FD70F; Fri, 04 Apr 2025 11:53:26 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next v6 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool In-Reply-To: <20250403153129.013a7bdd@kernel.org> References: <20250401-page-pool-track-dma-v6-0-8b83474870d4@redhat.com> <20250401-page-pool-track-dma-v6-2-8b83474870d4@redhat.com> <20250403153129.013a7bdd@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 04 Apr 2025 11:53:26 +0200 Message-ID: <87tt74l0bt.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UufzmpnvvwXCHWcCLPiEIhT_pXzlildKpuuZ6GOCevQ_1743760409 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 28407180003 X-Stat-Signature: zefrngs9p667f1ymz1cgm53o7h7pxpz8 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743760414-19305 X-HE-Meta: U2FsdGVkX19f33CgRZdRkXgZNAwNMsdq0SMjHG7IDgllJSVTvDErqpRm0sD2nIYxlUJqCzmQ0eShk0Wa5FMK6PYUq3MxctKswvvz9BnNWH1eU046eaG396potEng8+dTIzczfB3L/pyHEyNwkaDBoFDMpO0FPEylaDv4NWfdz3WioUBQpuPQHwoWbKQnLdg/82wUhbU8ARB1OibpBKZBPSMThPUmpbVBkQ9s21wsAX0CtthQHaaZv5It0Ypp6l+HW/A+kFRhYxJZgCVhAjyna49rPgY0OZkuSMpUniKo69GoNVbCoax39Lh45yoQg7vA3CyK7iXoJfl6SdLEtdYIwAmus4pl/bAkplelqMTWwIUHNUt6ZAEvmSGeUUG6as3NifjU4vvW6hY/h0SDotS1mLp2ObdgT31p07Z/0lKNNZY2Yz1f7oEs+goD2e3V2cqfaUk23uU0m6UVdHq4Jc2SHsxbxOQSFovTWtykpjSvVrjiDJI+KZpZoR02rKmEGNQC5AJe1kl/EiFdABIeekAWlYw7+khAuE8tkwsyeDYHlTY5A6Ff5HoNc77JxUP3sLHyiRxx+fEuCGMh7HDBCojLSE7uDS8NaSk6gthWYiSU63+gLvHE3HhEYZK0jAxAD8kcraqvWK00llXXGsx7W7w3lalF+UBtc5vdx2u8vY7Cukv2z7IfVbYYm0F4Pi6iKlyKy5Z0yHbP1Qqy7ejpZMBICwJS5AYir9o3QZMXXsGLrMHXEf558ifemPfM6lw5Y8cj2aSk9M7c+ccE9GK3j79D219RVCes/WX3/013L0l9QVA8oUd1C84qF4mIP3LCN6gZbzsU5A7seO6qUvB0liAIwNUsSPkg2td91dzrVQckUS6IgqOIW/bJJbmDGMLP56gJGjLSXp0f2cLvVAE70gn0ciqi+Ng+5y5yQLcU4rXLrIUXqvIuxxTFNkXlBVHGFRwgcQf6vA5If8txx3Q5Kzp 7she1oOo gqHQApyoUuNhHOiadYjBfhCf5ihopxSYeIfCXzAe25CUDMRVlu7EcMSfKYt8ynUjLAmjdkYqyZAdprY2e0wmFi8RXNhgK4edRWBEs6B8rygGK2dIGcTDdoxpWvrdYmdkl9E6S+IZfbfdDDhCENanaFfBTuRpyRglZuXTaYQ0KbdaO+F1WlLXfPvaLJQhR3pRi0sY7Whk2p5SSDeGWDYIHONOBb6PlVrHwDih7t4aLdH16h1J7eWSAwNwiiFj/SuNBBQavQcZFJXbAZWdA9nMrMS7bZos+nEGbrwrXBApYqeTaRaXgLUyVtOO+bRr0BhutNyrvoNNyG0cqjaCpC9JAcmBxWbnm01oEkd2GkWx47JqtfbE103iaZES5+Vw9QteTtWpP4TVFWe5DsunoDs9gIhr25+R+zJspDPlMMol/jHA7hN5JBlt6EbEhd9PNXk59Wd45HAE/Y58iaN7mazP7h3jzk+G366QqX7eEqzCNgH2h/0sssmnPcCSszqQ/NzWdFNGZ6jN3xRjnmDU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jakub Kicinski writes: > On Tue, 01 Apr 2025 11:27:19 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >> +=09if (err) { >> +=09=09WARN_ONCE(1, "couldn't track DMA mapping, please report to netdev= @"); >> =09=09goto unmap_failed; > > FWIW I second Pavel's concern about the warning being too drastic. > I have the feeling Meta's fleet will hit this. > How about WARN_ONCE(err !=3D -ENOMEM, ... ? I presume you care mostly > about the array filling up so -EBUSY Ah yes, that's a good solution, will do! >> +=09} >> =20 >> +=09if (page_pool_set_dma_addr_netmem(netmem, dma)) { >> +=09=09WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); >> +=09=09goto unmap_failed; >> +=09} > > I think this is ever so slightly leaking the id, if it ever happens? Good catch! Will swap the order of the operations. -Toke