From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B36C61D9B for ; Wed, 22 Nov 2023 17:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 035086B061B; Wed, 22 Nov 2023 12:42:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFFE06B061C; Wed, 22 Nov 2023 12:42:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79C96B061D; Wed, 22 Nov 2023 12:42:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C33386B061B for ; Wed, 22 Nov 2023 12:42:54 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9957D14119F for ; Wed, 22 Nov 2023 17:42:54 +0000 (UTC) X-FDA: 81486310668.29.FCEF02E Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by imf28.hostedemail.com (Postfix) with ESMTP id 8074BC0012 for ; Wed, 22 Nov 2023 17:42:52 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b="yjVY1zX/"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=QB6J1++l; dmarc=none; spf=pass (imf28.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.19 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700674972; a=rsa-sha256; cv=none; b=MhiqfyXHAml9wVBPY8oKShse9VXc5h2DsD05LxfQSESrN3rJBLP9RRqRmcy8FbcYMHYlWA 4Y12INx5eVOwXjudkon8XBuHtK6uuNyTA5yMFm76lZewr5S64ryzRw3zqVpbyOC/34tDZW cc+pKlLOrKVfGMrSvNl8Aj2070njsPQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b="yjVY1zX/"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=QB6J1++l; dmarc=none; spf=pass (imf28.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.19 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700674972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4qGVKYT1B7qwrlgMwXg0Fed9QuLJAWFc+73xVSblvWc=; b=YwnuTadje2gTIzSIW9tmkAHx8JWirO/GGr+86oJzghFcVq5YIrgVHtGH6eQIAgv9LxqdbA ScGz3Z5BB0lAqS61b3d3Fsiu+IReoxuiPE5J4/na4oIipPMFMNmEtJtg8AOF/PeObThU4z iy2rEz5DwYqPnM1UPV69MPma495CNmo= Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A70CA3200AB8; Wed, 22 Nov 2023 12:42:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 22 Nov 2023 12:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1700674970; x=1700761370; bh=4q GVKYT1B7qwrlgMwXg0Fed9QuLJAWFc+73xVSblvWc=; b=yjVY1zX/CNOjDgaikV KsgA6T4ZmG6zmYW2MMeR1ZglSZzQgqh+6Ntz9UCLSsXneW2/rJBZbKYMdTPBnKey wymd4Do69W+xJLCgu6xVkpPDVIMSvX3+LtafOwrX4NrILQgnxd89WMe963gaMQXI NpD4DmIYzsDF1YcUx3nH5+jwncBy971m1TkuQuFw26OoDPLO/6ftlP0NgD9MYBR8 B+tJ0uRkvmZys8qPDBInOMnLVsgdhCfCgJ+pQcSyAvza0EVB0ZRp01tVHESvJP93 ynPiftFjFJIPjkqMNnjhJUa/iuJikG0AkIAwGv2J2wjfldOKrNQQVcljCFfpOcCA ebKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700674970; x=1700761370; bh=4qGVKYT1B7qwr lgMwXg0Fed9QuLJAWFc+73xVSblvWc=; b=QB6J1++lSADjwDoB6VBvueQz7pYTh l3pptE8/mpJrECczilynFgu8hI5KmXWbYqlnE7SqNpf6RTB3gro3vCb6U6gjzNIo aREz4e1jSSydgYiZUstUb3EeLG/mF8Ht1k5yu2k65m5YYGFLmvDkRgYK+FGn3ohj QdwVdqc+L1rekzylds7NrO+Gww6tekCcLKL5FTg4BakG5OFt5D0MesuBXboFioSN 63kw8K2rr9LQ0oROIlhWd7UQwwIM9+8xjsgafl3Rxe2bY71v0FZzx7VMh5H4yw8A /arBxIKldQ9zpx1y0clQjLyImIKpIOrciK25nev74S4sYaG7iQ/7OzsKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 12:42:48 -0500 (EST) References: <20231028000945.2428830-1-shr@devkernel.io> <20231028000945.2428830-3-shr@devkernel.io> <724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: David Hildenbrand Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/4] mm/ksm: add sysfs knobs for advisor Date: Wed, 22 Nov 2023 09:42:16 -0800 In-reply-to: <724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com> Message-ID: <87ttpdr8fe.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8074BC0012 X-Stat-Signature: cemgqyacwzwsskdfs1i873i5z9m9858g X-HE-Tag: 1700674972-131419 X-HE-Meta: U2FsdGVkX1+aspmLNFDnkfrLbi0vbsXsVrieYZ1lUGcAnvgZBqbZcRYVd0aLH3HgrT2UbX/ETlh+OFByIa1hKj65zWPRjBM+IStH65dpAsKl/EpO9ELq5Sw23ketISKnSYslbya1dcfHA0610MmXRzVD2zvTAu2c2xVISPm/9Q0oOQde6uxYerrV6fy9raIX7L1nuTOWJ0YQqL2Pq7tO/Q4ygLOF+iwfWblgP99yJv4pL91xb4LzXi7hscAvZMaaQIfwKRxqlo7mJvqj2dah8NuA79FRfILAUDABIe5xOPlhLRrzw69q7Cs+tUC6O2PDYryG/BEgAIUVPiTg9A6Vsbl9YCmpDFtGsrbzANzWdzRASdEcL6H47vdPor7nLwlGTgi0J7FnngxKYWe06OpO+JeQ548rbyrykzB+2+vze/XvGxr6Kn1w0sTj7lf624h0V7+f690IPhBvkqaUzwkbkKTT4cY8UtGR692YlYy+5guTfJRyCebcVDJsqXdLneYAplLBZNuHevrlkrfA6Fa8cdnqzSzmuv1FA1kzIOqJ0znv1ANvOtpd/vx6jq+ZtPvrT0Y+W4jDvAzxa6c+2+EFay1+BRMGwXwNZX84PNxEhnpG4ModfmAHKp4tHDVydRA9QjCrywAoZ+1UzETT5JSFVECvZHfrs+GhzDZEukVU0vRs6uD1sAxWQR5QUWdTerasAOS86EUe9re9No/oHGcDVj/su06vtmdlL2cizDpcT4AYWKEmEZl7gDAUuH1vJZC6RV5whpbsgNg8IaVNf7Oof5L2Z+NSr4E+8+abod6F3Wlai98E2O/Mqs+PCmxeJ++HYiJMWtNEuuehgM/DkzyoGkEh8jNog2XggOGDsT3IlsDgPB8iRuSivTEkY64v8Zj+9mm+Cvx8hg9ZElAK755diHhGwjeE4HTID08OmdsUfoSvxELPyQVDxcVp4UjkWWSvJm0G8eZQxRMt7amqpFU r51Clf8r 0gq4FbHI/Qjpo1oHIpzfJ9fxDBNoGtDinQ1MtKagP5XWVAAED7oQJ8PJDRaj+SxpgXYXjZshEDdj9aex6h82kMlsmxQ236q89UJY44FS8NGBLX6/aGB9CE3qdZ1TIxbloGzyAZUobFzmWh3VUshC8+i4SZ15gbVgpM37uIzfWdWqbAu4phpBeDsM8It+XsgvvpMyZ5pQsIt2YrAHaXKadzKkQTtTKx1mmutgbzAcn1gPZHJ6PCBQAgJIBHLI3SLsGe4rf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 28.10.23 02:09, Stefan Roesch wrote: >> This adds four new knobs for the KSM advisor to influence its behaviour. >> The knobs are: >> - advisor_mode: >> 0: no advisor (default) >> 1: scan time advisor >> - advisor_min_cpu: 15 (default, cpu usage percent) >> - advisor_max_cpu: 70 (default, cpu usage percent) >> - advisor_min_pages: 500 (default) >> - advisor_max_pages: 30000 (default) >> - advisor_target_scan_time: 200 (default in seconds) > > Is there a way we can avoid exposing advisor_min_pages/advisor_max_pages and > just have this internal e.g., as defines? > Yes, we can.