From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct
Date: Thu, 29 Sep 2022 17:17:28 -0500 [thread overview]
Message-ID: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <20220929203903.9475-1-lukas.bulwahn@gmail.com> (Lukas Bulwahn's message of "Thu, 29 Sep 2022 22:39:03 +0200")
Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Alphas binfmt_loader is the only use I can find of that variable
so let's kill it as well.
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Kees, please pick this patch on top of the commit above.
>
> include/linux/binfmts.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 3dc20c4f394c..8d51f69f9f5e 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -43,9 +43,6 @@ struct linux_binprm {
> * original userspace.
> */
> point_of_no_return:1;
> -#ifdef __alpha__
> - unsigned int taso:1;
> -#endif
> struct file *executable; /* Executable to pass to the interpreter */
> struct file *interpreter;
> struct file *file;
next prev parent reply other threads:[~2022-09-29 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 20:39 [PATCH] binfmt: remove taso from linux_binprm struct Lukas Bulwahn
2022-09-29 22:17 ` Eric W. Biederman [this message]
2022-09-29 23:36 ` Kees Cook
2022-09-29 23:39 ` Kees Cook
2022-09-30 16:35 ` Eric W. Biederman
2022-09-29 23:42 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu4p3jwn.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox