Re: [PATCH] mm/swap: Fix lost swap bits in unuse_pte()

Miaohe Lin
2022-04-20T06:23:32Z

On 2022/4/20 13:56, kernel test robot wrote:
> Hi Peter,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on hnaz-mm/master]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845
> base: https://github.com/hnaz/linux-mm master
> config: s390-randconfig-r023-20220420 (https://download.01.org/0day-ci/archive/20220420/202204201313.QYiDBRbL-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install s390 cross compiling tool for clang build
> # apt-get install binutils-s390x-linux-gnu
> # https://github.com/intel-lab-lkp/linux/commit/355ac3eb45402f7aab25b76af029d4390af05238
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Peter-Xu/mm-swap-Fix-lost-swap-bits-in-unuse_pte/20220420-053845
> git checkout 355ac3eb45402f7aab25b76af029d4390af05238
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>

The variable name is newpte. But it's written as new_pte latter. Many thanks for report!

BTW: Since this is not a formal patch (no compile tested). Is Reported-by tag still needed?

Thanks!

> All errors (new ones prefixed by >>):
>
>>> mm/swapfile.c:1824:2: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'?
> new_pte = pte_mkold(mk_pte(page, vma->vm_page_prot));
> ^~~~~~~
> newpte
> mm/swapfile.c:1786:14: note: 'newpte' declared here
> pte_t *pte, newpte;
> ^
> mm/swapfile.c:1826:26: error: use of undeclared identifier 'new_pte'
> pte = pte_mksoft_dirty(new_pte);
> ^
> mm/swapfile.c:1828:23: error: use of undeclared identifier 'new_pte'
> pte = pte_mkuffd_wp(new_pte);
> ^
> mm/swapfile.c:1829:36: error: use of undeclared identifier 'new_pte'; did you mean 'newpte'?
> set_pte_at(vma->vm_mm, addr, pte, new_pte);
> ^~~~~~~
> newpte
> mm/swapfile.c:1786:14: note: 'newpte' declared here
> pte_t *pte, newpte;
> ^
> 4 errors generated.
...
> 1839
>