From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9E0C433EF for ; Wed, 1 Dec 2021 06:16:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CCDD6B0073; Wed, 1 Dec 2021 01:15:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 954896B0074; Wed, 1 Dec 2021 01:15:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE8F6B0075; Wed, 1 Dec 2021 01:15:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 685C66B0073 for ; Wed, 1 Dec 2021 01:15:54 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3086B89576 for ; Wed, 1 Dec 2021 06:15:44 +0000 (UTC) X-FDA: 78868214208.12.F0FECDF Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf16.hostedemail.com (Postfix) with ESMTP id F18E3F00008C for ; Wed, 1 Dec 2021 06:15:43 +0000 (UTC) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B14plF5009384; Wed, 1 Dec 2021 06:15:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=45sl5+gG9/zE9FU7uGSF93cJvmgBFbhYUclGGRzq5uU=; b=p98H3p5BhdktOfY0a0rYNT//TvDrEh2xbtf3x4mlYiHQGRDgR/FAmQmoWR9PP/qxFPDR VnOL+pND1VmAy0GCuXY6ET5YZeIq0QA5KMKlskSPtiktLdQ1B/lJ616n+Vd1Eu/w3tfZ 7HDjGimp5I7niTOAtZ+706y0gaOwBGFVdQiaWd3C5RT/vR1qX6Mbyq6MWEMNdzTXjCcy uk0CLPpsNiPpWClF2QGt5/785xffFB+bhmow0RmavUIfRT/rcXxE6vx8WmmFQsxS1f/M rRAN5LIOQgQKsNfjtyIAf1HlQ5N63TNEhPdu3e+cAd5oQB6ve2tsjBLDz2JUEq3Tjc2S DA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cp2d81aqy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Dec 2021 06:15:33 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1B152afs011795; Wed, 1 Dec 2021 06:15:30 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cp2d81aqf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Dec 2021 06:15:30 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1B168eLF022334; Wed, 1 Dec 2021 06:15:29 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01dal.us.ibm.com with ESMTP id 3ckcac8y82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Dec 2021 06:15:29 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1B16FRa915204784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Dec 2021 06:15:27 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A96DE124053; Wed, 1 Dec 2021 06:15:27 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6A11B12405C; Wed, 1 Dec 2021 06:15:21 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.38.73]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 1 Dec 2021 06:15:21 +0000 (GMT) X-Mailer: emacs 28.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Daniel Jordan Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Ben Widawsky , Dave Hansen , Feng Tang , Michal Hocko , Andrea Arcangeli , Mel Gorman , Mike Kravetz , Randy Dunlap , Vlastimil Babka , Andi Kleen , Dan Williams , Huang Ying , linux-api@vger.kernel.org Subject: Re: [PATCH v5 2/3] mm/mempolicy: add set_mempolicy_home_node syscall In-Reply-To: <20211201004758.boix3k76bjtz2p4u@oracle.com> References: <20211116064238.727454-1-aneesh.kumar@linux.ibm.com> <20211116064238.727454-3-aneesh.kumar@linux.ibm.com> <20211201004758.boix3k76bjtz2p4u@oracle.com> Date: Wed, 01 Dec 2021 11:45:14 +0530 Message-ID: <87tufsc0lp.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fsXirh7_1ayG8a7rEcy0Lt_3KYEOPOmf X-Proofpoint-ORIG-GUID: Dw2KghJQ5rfuFiF8bEhWvAcKhMUX3Zd8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-30_10,2021-11-28_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 clxscore=1011 suspectscore=0 phishscore=0 impostorscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112010034 X-Rspamd-Queue-Id: F18E3F00008C X-Stat-Signature: y6ntb8eaezqzmdn1fmd3qhe8cpgeh5cq Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=p98H3p5B; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com X-Rspamd-Server: rspam02 X-HE-Tag: 1638339343-485573 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Daniel Jordan writes: > On Tue, Nov 16, 2021 at 12:12:37PM +0530, Aneesh Kumar K.V wrote: >> sys_set_mempolicy_home_node((unsigned long)p, nr_pages * page_size, >> home_node, 0); > > What about sys_mbind_home_node so the name is better aligned with mbind, > since both operate on vma policy? The syscall might or might not be > extended to task memory policy, but vma policy is what we're using this > for today. I used the name set_mempolicy_home_node, because we are setting the home for a memory policy. I find the term mbind confusing. > > >> +SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, len, >> + unsigned long, home_node, unsigned long, flags) > > mbind does untagged_addr(addr), why doesn't this need to do the same? > Seems like tagged addresses could be passed here too. > updated modified mm/mempolicy.c @@ -1489,6 +1489,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le unsigned long end; int err = -ENOENT; + start = untagged_addr(start); if (start & ~PAGE_MASK) return -EINVAL; /* > >> + /* >> + * Only update home node if there is an existing vma policy >> + */ >> + if (!new) >> + continue; >> + new->home_node = home_node; >> + err = mbind_range(mm, vmstart, vmend, new); > > I think you need an mpol_put(new) here since @new is dup'ed again during > mbind_range > vma_replace_policy. updated @@ -1536,6 +1540,7 @@ SYSCALL_DEFINE4(set_mempolicy_home_node, unsigned long, start, unsigned long, le new->home_node = home_node; err = mbind_range(mm, vmstart, vmend, new); + mpol_put(new); if (err) break; } Thanks for your review -aneesh