From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 744B56B0087 for ; Sun, 21 Nov 2010 11:35:04 -0500 (EST) Received: by qwi2 with SMTP id 2so1646420qwi.14 for ; Sun, 21 Nov 2010 08:35:02 -0800 (PST) From: Ben Gamari Subject: Re: [RFC 2/2] Prevent promotion of page in madvise_dontneed In-Reply-To: <5d205f8a4df078b0da3681063bbf37382b02dd23.1290349672.git.minchan.kim@gmail.com> References: <5d205f8a4df078b0da3681063bbf37382b02dd23.1290349672.git.minchan.kim@gmail.com> Date: Sun, 21 Nov 2010 11:34:57 -0500 Message-ID: <87tyjavdn2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org To: Minchan Kim , Andrew Morton Cc: linux-mm , LKML , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin List-ID: On Sun, 21 Nov 2010 23:30:24 +0900, Minchan Kim wrote: > Now zap_pte_range alwayas promotes pages which are pte_young && > !VM_SequentialReadHint(vma). But in case of calling MADV_DONTNEED, > it's unnecessary since the page wouldn't use any more. > Is this not against master? If it is, I think you might have forgotten to update the zap_page_range() reference on mm/memory.c:1226 (in zap_vma_ptes()). Should promote be true or false in this case? Cheers, - Ben -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org