Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints

Gregory Price
2025-01-03T19:19:22Z

On Fri, Jan 03, 2025 at 03:48:24PM +0530, Donet Tom wrote:
>
> On 12/11/24 03:07, Gregory Price wrote:
> > Count non-page-fault events as page-cache numa hints instead of
> > fault hints in vmstat. Add a define to select the hint type to
> > keep the code clean.
> >
> > Signed-off-by: Gregory Price <gourry@gourry.net>
> > ---
> > include/linux/vm_event_item.h | 8 ++++++++
> > mm/memory.c | 6 +++---
> > mm/vmstat.c | 2 ++
> > 3 files changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
> > index f70d0958095c..c5abb0f7cca7 100644
> > --- a/include/linux/vm_event_item.h
> > +++ b/include/linux/vm_event_item.h
> > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
> > NUMA_HUGE_PTE_UPDATES,
> > NUMA_HINT_FAULTS,
> > NUMA_HINT_FAULTS_LOCAL,
> > + NUMA_HINT_PAGE_CACHE,
> Hi Gregory,
>
> While running tests on the patch, I encountered the following warning
> message on the console.
>

Thank you for catching this, will add to v3.

v3 is coming soon with more microbenchmark info, then hopefully moving
on to some workload testing.

~Gregory