Re: [RFC v2 PATCH 0/5] Promotion of Unmapped Page Cache Folios.

Gregory Price
2024-12-27T15:40:44Z

On Fri, Dec 27, 2024 at 10:16:42AM +0800, Huang, Ying wrote:
> Gregory Price <gourry@gourry.net> writes:
>
> > On Sun, Dec 22, 2024 at 03:09:44PM +0800, Huang, Ying wrote:
> >> Gregory Price <gourry@gourry.net> writes:
> >> > That's 3-6% performance in this contrived case.
> >>
> >> This is small too.
> >>
> >
> > Small is relative. 3-6% performance increase across millions of servers
> > across a year is a non trivial speedup for such a common operation.
>
> If we cannot only get 3-6% performance increase in a micro-benchmark,
> how much can we get from a real life workloads?
>
> Anyway, we need to prove the usefulness of the change via data. 3-6%
> isn't some strong data.
>
> Can we measure the largest improvement? For example, run the benchmark
> with all file pages in DRAM and CXL.mem via numa binding, and compare.
>

I can probably come up with something, will rework some stuff.

~Gregory