Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints

Donet Tom
2024-12-29T14:57:56Z

On 12/27/24 21:19, Gregory Price wrote:
> On Fri, Dec 27, 2024 at 04:18:24PM +0530, Donet Tom wrote:
>> On 12/11/24 03:07, Gregory Price wrote:
> ... snip ...
>>> + NUMA_HINT_PAGE_CACHE,
>>> + NUMA_HINT_PAGE_CACHE_LOCAL,
>>> NUMA_PAGE_MIGRATE,
> ... snip ...
>>> if (folio_nid(folio) == numa_node_id()) {
>>> - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);
>>> + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf));
>> I have tested this patch series on my system with my test program. I am able
>> to see unmapped page cache pages are getting promoted.
>> numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501
>>
>> In my test result numa_hint_page_cache_local is 0. I am seeing
>> numa_hint_page_cache_local will only be incremented if the folio's
>> node and the process's running node are the same. This condition
>> does not occur in the current implementation, correct?
>>
> I did not want to assume we'd never use this interface where such a
> scenario could occur - so i wanted to:
>
> a) make such a scenario visible
> b) make the code consistent with existing fault counts
Understood, thank you for clarifying!
>
> I'm fine removing it. It's hard to know if this interface ever gets
> called with that scenario occurringwithout capturing the data.
>
> ~Gregory
>