From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735C3C04A94 for ; Mon, 31 Jul 2023 22:43:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B27182800B6; Mon, 31 Jul 2023 18:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD79A28007A; Mon, 31 Jul 2023 18:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99EAA2800B6; Mon, 31 Jul 2023 18:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8827228007A for ; Mon, 31 Jul 2023 18:43:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4E729803CB for ; Mon, 31 Jul 2023 22:43:30 +0000 (UTC) X-FDA: 81073384980.22.1DCF3BB Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf11.hostedemail.com (Postfix) with ESMTP id A9B7740024 for ; Mon, 31 Jul 2023 22:43:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=PHQpaRnD; dkim=pass header.d=linutronix.de header.s=2020e header.b=PRvRmlun; spf=pass (imf11.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690843407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=33Fq0Wu+LfDasDHlhoRJ+tEuyTqh8mt568Pu/UPLqZ0=; b=hlmIKeUvHLrvjKBiZ1cLrpE+AZJ0xCHxBKpZhEz8uGgM/uHS4hUOIkgsIBpJL0o407Yo9d 3iJNOYvw8kLMjc2wi5t0/a6hZDj1ksqHmI+140dIfG32zLG6Mxz21XGH8979o+JdPs1+1o n2xPEswJe1PjQ6jWwTXuOeKhr0ydlkA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690843407; a=rsa-sha256; cv=none; b=RvGQdNfhJRJ1QKp08TWd8C56B79mJZkhj1OAdHcQ4hn0TyV11NHDZE5G2bca3USLOOrIS0 6BlJ8rz/60UjwJH+eu2sGtbKmp8WhqJQI4Uy0OXeR/XvOZuKX93lJFjel3Tixmoxgj0MW5 Ox92heQ3d9fjWD1w/uUe8iqzxxOXWEg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=PHQpaRnD; dkim=pass header.d=linutronix.de header.s=2020e header.b=PRvRmlun; spf=pass (imf11.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690843404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33Fq0Wu+LfDasDHlhoRJ+tEuyTqh8mt568Pu/UPLqZ0=; b=PHQpaRnDsOkNetg825gd7IMakLKEP04uFP8GjAkP881xDRNXfPSgpbfOr3P/ZzLgdLAcog t84/0kkZB8NqGFR3FI2hQNvWMOLbKioKkFwRxkdH20Fa27GvDIm0eywiEooeOxvDwJnTUQ 7sULS3F2uUNKXpQByKioVMv0LN8JAUeUK56WYbfHkE8OeeH297dNymSbkyU4DVgQAASEBL RJovwWu7lOUgjmS/tGHcenWqOndXgJvUa/6STM+ARb/+OlxVyQ4tkiV4DBd8inkCx83kIq OyRIsZ33PKZchkj8QQIzWFKvLakZfO/1wjzytu0JTjG2FzHcVCS/YC3y6O7T1g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690843404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=33Fq0Wu+LfDasDHlhoRJ+tEuyTqh8mt568Pu/UPLqZ0=; b=PRvRmlunvV0e6RaleyV3C7+1OWJpkshHGoUIFIKaYZat4z36ufWvuSv5CP4m/eqDs0eWe2 zwip5a5ebJA1mqCA== To: Peter Zijlstra Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags In-Reply-To: <20230731213341.GB51835@hirez.programming.kicks-ass.net> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> <87edkonjrk.ffs@tglx> <87mszcm0zw.ffs@tglx> <20230731192012.GA11704@hirez.programming.kicks-ass.net> <87a5vbn5r0.ffs@tglx> <20230731213341.GB51835@hirez.programming.kicks-ass.net> Date: Tue, 01 Aug 2023 00:43:24 +0200 Message-ID: <87y1ivln1v.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: A9B7740024 X-Rspam-User: X-Stat-Signature: mdnwtotmi3swu7snzt1yc8jxdbnpgapq X-Rspamd-Server: rspam03 X-HE-Tag: 1690843406-999643 X-HE-Meta: U2FsdGVkX19Xx1UwyrdJ+23do4pS71QRsT29WbURlpC/yn4YY3CUABLXod1+ce6XnDGBZvhIF9qeEQGbArXBgNmnjPMCNSwt0EELlpdjBpvvp4nMArf5FC5gOWCM8Nu/kOxeJnbypHl4ebAQUsvaeqRs5ghMbJW713bMDTy4+sUkIe+wCeFABiYd88mkH3Nkeo/4KT2dgCw0MNbuGzxNN92+AuCXRsR5mhunrfMmWwKQQH5Hudck0qWS9UY44KUquvhSD7f/yisjyoJ8tE/vK1S4L7hMyKNjxEUdTCX+OoA94zCjlOKjQBVr+XAISPYg7XArwN0Na4carhKh5KnnAzORtTVlqph+LT+ZWG6/L/C7S9G2kMU3RytHbDE0JNJT8N2FHW9VX2dWGTQoLU16aVxyxdWPloVWnm/i3VIWkqlpxPUytYvkS47fcACxrYNP7Av7alKb8qY9PzOhewUKFUSgOQ+rG+5bbwIooGdMl8f3HZoohofqjwvbw+Cyl2EQ6MoJBdXuMI33MRgZ1aDVEqH81sMm3N+7NFeCogAYXaQudEygQN+Md1nvraITBk68H0R7YSbeFeAinhm2QlqDeQM1z6R3OJoSJ8UGiUwNq6bDhkjfGRHIvRPZ0YTMBFe4LNYTZhoytuNzXqgQht+ynIZXMjphyfe12YbOeeCqAPI3thXJnqfMzgvxjPkkqCYRAYwkSC/QZj2eTtmdebpi0sNVM3IakPeD2YWwaGC2lzh7fzinK6HwAB8s8u7xjGz07gh6V8z2XPSR3jU7Qt1JqyqscHYr9izT1g4/i6ApdUMF6W2+9Yo+2/u1rkoRpetSlmmOGtTcF0RZwfqzPqwE6yF6oemfAgFYk3OwrpUI0gJw5IUjHvZ9LvGJcG9YBNJTgeOSW3D4S+nbetV1P7lqwiVoBv1rZk5rMSGfGbp3y9KRbsPSLWZKvCme1aRGa+qb7GDwc9LWLVQv1b1f5vx brXYOwCH zAJBD9fpbNyCKmGPSVBzZLo7+ZC0gGCG4/jNPIc/QJtXiCwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31 2023 at 23:33, Peter Zijlstra wrote: > On Mon, Jul 31, 2023 at 11:14:11PM +0200, Thomas Gleixner wrote: >> --- a/include/uapi/linux/futex.h >> +++ b/include/uapi/linux/futex.h >> @@ -74,7 +74,12 @@ >> struct futex_waitv { >> __u64 val; >> __u64 uaddr; >> - __u32 flags; >> + union { >> + __u32 flags; >> + __u32 size : 2, >> + : 5, >> + private : 1; >> + }; >> __u32 __reserved; >> }; > > Durr, I'm not sure I remember if that does the right thing across > architectures -- might just work. But I'm fairly sure this isn't the > only case of a field in a flags thing in our APIs. Although obviously > I can't find another case in a hurry :/ I know, but that doesn't make these things more readable and neither an argument against doing it for futex2 :) > Also, sys_futex_{wake,wait}() have this thing as a syscall argument, > surely you don't want to put this union there as well? Why not? The anon union does not break the ABI unless I'm missing something. Existing user space can still use 'flags' and people who care about readability can use the bitfield, no? Its inside struct futex_waitv and not an explicit syscall argument, right? > I'd much prefer to just keep the 'unsigned int flags' thing and perhaps > put a comment on-top of the '#define FUTEX2_*' thingies. Note that > having it a field instead of a bunch of flags makes sense, since you can > only have a single size, not a combination of sizes. I'm aware of that by now :) Still that explicit bitfield does neither need comments nor does it leave room for interpretation. Thanks, tglx