From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593BEC433E2 for ; Wed, 16 Sep 2020 01:45:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0506620936 for ; Wed, 16 Sep 2020 01:45:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0506620936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E408900006; Tue, 15 Sep 2020 21:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3945C8E0001; Tue, 15 Sep 2020 21:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AA2F900006; Tue, 15 Sep 2020 21:45:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 0EB3B8E0001 for ; Tue, 15 Sep 2020 21:45:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE145362D for ; Wed, 16 Sep 2020 01:45:02 +0000 (UTC) X-FDA: 77267231244.09.milk38_1b1286127116 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 97CE7180AD815 for ; Wed, 16 Sep 2020 01:45:02 +0000 (UTC) X-HE-Tag: milk38_1b1286127116 X-Filterd-Recvd-Size: 2770 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 01:45:01 +0000 (UTC) IronPort-SDR: w9NgUYDsiIsUU2HE269pVEyxucZ6vGtlE2DvkuO7qnXhKGOPCqBZB3c/YftF6lfvran0yguX56 SjzlrSI2qqoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="147133506" X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="147133506" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 18:44:57 -0700 IronPort-SDR: RazOz+Y8LHUj45syU0qi7c3+WZx60FWYIdMO8T5mpaCEDRID0Wr4V/uMKmqDmVgyfFIyyfH8Hv 0y3RmwPGeYdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,430,1592895600"; d="scan'208";a="346067147" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.164]) by orsmga007.jf.intel.com with ESMTP; 15 Sep 2020 18:44:56 -0700 From: "Huang\, Ying" To: "Matthew Wilcox \(Oracle\)" Cc: linux-mm@kvack.org, Andrew Morton , "Kirill A . Shutemov" Subject: Re: [PATCH 07/11] mm/huge_memory: Fix can_split_huge_page assumption of THP size References: <20200908195539.25896-1-willy@infradead.org> <20200908195539.25896-8-willy@infradead.org> Date: Wed, 16 Sep 2020 09:44:55 +0800 In-Reply-To: <20200908195539.25896-8-willy@infradead.org> (Matthew Wilcox's message of "Tue, 8 Sep 2020 20:55:34 +0100") Message-ID: <87y2lasdew.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 97CE7180AD815 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Matthew Wilcox (Oracle)" writes: > Ask the page how many subpages it has instead of assuming it's PMD size. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/huge_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index e9503b10df8f..8bf8caf66923 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2546,9 +2546,9 @@ bool can_split_huge_page(struct page *page, int *pextra_pins) > > /* Additional pins from page cache */ > if (PageAnon(page)) > - extra_pins = PageSwapCache(page) ? HPAGE_PMD_NR : 0; > + extra_pins = PageSwapCache(page) ? thp_nr_pages(page) : 0; > else > - extra_pins = HPAGE_PMD_NR; > + extra_pins = thp_nr_pages(page); > if (pextra_pins) > *pextra_pins = extra_pins; > return total_mapcount(page) == page_count(page) - extra_pins - 1; Acked-by: "Huang, Ying" Best Regards, Huang, Ying