From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EFAFC0015E for ; Tue, 15 Aug 2023 07:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01A12900025; Tue, 15 Aug 2023 03:47:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0CE490000B; Tue, 15 Aug 2023 03:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4BE900025; Tue, 15 Aug 2023 03:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC2C290000B for ; Tue, 15 Aug 2023 03:47:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A2F3940CF9 for ; Tue, 15 Aug 2023 07:47:39 +0000 (UTC) X-FDA: 81125559438.18.9940E95 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 63E0C140010 for ; Tue, 15 Aug 2023 07:47:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FWM6ixe4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692085657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U9WI6vQ5llVHbEYM78RYbjm6tRjhBC9Sm9S02m/dXqw=; b=3jZedxk9sWk5D8fsEraaAJPtvhgUD73DH4snMGKX5UxpBiH5bWUo8BT9LndYZheN3PSQ08 hnv1GnqU8M4qN3Lfb9Jr3XInuWLcXfNh8tdrkA85uAkbc5PSyC5cIK3g0xO+HNdwt9Ojjf iip+9eEf4iXpIbnVCHEFCwlJUOIzwh4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FWM6ixe4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692085657; a=rsa-sha256; cv=none; b=0aZg4N9pz1tS2wUw91ozDqWHyMm9tqyBPATehTOs6/RUVirFv2M8Jw48gzB7xa2k+UE/l3 JfOqv9Y3CsR3708xECyP7JRHavp428xVQZ+saXGh7yeJK0y0XuFwWd1IpbIHlrhJZYXe6w 9+6Av5Aj42QdLGK5/VmC9HBq1qHn4L0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692085656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9WI6vQ5llVHbEYM78RYbjm6tRjhBC9Sm9S02m/dXqw=; b=FWM6ixe4O+kG/AJzmgONi6qXwmiqLDu/SBsHOLW3ylDfAdTQpjV4lZkLyFL4LepPfEHyLQ lC8W0shdC+/8InuWajbj/1autASED58W5Z5aTkU92eVhllGo3/EpEF/dslMegA3z2QfjaE 8EBwyCctA7LFrRe6abaqXcaqBuUSfZI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-eeM5UlcMPSCXyFkWXivzog-1; Tue, 15 Aug 2023 03:47:33 -0400 X-MC-Unique: eeM5UlcMPSCXyFkWXivzog-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fe32caefd8so4699541e87.3 for ; Tue, 15 Aug 2023 00:47:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692085652; x=1692690452; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U9WI6vQ5llVHbEYM78RYbjm6tRjhBC9Sm9S02m/dXqw=; b=FCCBr7m4xmPf87Ec/NHVB4ZPU+JqgWmuE+kFBs0gPq5AFPxl6027DmzmBBR0ooGMB0 ePQrGyoIIZ0Bn+JIM5Dpn4pqQAvcyl5Nc0y+nwdY2hoG3bAmcAS9vpTHEUGckQYMAsEu wZubBk45ko0UG21FvMA3tgA47iL6dipIdprhJ7wH5km7Yx2qFQJAYVVqAM6z/zVv9YZ3 AG/NhXCnG3S90/Ko5bzqpFZxkhLJLzyUpaCibvev0qgADbdxSE15WUL/vX5F/f/KF+xV VolvvbnJ9HnxGxXwEGGWMkVt2COFOg0rzHcLCSpXyAChLTbqlyzYLCHsrJAGqrn3RK9W 0CrA== X-Gm-Message-State: AOJu0YzFQUWfFrfBhfzC+vB2x1jcRSn00C+B+5codH0X4VdJ5mhl7u4g PKI+NLd/K0LkFo9JmMqCoAEFmAsa8G2JclMP2ObE6/JRU7ADAa/9xgZXW3uW7ZpCTdu3qxpIK9S oQCAPyvb4NOM= X-Received: by 2002:ac2:58f9:0:b0:4fb:52f1:9ab4 with SMTP id v25-20020ac258f9000000b004fb52f19ab4mr6916989lfo.50.1692085652492; Tue, 15 Aug 2023 00:47:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEn/+9FLUMvqvZJAedRtIcoaqf3xBJfwu2f9J7bpfh05zvjIPFKbBEjBFVDDIYjgtcjXl575Q== X-Received: by 2002:ac2:58f9:0:b0:4fb:52f1:9ab4 with SMTP id v25-20020ac258f9000000b004fb52f19ab4mr6916766lfo.50.1692085642570; Tue, 15 Aug 2023 00:47:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c701:3100:c642:ba83:8c37:b0e? (p200300cbc7013100c642ba838c370b0e.dip0.t-ipconnect.de. [2003:cb:c701:3100:c642:ba83:8c37:b0e]) by smtp.gmail.com with ESMTPSA id v1-20020a05600c214100b003fe215e4492sm16925604wml.4.2023.08.15.00.47.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 00:47:22 -0700 (PDT) Message-ID: <880a26db-f46e-7d28-b4fc-ff34a2566acf@redhat.com> Date: Tue, 15 Aug 2023 09:47:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/9] mm: Make free_compound_page() static To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-5-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230815032645.1393700-5-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 63E0C140010 X-Stat-Signature: o6cxijxfimuxotdr9xn331hoedci57s5 X-Rspam-User: X-HE-Tag: 1692085657-860203 X-HE-Meta: U2FsdGVkX1/gCEsqCTqCFQT9fLmpOP9xOssUZ5MR2A61gP5UHt45/OsBziOUuXkzzLR1OHzvalNnoPP11USNEOQdKcnp8AE1eTw0LbqJO0bFHSjvuM1EG9212LF7MtQxVwLX2zsG73P61r5god+qq61Bef/bq48kHZJV1nxA5gkhPU7S3ShfmipE9xP47ImikjCaCZUS/RwjvG58rK2DPfQBvj3vDRE0U9UjWwuprKHpMm71X1MolUFlDf3C4gJrbLkv1GwsQ2I/ZIn+wimcgfyNf2kyk1182uVHfVuxyqZb3bHvklS1vw1guFLvD4MTeQNuH1a1T+MvbfXCfTduaDpXTwTvmF6stXHRGv7bD54BtoEG/oueaoGsz5zLxScfZNos+1BFfjdJZN0V/F9FBL5g3gr9R5DqrhoCWvZb+BqyBLUPXG2Dd9Nvo07eqv5kFpkd4sfCAFiAfxEZlRvQZxMQPumqGHEiYEPbK1EcLGuaGcn6IRWSFxcWun5CPv8ZhhxnlktTMzZ4X2yayS0GX8/6NttEKWrgqKtZZHGL6VKZuHk3vQQIIP6UsRWjcDJmYZYow+ROSihVF6jWH7uOm1YYKIgUL0LARkNIqGG3tJ/XfE4xgUVS5tib+MrKsTA9lEJmZvODbULkcVxsVTLbu3LuC5T2HuRLJCyFEA76Fc6kLmzCC/MFHA/y9Uj4InI/01GO1HQ9b0RuFfXE54UGuidUxnj8e5eT8LuhGWL48NiWkFQGqzy+CjFdA0bUAv0f71ezfSZL/x/lhjQQtD1x33DTW4CGJcdl9z1oyIxsT5vNnQkM1MufMMg7R0+v2FCfjqOnaG3migniqcNmVwjczZ0F68/Bjx8uWRAHMCtKUJ527qXfc7RiyrT1VDGr+pEL+VHQ8lFIt/SCe8zmEq82GFYSxcsCpEt/1t+YuWq6OV89y63UHpXC9u6HOEVjulbO++sFcshSWCsWAABez8x w7miNvOO Uzvq0JnR+XSvA/4zzKgJXpIrVLeyTjyCYBvwpW/VH+/51KeUfCPaLIeDj4/M3n4k+0+ygoA4qSeUX5IhJC3KABT4adoNUmiQIgiCCm5KxHbFTcJnuQcIbRXLeep6+QR5sKFynm55DVo6MpuoHWrC7VdjTPAWEquQ+p6w9285xO+RinlytC0pTM8oTCAWqRmQq3/mp/Sb1ZDB8/X/lAJd7qLhx4OIhdcHdM77DiobBC5Qg+UPLmPueY7mn2j7hzZiwqYc6oL86cghF4PyuhfZzHjsBf/49ZVPG+FFwWFqic54GiTvPC1Irjv8XcMz9WNNQaAhctozBVb3UnIJddJOkwjTkOvXtQn4cWqt2f9eX6Q3BcWoypi4G2RHSzQnwpTTUFmnheLMm2aZvQCsnQrn5MK5tUezWdMb94HlgjMZTm1QyK3sMZlPDuYNs3PdwGo1gy5XJxk/hu0LlIEtKy/x/e9beBI46TD5GOQVtTkgIWlaiwpmSrPpQlO7q377Y30Ejo1WK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: > free_compound_page() is the only remaining dynamic destructor. > Call it unconditionally from destroy_large_folio() and convert it > to take a folio. It used to be the last thing called from > free_transhuge_folio(), and the call from destroy_large_folio() > will take care of that case too. > > This was the last entry in the compound_page_dtors array, so delete it > and reword the comments that referred to it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- [...] > int min_free_kbytes = 1024; > int user_min_free_kbytes = -1; > static int watermark_boost_factor __read_mostly = 15000; > @@ -587,17 +582,17 @@ static inline void free_the_page(struct page *page, unsigned int order) > * The remaining PAGE_SIZE pages are called "tail pages". PageTail() is encoded > * in bit 0 of page->compound_head. The rest of bits is pointer to head page. > * > - * The first tail page's ->compound_dtor holds the offset in array of compound > - * page destructors. See compound_page_dtors. > + * The first tail page's ->compound_dtor describes how to destroy the > + * compound page. > * > * The first tail page's ->compound_order holds the order of allocation. > * This usage means that zero-order pages may not be compound. > */ > > -void free_compound_page(struct page *page) > +static void free_compound_page(struct folio *folio) "free_folio", maybe? Doesn't seem to be taken yet. Acked-by: David Hildenbrand -- Cheers, David / dhildenb