From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6282C71156 for ; Fri, 18 Aug 2023 14:35:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5376028004C; Fri, 18 Aug 2023 10:35:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BEF4940012; Fri, 18 Aug 2023 10:35:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3384728004C; Fri, 18 Aug 2023 10:35:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 21B3F940012 for ; Fri, 18 Aug 2023 10:35:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DB477C0580 for ; Fri, 18 Aug 2023 14:35:54 +0000 (UTC) X-FDA: 81137474628.18.55DC87C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 5C216A0010 for ; Fri, 18 Aug 2023 14:35:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JfJQ4DvJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692369351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U8Xyd7C4haXDCFCCJ82ZpXcIirbDRYbvnPlINe/0qeA=; b=Kobd17nG4Qss8QaWHFbetKYi3enh5/fcg3RgER19Qcl9M/zua+iSnHLExrOePCqmh7Von4 26BYSsLt1wVp+7nUbxtPy/tnGFsfe5XCqMkRclxIDClR6NUatz2L3S1sNFiDlYtE0N+tDK LVHxx+CuZQWPvZbCQGzOGm6pcNl6cr0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JfJQ4DvJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692369351; a=rsa-sha256; cv=none; b=vhsg6nQcxQ7Xp+YjCcXAAgp3A1JhugvMe4i4EyqnecU/YU/5JRHarOwATCO3ZsEkVcavbo QJoyS6bVYA24Blgtsub5TJhak6g9bmBKx3Gz/FtEL+4TOEdEAI1wgULixc3QN7M2QpDGdJ CDkR3LtKe/nXguDPe0Z5GnuBN2CRGyQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692369350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U8Xyd7C4haXDCFCCJ82ZpXcIirbDRYbvnPlINe/0qeA=; b=JfJQ4DvJDMiboy5AQyBmQSFucRd8TGp1rD2fQWI55SNOjJMRUY/uvuQiE7oKa9i1Jg+0VQ Q3z/sNE38tlAkcu5yOyo/yUUmFP+e2DuZga0p8CDW2b5XK5RJdb6Vipse2yTwJhLVlzQiM WI4wp8HGjjG6+aAFUfuVLzEaajFBF+A= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-qmL1kxo5NqikoH-vhw-WUg-1; Fri, 18 Aug 2023 10:35:49 -0400 X-MC-Unique: qmL1kxo5NqikoH-vhw-WUg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fe13881511so7046265e9.3 for ; Fri, 18 Aug 2023 07:35:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692369348; x=1692974148; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U8Xyd7C4haXDCFCCJ82ZpXcIirbDRYbvnPlINe/0qeA=; b=BYHQtApWvH8s3LexFuP9vDLcDO5TA7XeoKhREY+N0hJbhoXchfMEcIvg8hri2JFEI3 fyXouRsIZV6bTcISH6WrTNYY6f/X7U0btBQz6Di6sRD4AXreeCa+zZXcFoxBYE9l7uqV +yDuekWhFBfvHcZpBfu3Fkvq32zp521iEOCuOGS+UFohOEFtJTkmK5ZttrMec5MFkEfI VyozHt/+HK8Qg2WEIeZJXXO+nWaBJ9auoRjITWSWxxRXZ/PTsPwE3oYsiduQDmWCeKhN JsL0+EAsU3rQIPFrdpaIV9Gm9nriciP92TgRwVeUfu0GKoO4H2JFE05pB/2CUS8hOQua DTDw== X-Gm-Message-State: AOJu0YytwycoWaxAD7ZcoOHQ1I/cOs1l5C/xTLOsPo7TZFmaRmUr2MhN LRcTgS9WSxnewHXRGYv0oZ7U4L5++/iSnUwRYeoIVkFWzZYY5oOEDg9sJuWj/XqdGwePR6N++2T TPIo0PieQIPE= X-Received: by 2002:a7b:cc13:0:b0:3fb:abd0:2b52 with SMTP id f19-20020a7bcc13000000b003fbabd02b52mr2322491wmh.13.1692369348130; Fri, 18 Aug 2023 07:35:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIHiBR/gYcfdq3hvKsYvo9XCnq0GuAu/JJnk9XxpFltL1dwHdEKx3/QYqZY/ZPy8Ry94efDA== X-Received: by 2002:a7b:cc13:0:b0:3fb:abd0:2b52 with SMTP id f19-20020a7bcc13000000b003fbabd02b52mr2322464wmh.13.1692369347635; Fri, 18 Aug 2023 07:35:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:ff00:a22a:6d42:439d:de2? (p200300cbc726ff00a22a6d42439d0de2.dip0.t-ipconnect.de. [2003:cb:c726:ff00:a22a:6d42:439d:de2]) by smtp.gmail.com with ESMTPSA id o17-20020a05600c379100b003fe26244858sm1493187wmr.46.2023.08.18.07.35.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Aug 2023 07:35:47 -0700 (PDT) Message-ID: <886b6a56-8acb-e975-b5f3-d8098a2285ab@redhat.com> Date: Fri, 18 Aug 2023 16:35:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] proc/ksm: add ksm stats to /proc/pid/smaps To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230817162301.3472457-1-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230817162301.3472457-1-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5C216A0010 X-Stat-Signature: uyr7jrq5bbtdrc176knwmfrwsnxhgsqh X-HE-Tag: 1692369351-904035 X-HE-Meta: U2FsdGVkX1+qWnhQb+lZF0uH0YE9dzctwCcseuKc98wZJvyu631oIJ0Lvtb0cGYR6BOuKtQDdizqavZCl706vsUJ2puggsVKMFbBISO4s+rMDn1MqAhWzbzKySmS3Re+U8fpZbiGRT6C6nCs6l5RYqQpk0EPBATuTHRz4hDIktZECM8LbXr62ze0TlSmISxY6HBFe8HSoHQvOWzLlc5FwMlj+UuAQfb4QW6QEQznH/AYkCTY4M+LwPjaCF6YxJlout1qJrqnYVQnKnQD3wcTcFUM24Pt7Yc3Y0CpgxZ8k/lo9XCb9oHKnxGfrXLFX6MDe+O4P6f8HHBiuu4s3VD6CyABLuTNbYwClDARqx7EA8B+CG+xTWxHauy7wFfH2NwXeiGRtyxQAbpHFVfdToDDHgRc33dEri+sxryrrDpionyB+CwyTMIFMI/Cd8j76k6XeVkZhqqj30id54392BCujr/Xrbq8nZWCo4DYKV6IY1A911LJ/v7josce6ZNuiWuQR/Ezq7mjexmtkJlAKlCp3cVFFW6tOvcaVHqcWDxfiz18fWi/ukH9t5FB3UgITrtcIPDL9HZHGWclwTHpns1ORcVGVROGA/b0UluYRlV/5oWrvn6X5aM1YArKBZzIgbS15iV4S1qB2KT6E5HXHoRj3UPdemC9s1qgllSYCZKIeBtE1i62XelknHLLVx9lxP5g0PLc29IFYI1B/5tVslyeD9B8SrS9tdFsvLj/V1sHlDKLJWRoiSkyLYrmJ7T1BZLOyYOQ8pPTpjoni1+nIT0wXAyceip5e98ALnj7OwxgV6TjarNLo5G5MYd5/0jF58evnUy0zjm3AooVAZmjBFWs/9R2L5nrRfIsICp8HssL2ErII0Dgaoa1kNCPElR1nq3z3GxvjEvopjpzkEK8BHsQZgxYtg5IAPrHwpREDZlNSDGNiiEVvDA66+90uNKhtfk9RB3Bsdg+CjU8qSSEM6n pxr5OCPY 1x8l/1XEMTdI8uNTB4BV2JPT98AgrGKUcH/AvSQmhYwHPaMSlblw/vU9D2U1LXVPMzXhYsu3OuwbTyZWsKyTr8/ymBJxE4expJRXDyf8spI7+nKKQWLcvMvgcu9WSYrf/cMX61idC1Wrzs4W4/6Qy6Dr1jP8pFUxV7/GMvM/M6XxtfdG+B4jUymUUZ3BzYIWntLaZ5enfbnptzG0qjfDe5jSHXrOoifJi78bPYifiB8s6Tx/t7a8jGE7HQCyVVgEcB65wZSk+kWQ2gAH1wzQ6dOZ11u1stu0HMDaSRfLx2CvdO0/pu7L/C2PcZcvU5yFRfODQMCIu1xlcC5PtEE13lYTaM0fnipLktiWpw6IYypByWohkjjHMcDoLzmxvbpa883zB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.08.23 18:23, Stefan Roesch wrote: > With madvise and prctl KSM can be enabled for different VMA's. Once it > is enabled we can query how effective KSM is overall. However we cannot > easily query if an individual VMA benefits from KSM. > > This commit adds a KSM section to the /prod//smaps file. It reports > how many of the pages are KSM pages. The returned value for KSM is > independent of the use of the shared zeropage. > > Here is a typical output: > > 7f420a000000-7f421a000000 rw-p 00000000 00:00 0 > Size: 262144 kB > KernelPageSize: 4 kB > MMUPageSize: 4 kB > Rss: 51212 kB > Pss: 8276 kB > Shared_Clean: 172 kB > Shared_Dirty: 42996 kB > Private_Clean: 196 kB > Private_Dirty: 7848 kB > Referenced: 15388 kB > Anonymous: 51212 kB > KSM: 41376 kB > LazyFree: 0 kB > AnonHugePages: 0 kB > ShmemPmdMapped: 0 kB > FilePmdMapped: 0 kB > Shared_Hugetlb: 0 kB > Private_Hugetlb: 0 kB > Swap: 202016 kB > SwapPss: 3882 kB > Locked: 0 kB > THPeligible: 0 > ProtectionKey: 0 > ksm_state: 0 > ksm_skip_base: 0 > ksm_skip_count: 0 > VmFlags: rd wr mr mw me nr mg anon > > This information also helps with the following workflow: > - First enable KSM for all the VMA's of a process with prctl. > - Then analyze with the above smaps report which VMA's benefit the most > - Change the application (if possible) to add the corresponding madvise > calls for the VMA's that benefit the most > > Signed-off-by: Stefan Roesch > --- > Documentation/filesystems/proc.rst | 4 ++++ > fs/proc/task_mmu.c | 5 +++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 7897a7dafcbc..d5bdfd59f5b0 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -461,6 +461,7 @@ Memory Area, or VMA) there is a series of lines such as the following:: > Private_Dirty: 0 kB > Referenced: 892 kB > Anonymous: 0 kB > + KSM: 0 kB > LazyFree: 0 kB > AnonHugePages: 0 kB > ShmemPmdMapped: 0 kB > @@ -501,6 +502,9 @@ accessed. > a mapping associated with a file may contain anonymous pages: when MAP_PRIVATE > and a page is modified, the file page is replaced by a private anonymous copy. > > +"KSM" shows the amount of anonymous memory that has been de-duplicated. The > +value is independent of the use of shared zeropage. > + > "LazyFree" shows the amount of memory which is marked by madvise(MADV_FREE). > The memory isn't freed immediately with madvise(). It's freed in memory > pressure if the memory is clean. Please note that the printed value might > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 51315133cdc2..f591c750ffda 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -396,6 +396,7 @@ struct mem_size_stats { > unsigned long swap; > unsigned long shared_hugetlb; > unsigned long private_hugetlb; > + unsigned long ksm; > u64 pss; > u64 pss_anon; > u64 pss_file; > @@ -452,6 +453,9 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > mss->lazyfree += size; > } > > + if (PageKsm(page)) > + mss->ksm += size; > + Did you accidentally not include handling of the KSM-shared zeropage? Or did I misinterpret "independent of the use of the shared zeropage." -- Cheers, David / dhildenb