[linux-next:master 7316/11867] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1673 amdgpu_dm_init() error: we previously assumed 'adev->dm.dc' could be null (see line 1669)

[Dan Carpenter <dan.carpenter@linaro.org>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c87d46a9e8ebd2f2c3960927b1d21687096d1109
commit: 9788d087caffd8358d6e14349ee69d9385666719 [7316/11867] drm/amd/display: improve the message printed when loading DC
config: mips-randconfig-m031-20230620 (https://download.01.org/0day-ci/archive/20230622/202306222109.GOpiisJ1-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230622/202306222109.GOpiisJ1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202306222109.GOpiisJ1-lkp@intel.com/

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1673 amdgpu_dm_init() error: we previously assumed 'adev->dm.dc' could be null (see line 1669)

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1905 amdgpu_dm_fini() error: we previously assumed 'adev->dm.dc' could be null (see line 1889)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6079 create_stream_for_sink() error: we previously assumed 'aconnector->dc_sink' could be null (see line 5971)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8708 amdgpu_dm_atomic_commit_tail() error: we previously assumed 'aconnector->dc_link' could be null (see line 8689)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8961 dm_force_atomic_commit() error: 'crtc_state' dereferencing possible ERR_PTR()

vim +1673 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c

0dd79532340568 Zhan Liu            2021-03-08  1662  	INIT_LIST_HEAD(&adev->dm.da_list);
57b9f3384c64e3 Fangzhi Zuo         2022-07-06  1663  
57b9f3384c64e3 Fangzhi Zuo         2022-07-06  1664  	retrieve_dmi_info(&adev->dm);
57b9f3384c64e3 Fangzhi Zuo         2022-07-06  1665  
4562236b3bc0a2 Harry Wentland      2017-09-12  1666  	/* Display Core create. */
4562236b3bc0a2 Harry Wentland      2017-09-12  1667  	adev->dm.dc = dc_create(&init_data);
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Allocation

4562236b3bc0a2 Harry Wentland      2017-09-12  1668  
423788c7a866cb Ernst Sjöstrand     2017-11-07 @1669  	if (adev->dm.dc) {
                                                            ^^^^^^^^^^^
Check for allocation failure


9788d087caffd8 Aurabindo Pillai    2023-05-05  1670  		DRM_INFO("Display Core v%s initialized on %s\n", DC_VER,
bf7fda0b3736f9 Rodrigo Siqueira    2023-04-25  1671  			 dce_version_to_string(adev->dm.dc->ctx->dce_version));
423788c7a866cb Ernst Sjöstrand     2017-11-07  1672  	} else {
9788d087caffd8 Aurabindo Pillai    2023-05-05 @1673  		DRM_INFO("Display Core v%s failed to initialize on %s\n", DC_VER,
9788d087caffd8 Aurabindo Pillai    2023-05-05  1674  			 dce_version_to_string(adev->dm.dc->ctx->dce_version));
                                                                                               ^^^^^^^^^^^^^
NULL pointer dereference

423788c7a866cb Ernst Sjöstrand     2017-11-07  1675  		goto error;
423788c7a866cb Ernst Sjöstrand     2017-11-07  1676  	}
4562236b3bc0a2 Harry Wentland      2017-09-12  1677  
8a791dabea1816 Harry Wentland      2020-05-01  1678  	if (amdgpu_dc_debug_mask & DC_DISABLE_PIPE_SPLIT) {
8a791dabea1816 Harry Wentland      2020-05-01  1679  		adev->dm.dc->debug.force_single_disp_pipe_split = false;
8a791dabea1816 Harry Wentland      2020-05-01  1680  		adev->dm.dc->debug.pipe_split_policy = MPC_SPLIT_AVOID;
8a791dabea1816 Harry Wentland      2020-05-01  1681  	}

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki