From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E86C83F1A for ; Mon, 14 Jul 2025 14:42:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBFA46B00A5; Mon, 14 Jul 2025 10:42:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D97366B00A7; Mon, 14 Jul 2025 10:42:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAC806B00A8; Mon, 14 Jul 2025 10:42:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B74E06B00A5 for ; Mon, 14 Jul 2025 10:42:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 86A95B6FC1 for ; Mon, 14 Jul 2025 14:42:02 +0000 (UTC) X-FDA: 83663134884.06.900173D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 244C440007 for ; Mon, 14 Jul 2025 14:42:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b7M93jM4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752504120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6XSp3g2fAIWlkOffxIKmWmNhMdOSyZK3SoWUfVwFhRE=; b=cxa14sOcEt6PQFE62/tnvEEWcLJnKLK/4VsiFCxMMtUx1K6z/OXpFz3RRhpW9L+M4YxqzC 4MXHvwQ13u81BgOOearOe0KOqsZbgxPs4fwohCqms1s3DerkE/vFEznU20eIUenCKHWl8S l6aI7urRXA0y+cf63NymzxZaabu692g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752504120; a=rsa-sha256; cv=none; b=oF54HKvmu/41Alpt/Nj9ulR69NmSAeGhZ64P040clWBDabSnYSYLmeSqzs8ZEcnJvCUvPt ZZHfkWMK00fOeC3k2q1hFfF1EjBe3q5OnBO07FRLElPlddJHhCPACWK6h40GKZRdWYJLTy qITFByqFYv9n349CpO/hMQfVKCo7Jg8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b7M93jM4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752504119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6XSp3g2fAIWlkOffxIKmWmNhMdOSyZK3SoWUfVwFhRE=; b=b7M93jM4sxvzzx0c3Hnw9j5XMH/Y/qK/bwlsbIIkvwFhuHETZW/4JaGNQZIDFqzHcbF3T8 +MFGrzv8lRwf4kAF20bPta+rwc8sUv4+I0TuzBuZOFZNapWoXB3jnRGUxooWhEpmcSdkTl Qg2+o5OlaGDouVi867Uc85wom+QID/0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-kNITv30pN_Kio7Uh_kW2fg-1; Mon, 14 Jul 2025 10:41:58 -0400 X-MC-Unique: kNITv30pN_Kio7Uh_kW2fg-1 X-Mimecast-MFC-AGG-ID: kNITv30pN_Kio7Uh_kW2fg_1752504117 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4560b81ff9eso13808455e9.1 for ; Mon, 14 Jul 2025 07:41:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752504117; x=1753108917; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6XSp3g2fAIWlkOffxIKmWmNhMdOSyZK3SoWUfVwFhRE=; b=qXvZp5y9P4D4NXUbu1y9eU9zpP/RkPqTtLlr9RAgEA1hfmOrh02YjGo9NkbvPXaqOE OKfuu09YFFifFbbNQ07i0LUDYRBvQyOFSD38JB1q0BkmIKQUErt6jS7qLH4hEGChZAn2 qRAPuXJHP5SpmdOHSSRyzt38Qp8DFTJ19XZWvfuQkmKeLb19o+mdb4FIR3HjMeR+hUnh IDJP6TscVK7VR0oPVqqRcJELoR/MV4D0GzvH9/cU7TJvBs+xtYQhHaUdlgt71r3xWo18 JYzErvWimGKoHO2FFL7+u73bpxPHd9ZIe+HHhSIdJIGYWjwPgrw7DpOyO+ADE7M2NExG UkoQ== X-Forwarded-Encrypted: i=1; AJvYcCXlI5yTzmR+HAWBTh3qd6cbhm7eIhszjlvCul15iW8p6f3acLqXP3OzwcnbI4LnBZSMsAGsBP351g==@kvack.org X-Gm-Message-State: AOJu0YzZHuIY71J+/DeYhmVKC5CgGXUrerejAxxiODnr23SV9cC0wagO AHowe5CZ2mbh0M9A1zFZd2bEQHmxRDL1sNRPQVsN05440lxm8mfwC1I0qDAt/MVL/vOr1NTJHL4 R0lkngt0xruQegDga3idnr5aHl0U0Lp0n8ElR24Ph4bSiS94C3RCb X-Gm-Gg: ASbGncu/3ujZn47Rl0nQru/bYUjxVkvO994E4vmZhGuLIMXk62+qsAyAUeoYQUqh9dm BgmA99rgxIeF4kUOFrs6VIU4KCstpAjh9A3r5V0uQsAwF06hdiTK+ABQyexh4twBXjsaqc7ovW2 eu/95spZHxcgQ/VmQNuL0Bvs7g9RDxNaePFNArjt4dErNN4eILxGa3xF4tLgkGoQNOZK7MvrRL6 IIw4Q7IrF1QdgYf5aQEhgnjXHICWnf8ohv4CUZ/sbc4+fIEy2dMTZypEtmlqV06d8hVbbp9wRGu RZV7RNB8EqXrNrPTGwM7qgqs4Q9ipUdM2vH+fatFwQx2j6+qSF0l5a/QW0PqfV4ROJbyMAzWGHL rVSzAxPfa47NhYg/Lgjky6KqzyNch36c7Dpjck+oCiuC52Eys57+vdT3oMiZJ0z7A X-Received: by 2002:a05:600c:a216:b0:450:d386:1afb with SMTP id 5b1f17b1804b1-45555e4c191mr83447105e9.9.1752504117109; Mon, 14 Jul 2025 07:41:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpAwsbfGFLRxIAqd4lnQYU1wvx/si6+mPOar46wAeNRpM9iaWeamMTKNQf0GzctApu37HEtQ== X-Received: by 2002:a05:600c:a216:b0:450:d386:1afb with SMTP id 5b1f17b1804b1-45555e4c191mr83446895e9.9.1752504116695; Mon, 14 Jul 2025 07:41:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc201asm12455795f8f.22.2025.07.14.07.41.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 07:41:56 -0700 (PDT) Message-ID: <88ad463c-b5a1-431a-9a0e-ed7e39e86c18@redhat.com> Date: Mon, 14 Jul 2025 16:41:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm/mseal: separate out and simplify VMA gap check To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -sBNfCaskE-QvKCr9SQx5jNw9p0proByu7IXb04iuwA_1752504117 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 244C440007 X-Stat-Signature: 5uzf56dmikcwbsbrj6c1put6e1ajnhxm X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752504119-280394 X-HE-Meta: U2FsdGVkX1868AJPl4gZTywTuVX9wlqVukhF5wSdePbnBDT0y0dbsD+t4kWVNtbw0TSwaIkQrwh4kTUVTfdCgekuXR3epaL1kg40MI8SKh6vymGgiuyF1ciw1eKmZDVXXBEJoxY6zCMzBVvbKw2+gWSXudSKDDEedY/n4FbElg2sykFmRPnQyyWVL/XhAbldlrkprNCbRg7ubg9QSmLllrNxojsKSYWaDRKhdvWVL/o8WQ3H8JvbyYD2DLgUjiWp68ruTEZ26toighGPYUg6S3niaWYqDbLLaxnwj+2SIMHnaqguG3engf1iWnAXUJwm3UHq/124Q/NQQahbltUcwAXEHrm2ifaemcsqnOH7FOJTCTfkgKBOj9oAKElv7o5WF0QXB0UqfhwPXDZnwZgCM2XCr2pT+ktVdVgmOM7/gCH6RJdPbWed5gdnZ8tfoMf6D1PTX5yv6HP4+M9mBOuqYKhArKcazVFtjDtsaia8Bmca18KDTRQCOqokpTlkC1oBbS8ZdEV5O8PGKTzFGd4NB7QToT5JlSnjo0vB2ZROVP7WdU7Fsy/rg25Pn9lLu0rruEBP3rIvJieDIcFcFC71J4bLM/K5e6cNfwB9LmYjItiJH3Tn1TYZtL/ob5D9somleK1r0KT7PDQpU0yvMs/nAjhu4jJ4cVMZKLdhJzK1jpOZ7WcBCAFGrAZilVwf/ELpUO9RcSajorEx7DSU9T90jIACV67OzXnM8tlGRB7lXxUiuhG0wDB0uppi7ZJcyDiGMhyNy4wnEqlnjuUBT/VJM6X1nwVFkgQi67nKBMh3SHSNKDuEj2uSO48P9pjLQeQLd9PQbABuC4PBQuSEO8TACPpN/sd0+2OMstqlVPO8OYuwpcwSzk1B03YJeHOvVqLs/24IJ2b+ZWUuYhQfjqE6T7535BfhBGUJZCykly3SFCKYRuRdWybHk891ODI3Z7ZIcfffdFVbvn2mLscpZgq a1ERFjxq IZHY381TeymD452rBK5jB9FlMK98tcgDgcARUtuKqPHGEgSRx6sVEojYTTlRdbI+SOs8tJaX3c0n1f2eYv6cKqQBQ31UN5pwwx5pAmzF9GG7a2rYXFun4u5baM3Qj0obULwLgL/MqclHjjhZThcjosiyDV/E93ENoi7bgQDhkUaz+MfgULoOlhVYCulJoAcLH9h6ZTd/u7fVPQOqEPgMdz7PskDhIglT31e29jWCiPj7xS9IQez1+UO1YWahqIPC9YxEj0YILBi5Mw77n1o5044utf0MB69REVBnLD5tkuUAB5M8A0fNvs1LdoJeMqylYeDXGbOnvXW1444urWhCipwDyNhu2vCU6+bpYvqjXknLdVqiu6EtrmizYno1cQR++MNElSdXCqlqZRA24mQMKy6s3MIGHRO2pv85d9stlM/cjadtcyfTClM2pAUMccHR2wJt5uVhLGTPbZKXxxssSlZwQRaybNMQ/iYII0XJaMPp1gLqTBHLUALY8NQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 15:00, Lorenzo Stoakes wrote: > The check_mm_seal() function is doing something general - checking whether > a range contains only VMAs (or rather that it does NOT contain any unmapped > regions). > > Generalise this and put the logic in mm/vma.c - introducing > range_contains_unmapped(). Additionally we can simplify the logic, we are > simply checking whether the last vma->vm_end has either a VMA starting > after it or ends before the end parameter. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb