public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
	Usama Arif <usama.arif@linux.dev>,
	Oscar Salvador <osalvador@suse.de>,
	Miaohe Lin <linmiaohe@huawei.com>,
	Muchun Song <songmuchun@bytedance.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ying Huang <huang.ying.caritas@gmail.com>,
	Dan Williams <djbw@kernel.org>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>,
	linux-mm@kvack.org, linux-cxl@vger.kernel.org,
	driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rafael J Wysocki <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 3/3] drivers/base/memory: fix locking for poison accounting lookup
Date: Fri, 1 May 2026 10:55:06 +0800	[thread overview]
Message-ID: <89000C13-1AAD-489A-B70F-73ED909EF4DD@linux.dev> (raw)
In-Reply-To: <20260430085058.f566bdc2aa5c19a54936da30@linux-foundation.org>



> On Apr 30, 2026, at 23:50, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Thu, 30 Apr 2026 15:59:33 +0800 Muchun Song <muchun.song@linux.dev> wrote:
> 
>>>> Lockdep would flag this as sleeping while atomic when acquiring mutex I think.
>>> 
>>> Another thought would be, that we always call the inc/sub from memory failure
>>> code while we hold a folio reference and the page is not poisoned yet.
>>> 
>>> That way, memory offlining cannot continue and the memory block cannot go away.
>>> 
>>> So we'd let out page reference keep the memory block alive.
>> 
>> It seems unnecessary to hold lock_device_hotplug if the user already holds a
>> refcount on the page. I'd like to drop this patch.
> 
> Dropped, thanks.

Thank you so much for helping me with this.

Thanks,
Muchun.

> 
> mm-hotfixes-unstable still has
> 
> "mm/memory_hotplug: fix memory block reference leak on remove"
> and
> "drivers/base/memory: fix memory block reference leak in poison accounting"



  reply	other threads:[~2026-05-01  2:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 13:52 [PATCH v2 3/3] drivers/base/memory: fix locking for poison accounting lookup Muchun Song
2026-04-29  3:08 ` Miaohe Lin
2026-04-29  3:32   ` Oscar Salvador
2026-04-29  4:18     ` Muchun Song
2026-04-29 10:11       ` Usama Arif
2026-04-29 10:44         ` David Hildenbrand (Arm)
2026-04-30  7:59           ` Muchun Song
2026-04-30 15:50             ` Andrew Morton
2026-05-01  2:55               ` Muchun Song [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-28  8:52 [PATCH v2 0/3] mm: Fix memory block leaks and locking Muchun Song
2026-04-28  8:52 ` [PATCH v2 3/3] drivers/base/memory: fix locking for poison accounting lookup Muchun Song
2026-04-28  9:17   ` Oscar Salvador
2026-04-28  9:21     ` Muchun Song
2026-04-28 11:37   ` Miaohe Lin
2026-04-28 11:40     ` Muchun Song
2026-04-28 12:34       ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89000C13-1AAD-489A-B70F-73ED909EF4DD@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=dakr@kernel.org \
    --cc=david@kernel.org \
    --cc=djbw@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=huang.ying.caritas@gmail.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nao.horiguchi@gmail.com \
    --cc=osalvador@suse.de \
    --cc=rafael@kernel.org \
    --cc=songmuchun@bytedance.com \
    --cc=stable@vger.kernel.org \
    --cc=usama.arif@linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox