From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EC9C3DA59 for ; Fri, 19 Jul 2024 16:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E31736B0096; Fri, 19 Jul 2024 12:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE2A36B0098; Fri, 19 Jul 2024 12:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C34846B0099; Fri, 19 Jul 2024 12:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A095A6B0096 for ; Fri, 19 Jul 2024 12:07:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 608AA1407FB for ; Fri, 19 Jul 2024 16:07:42 +0000 (UTC) X-FDA: 82356982764.18.B19172F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id DFF9A20007 for ; Fri, 19 Jul 2024 16:07:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WgVL0ES9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721405225; a=rsa-sha256; cv=none; b=ZB79cv6AIw50oIuZKV5msVXiMcOZj4vJ/Ek+SnojoO0t3ZtNgzQksdcs/1Kh/NyE2q4Ul/ YJGZR7hj1/lpXmtav6MIqzRsXfLuViTPmpTFERau55+NF9jqoCk5n4eWv4zOzXEKuT53mB UOON/N+wadiQ+vIOioKRdo4S4siEaGA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WgVL0ES9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721405225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pZli1ZWS65IADc0MuGEmad+VYY75q1/RVf/I8f/0nkc=; b=5r5pSL8kkEAlCdCJA42wicQub+EtEXXIoSZrCLz0poiPQ/b/fk+Eb17jajO8RhtMQZrUb7 d95rRu4nJ4X9E8FD1yedRRedCUApLKcPOZHtWlXenUynuYNICx9zk9lILuXdkAbf4XOm+H fOyGdq4wjV405PKJd76xxwBAhEDhnh4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721405259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pZli1ZWS65IADc0MuGEmad+VYY75q1/RVf/I8f/0nkc=; b=WgVL0ES9Q6sFg+Jrh8Q0OpQukGh7M9D+Emwq7TyvrrIcy0B0a08H3Eu4h7HRQhdT/lrgYx rXmTSAEzMDS+im4sLoGJitMTDldWZfmy0KiXa8J0U8UP/JonBZIT4z8S+MGHqkOZcMfKHG 7HsqnHVPL+3tliC+PLHmM6lbQ4Dubqg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-Pw8pyNSLO0Kk5Nlg_aqrcg-1; Fri, 19 Jul 2024 12:07:37 -0400 X-MC-Unique: Pw8pyNSLO0Kk5Nlg_aqrcg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-36873ed688dso719790f8f.1 for ; Fri, 19 Jul 2024 09:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721405256; x=1722010056; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pZli1ZWS65IADc0MuGEmad+VYY75q1/RVf/I8f/0nkc=; b=BRxS5L8cwAksGWBUGbNY2kJIg1folD37eZ85Yv57sfYrdj6rZH3eNxiD3nlFmyEq6Q 4Bk7ByS11q7kYaCe942EDCAyb4DMoyfKjMC7fr19CJ2xif7EQJMGd+yRleSx84N/R5BE 26FgaxN51yY68ZEeovhyRkHIPuAWXDYXvD5r7oo65gjVlqXm1cjYJajrcZfpJxMPWgs0 Omy532QAJi6o6f6z0fxH30yCgs29gTZcpiFwHZMOg67Ff08u8LJ7n8p6p/31rnJOnTI0 ggHGX9diNFD6J5ql+247R8M9C/fvRcir2jRyXnKl8CnxLzV9XQlUiroxHHbuQ22s8Yy9 ZPdw== X-Forwarded-Encrypted: i=1; AJvYcCUkisH0LMTb5jrRX3qkEscc3KhV3Mo1+80MNKRPKN0Z9XPbX7KMUZztZeVpS16zAb0IUeCCbphZ3Joijc//5OWx6BQ= X-Gm-Message-State: AOJu0Yway1f1q3KKt1xN8ebvyX23ep5cXUtIWUkjlAIE7+Wmx4SpMnQS 3/g0ibZithE7rWuoJZpxIoLUD9YRgpfjj/xgHGYt4QFgPEvpxXEa4cZ48oXS76zw559/ivgq03m tnlaUG2MDlGRftxH3HFMMLeIgUMr6XhnpSnPW7dELrDm7AHJP X-Received: by 2002:a05:6000:1f8a:b0:368:3f6a:1de8 with SMTP id ffacd0b85a97d-3683f6a1fd3mr6197217f8f.11.1721405256420; Fri, 19 Jul 2024 09:07:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7LRUztVUaQBN7s/nxE6MGqv+dWgvzusQE14jyzDq7GxIcTp7Je/ha3vehB6s5hU+vze0vHQ== X-Received: by 2002:a05:6000:1f8a:b0:368:3f6a:1de8 with SMTP id ffacd0b85a97d-3683f6a1fd3mr6197181f8f.11.1721405255968; Fri, 19 Jul 2024 09:07:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:1000:c4af:a24f:b8ba:8bbc? (p200300cbc7051000c4afa24fb8ba8bbc.dip0.t-ipconnect.de. [2003:cb:c705:1000:c4af:a24f:b8ba:8bbc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3687868bc2csm1983265f8f.47.2024.07.19.09.07.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jul 2024 09:07:35 -0700 (PDT) Message-ID: <892d0dab-f9db-481c-a3f6-ac3e2bda9b6e@redhat.com> Date: Fri, 19 Jul 2024 18:07:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/17] arch, mm: pull out allocation of NODE_DATA to generic code To: Jonathan Cameron Cc: Mike Rapoport , linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , "David S. Miller" , Greg Kroah-Hartman , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , John Paul Adrian Glaubitz , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20240716111346.3676969-1-rppt@kernel.org> <20240716111346.3676969-6-rppt@kernel.org> <220da8ed-337a-4b1e-badf-2bff1d36e6c3@redhat.com> <96850252-a49f-4d78-a94b-a9a25e3f2bd5@redhat.com> <20240719165143.0000002e@Huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240719165143.0000002e@Huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DFF9A20007 X-Stat-Signature: rd4pm11hgwfahatcqqbjkij7uk7pxwr4 X-Rspam-User: X-HE-Tag: 1721405259-464564 X-HE-Meta: U2FsdGVkX18+8lUzGuJ77VpjzGb/RPHBVxwCVSq9MDE+CJvfRQbWqg1H0ErZ6EbE/WZTawVi75Euuc8h/bSflb34I+hgMoy9n7BHwbhR1tXVQQAkWMiZYYc5O+iFyTTvAQH8ZJXOwz+9eTVlz9srIvrGumTQU6iDqOmU7iMpkU/2RkrmvDvJL1Ag6W2Dv/QdsKrYr/6XqNmp81BB9aovGT4PEG1YTUxHokqu4zG85cyS7c/D2rB8J9uKEzbjd91Lxj9gQgfWW0XWRlTzx4yr4ZlZuAOuiuj8JxH8abi6q7jZYlRcH2K393AoQ5h5zwJd/N2T2f8xUos4yn++bFQ7Dk1BPSyqy7XCmzQaHeKk7Mf6J+pxQYcuAyesGQZXxDa6EcmSaXgPRDbGuDZcEpJJm6/PFAmjKsyvcyuRaHI6i3ZbU1wH4iHJpBtDZVSFl1lf5p3emuYnBxOhs5/Z8iq1PCzP2M4QqCKDMU2Ujom/XJIX4F3uyMGupxhRA5JGPnnkVTvqyPnJChadxMfG94DzAyNfgCXv9/4vbwQg/r6EEWROfVHzTUHHKdsx0slLzWZdi9E5g9ToYCMP+IwsLz7zqPh+0Uak03mQateZAFq8DdwTUSjC3dIV5DrxFKzEvpPDaWiLIwvop2rMoK088QIKdfViCQHoPbFLDQDrCGAvOEHfvR4TTyegI9ZGkSgdFsQvfHWITKuSxz1iJd+UEs9vQDnmreQUi7oafTJS715d0yu59iN4HZ2CiL5qQS4LUWJ6jCHh6qLv8511OAO8UZVA8ej75T2SE6xMIOujTTkJOSsnKF4IbvpWK3LJ2Z2j3C7hjrWz9FERL4QOv4xo4Ua0fZ5eTmVocov1301833iAqp2suK3ZrPJGWdFv+lUBAAw5vHejGEWIOZHlW6TpVY5aJ7k0btqwqbujxOoh1i/9kz75Vz5yytmZAamA7sICb2b5rYrSFaE3FrbO4FSsGYx OekXvasC YoW0ELuktDeu9b7un/IGJrlIu0IjGTsLfyVb6FI9ZXqOpXjA4GEYOfIuTygQ71x+J3Umc/NS0Dzxk37HQJ1YwYcnOIVrH+h8OhvbnKqXGDbFNopcpcaP+/m59l5gZUNGSZRpQGZ3KX/LlD2xRl7RdyQH0EorFa5QsmWO8Wo9jtBW6mBctvvRRgBZE/jCv7SjdjmjQ+XSh1ms9dFBPCopkaxUyg8+dCAFShwDJI8GWZgcutucoASO7+jrtv2fOgFawojo2ooA4DRKTxRDeZhne2QpSZxt+gLhZO3b/bRerf1GrhQsQdmrCV6GD3iYPAAoO3oGjrCHYLlkW9zafTN4dSmbjPocbQfuYyOwfbkkYmSoMbujZ0xw4QkiHZlpS16IGU1qYZpXXbJHZsNAoZi9MJq95ajW6VREMldpoFF3HUtccu2NV3S8lcP9hWIb1pOR2cczT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.07.24 17:51, Jonathan Cameron wrote: > On Fri, 19 Jul 2024 17:07:35 +0200 > David Hildenbrand wrote: > >>>>> - * Allocate node data. Try node-local memory and then any node. >>>>> - * Never allocate in DMA zone. >>>>> - */ >>>>> - nd_pa = memblock_phys_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid); >>>>> - if (!nd_pa) { >>>>> - pr_err("Cannot find %zu bytes in any node (initial node: %d)\n", >>>>> - nd_size, nid); >>>>> - return; >>>>> - } >>>>> - nd = __va(nd_pa); >>>>> - >>>>> - /* report and initialize */ >>>>> - printk(KERN_INFO "NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, >>>>> - nd_pa, nd_pa + nd_size - 1); >>>>> - tnid = early_pfn_to_nid(nd_pa >> PAGE_SHIFT); >>>>> - if (tnid != nid) >>>>> - printk(KERN_INFO " NODE_DATA(%d) on node %d\n", nid, tnid); >>>>> - >>>>> - node_data[nid] = nd; >>>>> - memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); >>>>> - >>>>> - node_set_online(nid); >>>>> -} >>>>> - >>>>> /** >>>>> * numa_cleanup_meminfo - Cleanup a numa_meminfo >>>>> * @mi: numa_meminfo to clean up >>>>> @@ -571,6 +538,7 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) >>>>> continue; >>>>> alloc_node_data(nid); >>>>> + node_set_online(nid); >>>>> } >>>> >>>> I can spot that we only remove a single node_set_online() call from x86. >>>> >>>> What about all the other architectures? Will there be any change in behavior >>>> for them? Or do we simply set the nodes online later once more? >>> >>> On x86 node_set_online() was a part of alloc_node_data() and I moved it >>> outside so it's called right after alloc_node_data(). On other >>> architectures the allocation didn't include that call, so there should be >>> no difference there. >> >> But won't their arch code try setting the nodes online at a later stage? >> >> And I think, some architectures only set nodes online conditionally >> (see most other node_set_online() calls). >> >> Sorry if I'm confused here, but with now unconditional node_set_online(), won't >> we change the behavior of other architectures? > This is moving x86 code to x86 code, not a generic location > so how would that affect anyone else? Their onlining should be same as > before. Yes, see my reply to Mike. > > The node onlining difference are a pain (I recall that fun from adding > generic initiators) as different ordering on x86 and arm64 at least. That's part of the reason I was confused, because I remember some nasty inconsistency. -- Cheers, David / dhildenb