From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CC2C05027 for ; Mon, 23 Jan 2023 11:35:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AB306B0071; Mon, 23 Jan 2023 06:35:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45AED6B0072; Mon, 23 Jan 2023 06:35:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FBCF6B0073; Mon, 23 Jan 2023 06:35:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 201606B0071 for ; Mon, 23 Jan 2023 06:35:35 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2C641407F3 for ; Mon, 23 Jan 2023 11:35:34 +0000 (UTC) X-FDA: 80385858588.19.C86D2DC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id AB61180015 for ; Mon, 23 Jan 2023 11:35:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R5DcTeMJ; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674473732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uGbVjPtu+E1JSO9tMUFJgzGCgcDNOCsCSqr9bxZnMBc=; b=FKYhmfJd5Vlh0BNEm9XsZnPmzmGvMUgZqMxc/fsGwJajys87BaD13ZwEaIYzb39p5lv3b1 BqxQSqY4umvjgm0HEjZh5Xp3benQOAEBgDQ7kK93Hc+iwwJgXvqe+uTGMhfmoLMgjrPiAH IzZlnRXNtPNcJSigea1Uu4kqowh7kQ8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R5DcTeMJ; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674473732; a=rsa-sha256; cv=none; b=zPzGH5Wh2ofC29dy7z8L7xUS6guG1YhEgdMeUDM3EoA2i0V+QcRJe2yP24RWGV7THYDdJN N2OvYmV8b8edNfZFYahdFAwWA3I2/4U2H10NlwjkptB6JiIHLhZJerUAE1csmr6bTgr8y4 4+Ydu5K+3UbFBHY69Go8BbUWO8UBWpA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674473732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uGbVjPtu+E1JSO9tMUFJgzGCgcDNOCsCSqr9bxZnMBc=; b=R5DcTeMJG2DjZM6Kbw6DCM9Hx/llDoBJrMtH9gfonchkTHaUot+C6zVbW06LBq5ALYxpH0 UhJbqEhW4ciIg0lKFA8swgKB/DuzLSHGdCtmXZLU78ub5LHBqCe+cFqePlTlA4U/RQfmZ4 jS5optuqY/1cSbuynVrfZU41yRmnpY4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-647-UaFvDoS4PriguyUxkT9o9w-1; Mon, 23 Jan 2023 06:35:31 -0500 X-MC-Unique: UaFvDoS4PriguyUxkT9o9w-1 Received: by mail-wm1-f70.google.com with SMTP id q19-20020a1cf313000000b003d96c95e2f9so2748270wmq.2 for ; Mon, 23 Jan 2023 03:35:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uGbVjPtu+E1JSO9tMUFJgzGCgcDNOCsCSqr9bxZnMBc=; b=zpH6lPSO3xhpxjfavcQAdsgN21kmEZrYrPplTN+NssUDhvQKtdifH3nvP+vV+ZecWR NGnr1P5ne43iYqkg94J2zbt1VxedfvonWcoIi/qA96x/9jPk5iBJ1I6a6zE/tC0o3kJO cMN9U1LHgS5gohGr51vAqZfR+ZzVkSXxwF9804xrr9fPLYF27iGE9s0F86nBklxEgby8 of0DvTVXiErxHDlGy9yogDmNHvm4tTS59iAuLDmuEuUVxZSB3vfFQZbGmfyvBta1Ot4Q +cMTuWgVBL8rb+9VJOxxVk6m1ZkUM2+qIRXmwHqVk3UPUKT1q+jqYe25hTUc7JyzQi9E CDKg== X-Gm-Message-State: AFqh2kqR2Jc0OebBvPTp0ymMuz/1trBmZ/ZUSwOnz51sbZhZkpQCMuNf q8FSU2JkVBAoxSQV8nRt8yksRBbBHaDeNVP0VcpZkwpxevROxZ1bDaxP4UURY1hUytgVeJ8FCMg sFZvsUcXFvLI= X-Received: by 2002:a05:600c:c8d:b0:3da:fcee:2ef1 with SMTP id fj13-20020a05600c0c8d00b003dafcee2ef1mr23522533wmb.32.1674473729895; Mon, 23 Jan 2023 03:35:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXvYgBar6t3WXbLqE/KGBsbytKqC7ePiuT5ZNv+dcOTnGyz9xmncdQRGUEvfypQpzlO1FVKVWQ== X-Received: by 2002:a05:600c:c8d:b0:3da:fcee:2ef1 with SMTP id fj13-20020a05600c0c8d00b003dafcee2ef1mr23522517wmb.32.1674473729629; Mon, 23 Jan 2023 03:35:29 -0800 (PST) Received: from ?IPV6:2003:cb:c704:1100:65a0:c03a:142a:f914? (p200300cbc704110065a0c03a142af914.dip0.t-ipconnect.de. [2003:cb:c704:1100:65a0:c03a:142a:f914]) by smtp.gmail.com with ESMTPSA id j25-20020a05600c1c1900b003c71358a42dsm14456615wms.18.2023.01.23.03.35.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 03:35:29 -0800 (PST) Message-ID: <89c98586-8d38-7f30-1e7d-21a5f9ce7c89@redhat.com> Date: Mon, 23 Jan 2023 12:35:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 6/8] mm/gup: make locked never NULL in the internal GUP functions To: Jason Gunthorpe Cc: Alistair Popple , John Hubbard , linux-mm@kvack.org References: <6-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <6-v1-dd94f8f0d5ad+716-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AB61180015 X-Rspam-User: X-Stat-Signature: o4ok5ye96yf4shqyh34cewqmhh3mwdsq X-HE-Tag: 1674473732-940294 X-HE-Meta: U2FsdGVkX18a9PqYEwD+2Vommjl4bTus8IV5TCzioAILzh1kHICJydS/I5NHm27Gy/d1alHHPiqwKX4qJd0nHcu8YuS6GwVwLqQgsPI7O4VQq27tZuiMP7y4UbJhdDFw2+oKd3BQ6zSR54Ut8SHwP/vytxsjNVk9j/4HZ0czXK7cXMj/zSlHvVl+wvyiGdbyq+OdjUQaeRdaVJInnQ6wipv5asCEWgQ+z6d9JReT/z5tvWjNboCWLcfy8PJqRqjHJ8r68bsprBF7GuM0XIJbl80cYU+n51JyjipzVVEKpVFhy1yt944MYW0qkiB9sF3838T7v26SPYKivaMYW/kiRcFH92x8wQkM+CqHsrLZvzZn4d0Zj+iIhsgKDY8Qbg/x4j8ti58b0XwaiFVQ/tBSXaToEvb3gQ3CllpX/A6gers4x5wBAmiJiYBCXo63Qp2B9z/oQqCmvcqK2iPV0yjJnIaZfYkQvgGqDdOL4YJalX00l/MfANLWeEmeKgmgf9HpmGhwuRo+OYtJpd0e7VQZ4dlXdB3H2dk9BxY4xDqRa95vwJjpxqnskZkDjeK/tESm7x5IY4sVSZriuTlCylMQsu5RbZwxu0gv2WWwhw44tyFckBSt4CjZSYBWrbSlHE+1hLTDqNvCJHvD2+9qBrBgv/71g7H7HVOnWk87Jh9DXvYQYKUYt5wuFnEdyAsvNwtcKB5z6iqMhI0JsmdhWs2eYd3AwKUQlJ9R8fN7hxXPqdrej1EYuVhAYuBHTk/k8UpBPVTIHgQ26lvyrivnSlln3UIP8Q1FmZ4Cx1p7Ht34w8EuE+Y9rlB99Me1iuT/YOHGyFfmb3wzqXcFSPt3/B2ztX4mne3yB3ByUzm/U9SesfA0iw5OnXC4x6V0jwL2r1jSLrKowz1L0G9Lxd4f9tbAnv/C9fnMAGvk+m9Bi4bgU1Qt5cAysp0nuSwqrhg2Y+VLSU98RpwDH2n+sDcIb81 Ru8XMzGR HWkYs94xkHu5tdaBEQ/Qpa49w5LCgVX0JYgedsEuKHvBBZuzDcjGJCxay4qrFV16RRcmxacxSwveix0QSnK8z0E0pO682hUlzVoODR9ckQdUqZOL5ho936f0uX3fhc0YxAsyZoMeyff5KOT/9teN27Yto8T1Mlg5baeEMpOmiSWC6OkySNxKLKMS3cm4g/9Ev9wVLjzFqCSGEX49DCvnvF+v7vQdGbSYlvu0ZKry29l27IZ7sjdLA7ucSwq8fMGUlYIYhiVMShajXLymGFyn10b+s3ZVvG0vVXCKObTMR26I2tAGMfhYWtxMw2XdDnpJDt0FVIRmzhw4A5GvZ/ZtpcrtIO0m9jIoCZZ+8DwnFr/mzWvEwpO+qf0FDeKZyTmd1j5RUhTGq0ZPA5chsyqbEDiZ2lsai39b5aJB2lcAcDGiFiKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000120, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.01.23 16:58, Jason Gunthorpe wrote: > Now that NULL locked doesn't have a special meaning we can just make it > non-NULL in all cases and remove the special tests. > > get_user_pages() and pin_user_pages() can safely pass in a locked = 1 > > get_user_pages_remote) and pin_user_pages_remote() can swap in a local > variable for locked if NULL is passed. > > Remove all the NULL checks. > > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 30 ++++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) ... doesn't really look like a real cleanup. Especially with the 2 files changed, 20 insertions(+), 12 deletions(-) on the previous patch and a new internal flag .... What's the benefit? -- Thanks, David / dhildenb