From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A68FEB64D0 for ; Tue, 13 Jun 2023 17:00:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C7016B0072; Tue, 13 Jun 2023 13:00:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8770B6B0074; Tue, 13 Jun 2023 13:00:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73EFA8E0002; Tue, 13 Jun 2023 13:00:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 67D3F6B0072 for ; Tue, 13 Jun 2023 13:00:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0CDDA40551 for ; Tue, 13 Jun 2023 17:00:35 +0000 (UTC) X-FDA: 80898338430.18.BA23B6C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 068D218000B for ; Tue, 13 Jun 2023 17:00:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M+j14/6V"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686675631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N+LdwBzt0uYokh007O/q+HMXZaTU5MnHMEEMsHFG/3Y=; b=0j3MYGvrg5Y5TZbPUfkqCzzwDGHZ91E+Nqis48zgfE1TeEubHUBheQfVed1bTN8qqdbpN7 gnkPe8WEX27konZUSuCQkBXlxFlFk5MCWJO6kt/Kg+NcOqzArb2gWgpb8/McHKkB7aZQBv MBuGp32x5GgeAc1EO/F0fsI6JPch4cE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="M+j14/6V"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686675631; a=rsa-sha256; cv=none; b=qZ0BG04ocECIbLFMBRcwJlTtq3XciapLf3LFMCzzRmpmyc9G9RCQz3oiemtwtiK0t9krYT QBQ6wZtrMico39IQjasD5uJ9F/3tWaEdu5HQWlNVtu4EJfTONJdVo1eD6Of3YLSTD/poar hsKRCAMhMTv3rgY3FkGoF6OQ92lFV90= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686675630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N+LdwBzt0uYokh007O/q+HMXZaTU5MnHMEEMsHFG/3Y=; b=M+j14/6VBIpXPZiP13iE7iX/oJH0zKNrLMjfX0M2SqfvMMeg7C/lETA4ZDqE98+AINQmuL G7zWYvQUNMj/f4nYqFJdKuvwSqkDhmoYDl5yJF+4p/ZqOVK9RApKKGDXjDWFfvHVGj+L91 y8vFpnpm1LcUqBxBh9Jsb+58vPEs0MI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-55d2P9zvPpK_vfMa1yd9fw-1; Tue, 13 Jun 2023 13:00:28 -0400 X-MC-Unique: 55d2P9zvPpK_vfMa1yd9fw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f7e64e1157so37140115e9.0 for ; Tue, 13 Jun 2023 10:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686675621; x=1689267621; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N+LdwBzt0uYokh007O/q+HMXZaTU5MnHMEEMsHFG/3Y=; b=TSp5hsP4EPt/Ek3UDZ4p34TpV1xiS7A4XL3mmsBWbxPFa36Zyba5TS3QPul2Y/dRVZ DfJmEtYPOcATii0WyOp/BlmOr/+A5a34pwsAlOem9YotsL5P9CBJJ2w0JBV/OifVV5fH 7GIQ3J9eqYt+XQJKgK9XCGvCST1jmJ16htvkYu2AQy0HN6ARtI68dedK6rjACfgVX75n tYPcoN4iRS5LKnpq9GYcltQL0zKviVSMI3EoinOlag6ry8H9cmY1k8zdIJoRne+AfmFp bzoCDyABW9hs4v7mdrhFbjY17ykOB1yEum+oKqmglhrztHid7yZP7lKYgviFyNeaTUeh 6ZsA== X-Gm-Message-State: AC+VfDyQl9Wq/IBfQITMQIhe8EL/zA1K3W3SDl8adqqwuv1KZLW3COfC 18tBaCPNPLRNCNi4lSA4a6ZSroB56dcxcEN7KP86SjSbWkH2F2eB5SHngYpGatOpwCI0QlrzPp7 leJ2UUuQlhvc= X-Received: by 2002:a05:600c:2041:b0:3f8:d0e7:daed with SMTP id p1-20020a05600c204100b003f8d0e7daedmr1651725wmg.19.1686675620857; Tue, 13 Jun 2023 10:00:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5DqYDEwXY1aS+T8oevGZM1GGzvu3C6CrpD97OsPgkk4IOclN0QORetIFLX25l+OyKcdC2cGA== X-Received: by 2002:a05:600c:2041:b0:3f8:d0e7:daed with SMTP id p1-20020a05600c204100b003f8d0e7daedmr1651659wmg.19.1686675620442; Tue, 13 Jun 2023 10:00:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c710:ff00:1a06:80f:733a:e8c6? (p200300cbc710ff001a06080f733ae8c6.dip0.t-ipconnect.de. [2003:cb:c710:ff00:1a06:80f:733a:e8c6]) by smtp.gmail.com with ESMTPSA id d17-20020adffbd1000000b0030fb4b55c13sm9792662wrs.96.2023.06.13.10.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 10:00:19 -0700 (PDT) Message-ID: <8a053da2-0f26-82ca-f437-9b9de11d4584@redhat.com> Date: Tue, 13 Jun 2023 19:00:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 02/42] mm: Move pte/pmd_mkwrite() callers with no VMA to _novma() To: "Edgecombe, Rick P" , "rppt@kernel.org" Cc: "akpm@linux-foundation.org" , "tglx@linutronix.de" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "Lutomirski, Andy" , "nadav.amit@gmail.com" , "kirill.shutemov@linux.intel.com" , "Schimpe, Christina" , "linux-s390@vger.kernel.org" , "Torvalds, Linus" , "peterz@infradead.org" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "jannh@google.com" , "dethoma@microsoft.com" , "broonie@kernel.org" , "mike.kravetz@oracle.com" , "pavel@ucw.cz" , "bp@alien8.de" , "rdunlap@infradead.org" , "linux-api@vger.kernel.org" , "john.allen@amd.com" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "bsingharora@gmail.com" , "x86@kernel.org" , "oleg@redhat.com" , "fweimer@redhat.com" , "keescook@chromium.org" , "gorcunov@gmail.com" , "andrew.cooper3@citrix.com" , "xen-devel@lists.xenproject.org" , "hpa@zytor.com" , "mingo@redhat.com" , "szabolcs.nagy@arm.com" , "hjl.tools@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "debug@rivosinc.com" , "linux-mm@kvack.org" , "Syromiatnikov, Eugene" , "Yang, Weijiang" , "linux-doc@vger.kernel.org" , "dave.hansen@linux.intel.com" , "Eranian, Stephane" References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-3-rick.p.edgecombe@intel.com> <20230613074428.GS52412@kernel.org> <21b0342854b067c241206f422bc5b3254b43c7f5.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <21b0342854b067c241206f422bc5b3254b43c7f5.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 068D218000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: u3xfkuja5qb7frqq8trnqmut5odr6knq X-HE-Tag: 1686675630-292729 X-HE-Meta: U2FsdGVkX1/W94A1EiAkqkXddgdNRyq2roC1x4iwoNrI1QMAJNIrVGHo3zr9lmwwJKnoCHWKyVC3zx0dxi5Fy6ThQhBoSoBwBFKD9yU6i1tKiSfCQlatjZg2/fyq7ZuShLgCBpqpUrAyyIMIIu0Aca+bm8VWX7fJq/XoacCYtEpejxmjYv0X8DS46Cw9ZtRTpeMnIopry2FdUObqOX+2WCNfHpFXQBfVnshvWMyoWWhVt9dyqf/sOOILD+U4VTzgRSkX7fOmqWRCVp94qoP+VqXYu4elCRBHTKfXX9R2aKPqwXuZWDUCxKRT2/ZFHNnflzxJyvqcwCCPogx1m/bq0lLP8a/bFNlu+hhfrwGXFU9qEf3sRWfa0+keVqpJA/U8xIkZyOz5rjF7yIjbVvDbPn0SMCvdBi+Lt61aZW3Z+7Jx3WC/hyD1NygQN2YXxEQ4NxPcngCBSUVSwqVeracwRzW2VbDboXMz7mwixLIuZFZ5C+XmvrDTA2rhnxPp9DLe/mB0EILDlNVetZf9UOwVen/v2h3vx8ViWzKqSJSA12qKP1GsS+Jmmr0CAtC7dF6bIYuG2zxVWmFZENhxK0qsd7oCDB8ulU6gwKkGRl6QUoZTQyMv3CkEvZjYukw2AyR5OIyS6x3SOhDbrjxTN/NvGrUJIzNcM1TRcBpOhNHS+2qkWQYALtJwqor5UpOEL1w8RrA3CefoGB7MuQDWZQBKdv0UJpQOxyKGln8Q5ADaEXgJv82Z282DeQCX3Khy/F4OWE/V30i7eJ034y6sZnozv1dBZoABB0z/BxMHJW3PnRzastHHYjRCdT5xC8J8HNsieiXr4IYoyNE6OmhIib+7/Ngwb1t4RFu6KRidmIaMq3msuAgQNAUw9RtrKxxCORTcw3gWJ2DenmMVN+QVZ+XvRGF+b4bZ9IjGZ5qgM8AQzKUWfi3TQxY7NKzj+7JFaLts9y0vUH4E9jINkWKmbuy 8sBNh6rE mNoReJVv2f/nG8yn3gUCW8VSyitsAfnTCVDOkEjz+IL74p6ENPu35acJatIznhzIUpR95UjuMAtQK+kgKU9ncIte2Tt82oWx8lnqUMA55uMtjYsNUJ7dIwSDqvrSfYFtSoW1RUpuxgQfpSd4KRZVso9nprGhPlFt18gULbVpSfXy5bxWFZWo8LxYXcx10S6eEWoEGa8YBV+PEJF/irM0aQ6jjuiGoaTaukQRo87TSTJvTIz+lxKSdyysXoj6Pn7dDNGDTb7tKi7jzFJNgH7bwGawIpvTg8Bjv/A/Z9PpbKFp4xzSNNuQgwFqoFaIDPRB/CvRDqhMrgVuuQ2qMmIb6AFB/cpMiaZRzTbSrj42pDIs67S8HPzm1fCPWqRS6r42vi9kx98y88/xlVwwoJsINb6NgxU8zIQu/eQ3i9Jn00/80gVGpyY9bj6VN8SYkUXdBDMyzaxNCyNL2d7ElXB+V7fG4tp2Ye1Nj87dHL15ybqxs6rR/MQFCEffnXvu0MachM+xNdT9UqmIaRkg2Wi5yx5G74OSZF+WyrDhW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 18:19, Edgecombe, Rick P wrote: > On Tue, 2023-06-13 at 10:44 +0300, Mike Rapoport wrote: >>> Previous patches have done the first step, so next move the callers >>> that >>> don't have a VMA to pte_mkwrite_novma(). Also do the same for >> >> I hear x86 maintainers asking to drop "previous patches" ;-) >> >> Maybe >> This is the second step of the conversion that moves the callers ... > > Really? I've not heard that. Just a strong aversion to "this patch". > I've got feedback to say "previous patches" and not "the last patch" so > it doesn't get stale. I guess it could be "previous changes". Talking about patches make sense when discussing literal patches sent to the mailing list. In the git log, it's commit, and "future commits" or "follow-up work". Yes, we use "patches" all of the time in commit logs, especially when we include the cover letter in the commit message (as done frequently in the -mm tree). -- Cheers, David / dhildenb