From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90966C001DE for ; Mon, 24 Jul 2023 13:47:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26A49900008; Mon, 24 Jul 2023 09:47:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21850900002; Mon, 24 Jul 2023 09:47:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B91A900008; Mon, 24 Jul 2023 09:47:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF746900002 for ; Mon, 24 Jul 2023 09:47:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B7E441409FB for ; Mon, 24 Jul 2023 13:47:55 +0000 (UTC) X-FDA: 81046633710.16.0E133FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 9741810000F for ; Mon, 24 Jul 2023 13:47:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F0NFoMda; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690206472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8pfmZyp+xA8zBWn7ulpQCaykhgvKopBAwd4XXMqneUA=; b=l0dmBo08kObpuZjsUfQ8IZJRRT251zChr9HNIsLGTAtVGeqvhLNDrrsbzhm+szuxV4WS2+ RExsLLvgFIol9hH+FvUOUfKbBrzuHJjhmPLU9vefSppsYGS1eVn5bAuEmnyxlGJwaxWoMi IGvufMCEtsUZfHk3N0GcTT2ervy2uO4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F0NFoMda; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690206472; a=rsa-sha256; cv=none; b=fDk5/1tAL7YU5yE6ee3orXFtpx/okTiY13wggOH1JtNA0v8FGYwjKQ5JZpuMbh8d1JdB6z hVPPebwY98vjI90bJ3tUmbezhbE91j4DR1zhJhkrqveZSnnuy424heb7MTKS8/s7z+AykA VVNw2iK620Fd3CMYmLr4f19ePtsUzS8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690206471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8pfmZyp+xA8zBWn7ulpQCaykhgvKopBAwd4XXMqneUA=; b=F0NFoMda7odb+yLCVcy8S6CPcK19pe0mZIBAG/FKt+VJHLQGK+kk+OUbAZMwl0zw8GdfLi CBoeOaZyTm6tBeozffcq/M5ouxt8aMCV1KAMrrpeuRJ/8asE1+GGXlddQ8Sl9126rJJJEk LDLMqaCN9pzetalvrzw6y4Hrru+fcK4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-5M0I86cHOSqF40ZV1C-95g-1; Mon, 24 Jul 2023 09:47:49 -0400 X-MC-Unique: 5M0I86cHOSqF40ZV1C-95g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3143ac4a562so2174032f8f.2 for ; Mon, 24 Jul 2023 06:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690206468; x=1690811268; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8pfmZyp+xA8zBWn7ulpQCaykhgvKopBAwd4XXMqneUA=; b=j1CTdM93TjiUKsXXWdCZizuoi4uRI27HaaUIPGWvBM3bBpOtSZQIW1dZYLIW/MZrxr r4bwuo++jK//RG6mIIZ+TqNzIIpyitYy/umTZ3zF8PpVY3wYV7HSy1zbNtURux4PDZL3 bSC5e30PY7nZsDthfBHwml1omR4dsUK9+QNVNuBI8/Mzz2e23Mc9MBDajke85eFLq/FG t0zmrSYBahJBppuNQYv8fV35bjWNz+3/otDjsL+GYnBYw2a0h3y2RXCQmwlR4T2SHy27 vIsX7Qo5+5x3n93clErj8wPIjeB/7pQmNNz+TKeKuqP8887lj5zpH9xq11j18rZTCwhf JeDg== X-Gm-Message-State: ABy/qLaw6j5STonr8zHBjWjIpoCZ9MVO899UBdnMaMaPzShn2/7FVc9K qNI5EAsvxrkjsxOXyrOgAX/4OCValh8I3OQDHI2GhMiSbY4g0Wjj4j1GB8+SGm1RGKjYDRBfxf1 /D4e61EfFJK0= X-Received: by 2002:a5d:53c3:0:b0:317:568d:d69a with SMTP id a3-20020a5d53c3000000b00317568dd69amr3729247wrw.11.1690206468209; Mon, 24 Jul 2023 06:47:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlG9J8DGc/PhrKu3N3yp1FcLsFmxojaIc7GVIexsEiJCb+lP/AMrTxdPwz+JTXxMRzaEyCrdfw== X-Received: by 2002:a5d:53c3:0:b0:317:568d:d69a with SMTP id a3-20020a5d53c3000000b00317568dd69amr3729226wrw.11.1690206467879; Mon, 24 Jul 2023 06:47:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77? (p200300cbc73dbb0091a50d1c3a7e4c77.dip0.t-ipconnect.de. [2003:cb:c73d:bb00:91a5:d1c:3a7e:4c77]) by smtp.gmail.com with ESMTPSA id p1-20020a05600c204100b003fc17e8a1efsm12872573wmg.45.2023.07.24.06.47.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 06:47:47 -0700 (PDT) Message-ID: <8a1b82f9-8de8-d0f6-874b-a2ba9131886d@redhat.com> Date: Mon, 24 Jul 2023 15:47:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 3/6] mm/hotplug: Allow architecture to override memmap on memory support check To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230718024409.95742-1-aneesh.kumar@linux.ibm.com> <20230718024409.95742-4-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230718024409.95742-4-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9741810000F X-Stat-Signature: 3zm9qbmzgnwsgpfmdeuw5czyiktoof18 X-Rspam-User: X-HE-Tag: 1690206472-937577 X-HE-Meta: U2FsdGVkX18q41CLhoDuYk/u45uq/ejd1+PHOLCJAyuANaG3stm0mDAEkzZjRjn9IKFMHKMSsEm58pPR8KqVHzrXiHCnK6j4gkxlNKyKJBk4bzRmFiXR99LmHKAye7J+0HGiYlqvF35LranoG0TjmF07cAqN54J+8DTvyVpZb/9SvOlYxL3F5Bp/ua9ISCkRBbR0eN8i+QBGsYh4Mia/oFCUQ5otkW13HfO03OhZ2K05qsIUuiV+1UizOsHPS/m7H1orEzBG9wnn+pjwSRIA9R7dBTwwTFfxGyVIjr/unPuoadQqLvqwi9MXidWREQ8XyqY3/03djpIX47V1MK3sZQShereU6aIABoj0wEB0gtertVhP0qAiRA8rAvDPaH/VUHzA7mu8hV1FhrJi61mEJWeg4BQp4AwPRXUxAbhmwkTF8CFiH4u8xeQuVgZJ8/oYHd6hTfiHJXlgW3Qomk+Vfv8wdKEqHkOjdwt8NC90ucKg4yQYZxnzEDEezVBdrn+yzmv8tJKP3Z++1XzVMA0npDrjiGeoN82vyO9UDFVlCnRnmueDrjVpkLwF+M60UoQyJwol4HtZewvfOFAfp+tuOgOpdvGqFgAAEW/ren3l2mdrPTX/kl4vYOSUhTud1cramPnHzzR8DzcBOkN4qQVxsXhy60TuEp4waSxbKHCB4TMJ9W+GL2jOoMQwCV5FwXaDDsaNFy5kv0wkKyoQDFa4uhhNqsay5wxqIu7+6ZJu8DbV1+84LSqWciJ99XzFPEPzk3NqR9L8B8nJIIMknCKfYe9f6trkGf9jpGq1y0SU4ZcdDtYHwaV7zzDGN9Hjxq6Ti/WehpL/YyZ3HECv8A2n2Eb6+Z99QQt83ev5xyRD26rvjlzm9p8iKiQTR19cQU6Nqdk4c8yozm5wOJOBu3/T0FqucQ4k1qxqpxgIvFM8gO87bQwIWOw4V/YxVfP4/b2I81/F7zEayOQ9neZaMWu RpnJQKBV 1VyA7ChETx5A3Bk7i8zzQEAXT1IuANjvKoRXzaRoFk2uYDMSWV1cPiz/XprZ1RB80qDVQ8tcI4eIBD0bdC7ZuISkJBJfguRptUfMnqzYoaFHXaRnu2bFq4pITCTJVtG84ucyG2AmBV+qmYIFDs1ydyInw/E6QnQXRs6aaD53/riUdSKbIzNH/l/zkbGJuc2uDyDrUuZYLQLR9LKCrStRFgiGbVqW5DwiagMTZNUCDF4UuZyrJNhgXMDIuNHOXFPkMQjcglpSA7/3nnS05ClTIsIvlvmny3fUgLQXgbG42Z5DK5JJDovEI6dAqn+3Bd7ohkHffswZO99viNVCmfT1UpAilTFzVGUZLpT6oLi2agsR+hxRvCKLrbSs575YVi1jNxn3hLebq6QIpkXBFvFz8VO0yKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.07.23 04:44, Aneesh Kumar K.V wrote: > Some architectures would want different restrictions. Hence add an > architecture-specific override. > > Both the PMD_SIZE check and pageblock alignment check are moved there. > > Signed-off-by: Aneesh Kumar K.V > --- > mm/memory_hotplug.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1b19462f4e72..5921c81fcb70 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1247,9 +1247,25 @@ static int online_memory_block(struct memory_block *mem, void *arg) > return device_online(&mem->dev); > } > > +#ifndef arch_supports_memmap_on_memory > +static inline bool arch_supports_memmap_on_memory(unsigned long size) > +{ > + unsigned long nr_vmemmap_pages = size >> PAGE_SHIFT; > + unsigned long vmemmap_size = nr_vmemmap_pages * sizeof(struct page); > + > + /* > + * As default, we want the vmemmap to span a complete PMD such that we > + * can map the vmemmap using a single PMD if supported by the > + * architecture. > + */ > + return IS_ALIGNED(vmemmap_size, PMD_SIZE); > +} > +#endif > + > static bool mhp_supports_memmap_on_memory(unsigned long size) > { > - unsigned long nr_vmemmap_pages = size / PAGE_SIZE; > + ^ just spotted this empty line that gets added here and removed int he next patch. -- Cheers, David / dhildenb