From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62642C433EF for ; Tue, 12 Apr 2022 00:52:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFFF76B0073; Mon, 11 Apr 2022 20:52:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF106B0074; Mon, 11 Apr 2022 20:52:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77EE6B0075; Mon, 11 Apr 2022 20:52:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id A97536B0073 for ; Mon, 11 Apr 2022 20:52:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 61FB7A7AC7 for ; Tue, 12 Apr 2022 00:52:37 +0000 (UTC) X-FDA: 79346401554.28.7B0E1FC Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf15.hostedemail.com (Postfix) with ESMTP id 8933FA0004 for ; Tue, 12 Apr 2022 00:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649724756; x=1681260756; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=xfxJtTXIuRttIzRBDb+X6akqcsjXQHvcov6CBWoB9aU=; b=K7hdHnA5e+YvzzjNw2q1UwsO9DY9X+XMBCnavB8K6a4TYeSiKb6Jo10W KQUEPLvVbFyA67JYqAd4zP12NUMLL7O+WsF3TKftpa/jFHsM6/mI30syt 0UZBLJ5He1kc4IhnxkJpwbUn30MjECXhpCcO3bN2RhQejyhFMwxVdIQ7q k4cM+wxO/j42fr48nm4y4WqagihdUaG/18y9p3/DxV1L94KIOXP62BPZL nxT84NU5mbdvhmJJujx7DaOMHK7f2b3Jo9Yx4JBeW6Mv9L5uYb2BYDwBD lG05Tybx2/cVZ/9y4HOCpIyFO/SlrgGh5XgxUpU0HdyKUUAnYbUc3lvlo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="244132006" X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="244132006" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 17:52:35 -0700 X-IronPort-AV: E=Sophos;i="5.90,252,1643702400"; d="scan'208";a="572492458" Received: from joliu-mobl2.ccr.corp.intel.com ([10.254.214.243]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 17:52:33 -0700 Message-ID: <8a4a0426c81f13d70d2c82b7adbc957e3e953bf3.camel@intel.com> Subject: Re: [PATCH v2 2/9] mm/vmscan: remove unneeded can_split_huge_page check From: "ying.huang@intel.com" To: Miaohe Lin , akpm@linux-foundation.org Cc: songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 12 Apr 2022 08:52:30 +0800 In-Reply-To: <20220409093500.10329-3-linmiaohe@huawei.com> References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-3-linmiaohe@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Stat-Signature: munptuhzjry5kafyo7dk5u8ba7ux1oar Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=K7hdHnA5; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=ying.huang@intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8933FA0004 X-HE-Tag: 1649724756-568113 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2022-04-09 at 17:34 +0800, Miaohe Lin wrote: > We don't need to check can_split_folio() because folio_maybe_dma_pinned= () > is checked before. It will avoid the long term pinned pages to be swapp= ed > out. And we can live with short term pinned pages. Without can_split_fo= lio > checking we can simplify the code. Also activate_locked can be changed = to > keep_locked as it's just short term pinning. >=20 > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin Look good to me. Thanks! Reviewed-by: Huang, Ying Best Regards, Huang, Ying > --- > =C2=A0mm/vmscan.c | 22 ++++++++-------------- > =C2=A01 file changed, 8 insertions(+), 14 deletions(-) >=20 > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4a76be47bed1..01f5db75a507 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1711,20 +1711,14 @@ static unsigned int shrink_page_list(struct lis= t_head *page_list, > =C2=A0 goto keep_locked; > =C2=A0 if (folio_maybe_dma_pinned(folio)) > =C2=A0 goto keep_locked; > - if (PageTransHuge(page)) { > - /* cannot split THP, skip it */ > - if (!can_split_folio(folio, NULL)) > - goto activate_locked; > - /* > - * Split pages without a PMD map right > - * away. Chances are some or all of the > - * tail pages can be freed without IO. > - */ > - if (!folio_entire_mapcount(folio) && > - split_folio_to_list(folio, > - page_list)) > - goto activate_locked; > - } > + /* > + * Split pages without a PMD map right > + * away. Chances are some or all of the > + * tail pages can be freed without IO. > + */ > + if (PageTransHuge(page) && !folio_entire_mapcount(folio) && > + split_folio_to_list(folio, page_list)) > + goto keep_locked; > =C2=A0 if (!add_to_swap(page)) { > =C2=A0 if (!PageTransHuge(page)) > =C2=A0 goto activate_locked_split;