From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD41CF11EC for ; Thu, 10 Oct 2024 12:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A3A6B0089; Thu, 10 Oct 2024 08:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13A096B008A; Thu, 10 Oct 2024 08:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D6F6B0099; Thu, 10 Oct 2024 08:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CD71F6B0089 for ; Thu, 10 Oct 2024 08:58:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4D937A026B for ; Thu, 10 Oct 2024 12:58:09 +0000 (UTC) X-FDA: 82657695750.10.F07FD4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1C48340011 for ; Thu, 10 Oct 2024 12:58:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WKGHpCx2; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728564956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=44Ch0LFpszh8zE+4D8ldsmz+ma6CSG0ELkdF7GSAHHQ=; b=ZIha7uYyXsjAaFqevBqymeHaxTH9zpZ1INNa0gOOUvLu9edm+r41LYaTHpqKVbbCWZJxNP CNRfH+QVwIHMEnOlpiRP7B52X7V0SsJFtCJZlZKh913J0hIz0mKLJvpuw5N3PrpveAdZIW WpS3vVmCQX6bQz3VDrQoOZuhjNE7YAE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728564956; a=rsa-sha256; cv=none; b=WCgWtNVbcEYfr6D1Ce+zuWTT9H5RLG6ODkN49p0BWLvxWj3UaY81yDH8i0hgNYtlU2hMBQ /c/o59KY/aiwNffShaRcEpqIEeS7xJPJ6+MuxvmI2x0LMLfiDouvKKYJeBsMrxySxAC3EJ FnZWlwsYnYwbYaaGtNhfqUeko+IVnu0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WKGHpCx2; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728565092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=44Ch0LFpszh8zE+4D8ldsmz+ma6CSG0ELkdF7GSAHHQ=; b=WKGHpCx2T26+s0sdSV6XOyAEUN+h/Uio9j+s2wm00nzj8mpAzXBdiuBIFxBJnXJBiZJJp9 TxuZTOryd7nohdkYZaIIE/Bqx7jhQWALgcmae0isEFXPxXkuCUp8x6UYXFjQZIIdbwEaka HuS1WQAt35qyPwSvHeYvJtCftXcOxKE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-uCtsOLrFPfepOYEesn044g-1; Thu, 10 Oct 2024 08:58:11 -0400 X-MC-Unique: uCtsOLrFPfepOYEesn044g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb830ea86so5731245e9.3 for ; Thu, 10 Oct 2024 05:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728565090; x=1729169890; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=44Ch0LFpszh8zE+4D8ldsmz+ma6CSG0ELkdF7GSAHHQ=; b=F0vbI6wQf/wSGGgdeYl/D9ZQGnQWySPULMO+H0nYCQ4crZbcy18WGsDachz4pWXyRS forIoawUkw7diuOxJgFgMG482AUiom//vmiha9Kw8rRRZMLjhpl2Jrh96mHlOb/7ZhQB Nvb/VznPrKb+uvXedYOgKq5eXjtCUrVJLd1w7f+asAbJqgSdQ6q8x64daWCkhNhNhjuP q+b10umG23iEIgomBWYY59bnjyAJyQ8EMn2FtPqr9r6e/T8XnXqLtXhhyv4hLhAfy1Ex nFCBPVH+Qc5eZXC2sdp7vjEal1uVh2CSjNYeoca2jkTQVuKM86VscfeRiBZ5ietw0PW8 eDsA== X-Forwarded-Encrypted: i=1; AJvYcCWwCXYv0mf8au5pcM9SdNQ56U4l/raa4hP6zDbGI2BG0bi9jpySnmPOmUZePhAw95RscqYk2/HoFQ==@kvack.org X-Gm-Message-State: AOJu0YxD6DabOwQLx6THHNoWstgHNwG/+YfH63v9OSgatFxv29Jgquvi 427cGzN2i7yO76locgPLGifbd2mVKSzd/HT4J0d/M5pu8ve33tE9Hh11cGgedUkYqzUSrfwsI89 Wu+XSkZQRall6P6LWfODK0pgCiO/k2K5oVC6XpxPEF8G0kyp9 X-Received: by 2002:a05:600c:a13:b0:430:9662:741e with SMTP id 5b1f17b1804b1-430d70b462emr52069955e9.34.1728565090341; Thu, 10 Oct 2024 05:58:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtemVG2sFpgVabNqP1/Gt+tjq9VXdAUdzZdbG4BTJp9Z3e+e9iLTK/FqhQf9CHRfdehaJbBA== X-Received: by 2002:a05:600c:a13:b0:430:9662:741e with SMTP id 5b1f17b1804b1-430d70b462emr52069695e9.34.1728565089888; Thu, 10 Oct 2024 05:58:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:9200:eb2e:74f9:6f5c:3040? (p200300cbc7429200eb2e74f96f5c3040.dip0.t-ipconnect.de. [2003:cb:c742:9200:eb2e:74f9:6f5c:3040]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-430ccf46e96sm48825015e9.18.2024.10.10.05.58.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 05:58:09 -0700 (PDT) Message-ID: <8a6c3ec2-246c-405d-9b01-a6c74ae677e7@redhat.com> Date: Thu, 10 Oct 2024 14:58:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: huge_memory: add thp_vma_disabled() To: Kefeng Wang , Andrew Morton Cc: Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Matthew Wilcox , linux-mm@kvack.org References: <20241010061024.1846220-1-wangkefeng.wang@huawei.com> <20241010061024.1846220-3-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241010061024.1846220-3-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1C48340011 X-Stat-Signature: o3b578wbgcns83jyjhea8f97c91bczs1 X-HE-Tag: 1728565091-124408 X-HE-Meta: U2FsdGVkX19hfy4C7xR6/Z5hl2/wfHASaCYEWivjAedJj8f/NX+zx+DR41E1VEHOR8C85YSn2qaQqWJByfQWb6VyX6LG5aFMvIxO6MX1WNez/+8kyIPDdop4DgIz509+RuqWLtAWmzqFOT5ZoQEjkyt/7Wiqm02woRxD8lN494HyauOIHSwqa0H1pSXpAuvCR81R2YqWLXk4zxfn9lIsOqgcKqKIvM6y4Bz0KFmVF5KzIdq+eC1ZptlfhGP5hSj1A/ihf1UsF46j1WtTaM3SQESc5gwHLbUMCBq77pDiALeP+TroSj/9hKZbl45MA6XhJo5OlVTzWVVmajp4VbZZOEFAZ49nQIjh2d6485IIp99rYSFwCiq94fSiExtkI6Yp2aRdtYqLVtr2XN/e+CGhJ7nA9A/L0xxW8SrjvQkniJsc9eUmf7pi3lpPefoq3wMIkwI/Z29U7sgyj1jxZ7OW5yvZL9FqXGHjUIIbaCoNRytYAgPeE6r34857HB8mULuWYqVxCmZYuU3kwgfKR7VQ546LSgmFFdolFSJx9GmJRBgGn8SQQhhTV/P6pUMUbyGH0cSf4yf04iNzQWdMSFeMDAGD+BZ148Nwrz0E06NA5r2PVLpQU6pVbFgUhwJpjAISGbKN0Bp76vX87PGS+KHpK2U51j2Vokef16rjiTDBn24wRJgo2vYZUvoEDxNSsYCcMW7v9mADTbWHnXTiAr5xBoLr63cl+5TXBCzFzP3+PhF4umjZtg+c/1gSVNuYn3syFtMzcpKDYmPLK6aut4lWP+ky7vQAsk8ks/pNOR4F+HSmllzL7c3hmprmfhze9rmhhustudFG1d9IC8i6BWanA+DjwhixLC07lJWtbpSC2eVSX5uaioMpKHh8DSLV1OdX8wcYBOllC0Is1FiHhN20M84QAiEYifjwiCSoWIYRIo/tON77uP/8SKkdvXDozB2eyc0fe3wIi4ProfPNjUf mlUx/292 h+3stvDTLFSEclNEsx38JWv/DitT82rJ7/6O5aekDPYkKbjSD2yYFukWQNAsQsAsqq7Gk2wCphon1wfD2XpoZ19b0+Wmx3cB1AFeaXFJHt7CkPAWDvoR/3m/K3QgZjY9m4HKdpCfTvYupXAnEnD61MAZmMDAMzHFfGzxVjcTBc/4dCrstWLy2BGbGihqCvn+4F3wV3BIMztCmzH5qPXn3HwkL0Q/9Cy0cPnQX7trXLBwooYv1wv/vWAjn11ddTXwFAg3Wie+zlEoP7wtyJ+TlpXALnl5I7Qffg19BJxIHUOBTplcFShOQZof+4UNb9aN4KvJGmoVs3ZRGU1Ry+XUlJRoFgjDOVtAzrN3rrRWOe0e0dtU29YXzN/f9zX4ostFkvW9FORpOZES2pAnPicqwc2FiSy9DwWmhGpbjGiO85KAyOPMRc1oBD94Uc3Ta/xw9TcfYulJ4duiwh9PuVFmytlB5GA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.10.24 08:10, Kefeng Wang wrote: > Add thp_vma_disabled() helper to shared by shmem_allowable_huge_orders() > and __thp_vma_allowable_orders(). > > Signed-off-by: Kefeng Wang > --- > include/linux/huge_mm.h | 19 +++++++++++++++++++ > mm/huge_memory.c | 13 +------------ > mm/shmem.c | 7 +------ > 3 files changed, 21 insertions(+), 18 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 795df660efa5..d77891332b35 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -309,6 +309,25 @@ struct thpsize { > (transparent_hugepage_flags & \ > (1< > +static inline bool thp_vma_disabled(struct vm_area_struct *vma, > + unsigned long vm_flags) > +{ > + /* > + * Explicitly disabled through madvise or prctl, or some > + * architectures may disable THP for some mappings, for > + * example, s390 kvm. > + */ > + if (vma && ((vm_flags & VM_NOHUGEPAGE) || > + test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags))) > + return true; > + > + /* If the hardware/firmware marked hugepage support disabled. */ > + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_UNSUPPORTED)) > + return true; > + > + return false; > +} > + Should we call this "vma_thp_disabled()" ? Also, I wonder if it would be more natural to check for the opposite ... "vma_thp_enabled()", like we test for "allowed" and "suitable". -- Cheers, David / dhildenb