From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23D3C7115C for ; Wed, 25 Jun 2025 13:19:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7283D6B009C; Wed, 25 Jun 2025 09:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1506B009D; Wed, 25 Jun 2025 09:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EDE06B009E; Wed, 25 Jun 2025 09:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4FB686B009C for ; Wed, 25 Jun 2025 09:19:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 143E71034E7 for ; Wed, 25 Jun 2025 13:19:53 +0000 (UTC) X-FDA: 83593980666.13.97AE727 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf02.hostedemail.com (Postfix) with ESMTP id 98C008000F for ; Wed, 25 Jun 2025 13:19:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GO7zj8pT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750857591; a=rsa-sha256; cv=none; b=sA7bDJs0g6ZnXlOBx7NoCIJ/8ueBCyLRT+Kqb691YIciZJq1olyuitxpxhDv55E+qcQjAv IizKFDRFzrgWYiZmvN+x1WwxKzKpCgiOfKt/w8LMRdwFxbxhwDdNx1pbF3emP4B9VcQVmC lNw2zqkkBa7A7IP7zJsDjo78LOfCsno= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GO7zj8pT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750857591; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EgXAwE7Srq56G8hBoHMWeT/tSpntvUV5q0QgOFWJ/dI=; b=mQYiDP72eVJXQnLBTr8Fz1fDRrzagc74egG/R55C5QeO/jLzmoYhbOuIoJyijZ3xPCz0Ch 2m2xcvNVUq1ccFdYyLKluPwqrgM2XAY2CezmrxHxbElzTkOsQghbdJeA0oKtTLHS+MNlMW FrW6g1QfyEDxCDhFxeU2Srze545JfTU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 1BCF561785; Wed, 25 Jun 2025 13:19:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28477C4CEEA; Wed, 25 Jun 2025 13:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750857590; bh=EhfqM/D/gYgjuxfz5kh30ccEUkl+3JBKSIok1lR06Js=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GO7zj8pTqPb1zaEwV5fxDNnho6jTaP+HMJnZdU7SfWYEupNztVlDcMF4dMt4M5FzS X8Ucn6Ut74Ulz2JzvGUqCeuEQi7GHunAL/vyESY79xQ+pmPDy2MUbJJvSDmQ6NKggn E4GQUvbHOfpF9PIWlEE5HYbRbOLwaadcKo4eVmLuFp8nJr0QK31kWilTdlxDrpFvMl KbKvUCYPkMw9m49t3c8wnxzuHsfoHONCSQmzXoXl0wAaBy3wMkhDev/k9alIT1o+zV S1UTmvWc69dMkYqytBdnw4TBcc+crqsIL5+rKLwMtmQ6imeM+jRXDwaN940jPdPX8I Sq81jKm8uM4hA== From: Leon Romanovsky To: Marek Szyprowski Cc: Leon Romanovsky , Christoph Hellwig , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Robin Murphy , Joerg Roedel , Will Deacon , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Masami Hiramatsu , Mathieu Desnoyers , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux.dev, virtualization@lists.linux.dev, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 8/8] mm/hmm: migrate to physical address-based DMA mapping API Date: Wed, 25 Jun 2025 16:19:05 +0300 Message-ID: <8a85f4450905fcb6b17d146cc86c11410d522de4.1750854543.git.leon@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 35fu53hqzw1sqzt788xzrtde89qm49se X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 98C008000F X-HE-Tag: 1750857591-602009 X-HE-Meta: U2FsdGVkX1+xc9yb1shYLVUZc9zODQAKUOhjQMsJ7A92PgITOEgkRzsljxFUuptUJmNgYh3Tdw+9vKoO7N3fdU0SlcniUOVAowJJ7LQcVxKddanelvSGFMglXV3xWwG3wDYNl8ol+unk0JqvtQvhW+LYpkNfGfgYCe38zjjWTJna+8MSNPsrzFZFDldA4CjjP2nXHNy/WflXvxSpTbO9r0RE//RzeA/UlbBSKFsgy3+LhWJJBz7jXHs3wcDPQQKZ1E5pQcE7o4G+oH6pV2znkgyHxSblg8Lb8ZL9pSlL7IVcNtiT6jEbWohvsHb7I08wWEDY23qCWvNF+dVu+k13LAucEB79RPZZGwYu/0lohpDXMgif779rBHlM7wg9ChfnxWb7Bzgl7u4VcAyJ11+5csHM3ps1BeegnFWhTeHfdGWK+xjt1o4Ti6BGO7zDA2r6VoyHG+1q/RMSq6WhnRUZc9hQbV+zmwOT5VG4xMVAaQH6PbF973t5oixSBIhU5ARYJlsyyrsknAiAegivpeNegrAccro8Ms9Zfb6dP8+i5AzeIIVSaoIZIpfb0XTFOIN8bwFAbk7G5abddvrnkQobXtYSqAY2OBWgr/Y0hUysfXufbxm84dsJ/rAlL3T3EMKlUh+sgN/mUIuzjxUwUy48jhdTmq1dBTz7OS98PtFk6r3NWT911WrEjeJROxumyMB1Gmih4TwOctlDl9dnl0Ez3h8R1OTVCk6CqqM1sTlxd+RddB4yElgWyzgW2tLYJotyg1GlzQRfNcJ2XMiywU3kFrFgoMRPb6DNp65Opu0uxlZKlgGsfIpTZHJbrVmz3YvExyu5qjWg57KrazhBdHa3R5IpqG/BdmtLuJiwBnzlufnlNHbNezCCyzbk/OrrDksrMy+HI26sLeW34fRLhjjHrlBZlZFAio89RHnkZrFqCnESrSBm+IaMgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Leon Romanovsky Convert HMM DMA operations from the legacy page-based API to the new physical address-based dma_map_phys() and dma_unmap_phys() functions. This demonstrates the preferred approach for new code that should use physical addresses directly rather than page+offset parameters. The change replaces dma_map_page() and dma_unmap_page() calls with dma_map_phys() and dma_unmap_phys() respectively, using the physical address that was already available in the code. This eliminates the redundant page-to-physical address conversion and aligns with the DMA subsystem's move toward physical address-centric interfaces. This serves as an example of how new code should be written to leverage the more efficient physical address API, which provides cleaner interfaces for drivers that already have access to physical addresses. Signed-off-by: Leon Romanovsky --- mm/hmm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index feac86196a65..9354fae3ae06 100644 --- a/mm/hmm.c +++ b/mm/hmm.c @@ -779,8 +779,8 @@ dma_addr_t hmm_dma_map_pfn(struct device *dev, struct hmm_dma_map *map, if (WARN_ON_ONCE(dma_need_unmap(dev) && !dma_addrs)) goto error; - dma_addr = dma_map_page(dev, page, 0, map->dma_entry_size, - DMA_BIDIRECTIONAL); + dma_addr = dma_map_phys(dev, paddr, map->dma_entry_size, + DMA_BIDIRECTIONAL, 0); if (dma_mapping_error(dev, dma_addr)) goto error; @@ -823,8 +823,8 @@ bool hmm_dma_unmap_pfn(struct device *dev, struct hmm_dma_map *map, size_t idx) dma_iova_unlink(dev, state, idx * map->dma_entry_size, map->dma_entry_size, DMA_BIDIRECTIONAL, attrs); } else if (dma_need_unmap(dev)) - dma_unmap_page(dev, dma_addrs[idx], map->dma_entry_size, - DMA_BIDIRECTIONAL); + dma_unmap_phys(dev, dma_addrs[idx], map->dma_entry_size, + DMA_BIDIRECTIONAL, 0); pfns[idx] &= ~(HMM_PFN_DMA_MAPPED | HMM_PFN_P2PDMA | HMM_PFN_P2PDMA_BUS); -- 2.49.0