From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45B0EB64D7 for ; Tue, 20 Jun 2023 06:39:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 485C48D0002; Tue, 20 Jun 2023 02:39:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E058D0001; Tue, 20 Jun 2023 02:39:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287BC8D0002; Tue, 20 Jun 2023 02:39:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 143718D0001 for ; Tue, 20 Jun 2023 02:39:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D282BA05C8 for ; Tue, 20 Jun 2023 06:39:35 +0000 (UTC) X-FDA: 80922175110.12.5437C22 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf04.hostedemail.com (Postfix) with ESMTP id 64D8140007 for ; Tue, 20 Jun 2023 06:39:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q0x5ZOGt; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687243174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=auJ6EJaNEhBlb5WUEu9u5pzfD1n3KesDYvPGRacKRpY=; b=GAHC35T5ySaurDsguIIwpspsa/lp657Q/uPSHFXzVSW84foO3AX5q/3khkIcLFQXBWeO3m qNLvY87Wd3ZwZEQTBNNVJIN8yGKGbC0ks7DyQyvQuKU6XFTHFsQcFNYLOkUExPn3RyMpY0 gB6RkF+b/YBnHdbOdJKBzP2dZljxebU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Q0x5ZOGt; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687243174; a=rsa-sha256; cv=none; b=gJRrYYVEAT5Lw4rhtx6pQu6evTGk3b9Yne5qC5wkK0ELNe+RNPehpnxUNMbh9AFLHDitAj LORuJ6wZyWEg+svOOPMm06uRxur/TJrO2u5mbOZJllt0cv7+chKWac27f5IbFJbluVtg7K vxIhMV9J1zQosLolrXJA1j7G11YCsak= Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6b470ebd670so1655209a34.0 for ; Mon, 19 Jun 2023 23:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687243172; x=1689835172; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=auJ6EJaNEhBlb5WUEu9u5pzfD1n3KesDYvPGRacKRpY=; b=Q0x5ZOGt4/v3wQppV0vu3j4kjyVREZuzdlXMoLL29N7NXduun7x+/qMKtZI9/fJvkE uXAJEwy/vwqunPx2kBUjpJnwRZJYHPKEU135M3wz8Lbji0KHP6SAo8dzYCyUA91hD2hK qQFY1wwfxb6zZ2hcn39cy6SQgMduj6ZO6UnIgFsg/LsEwb5s1ohxYtTnc3+lnKX4c4up 9b0HQQSe2NnahNMiG0Ue1NNNiQHRN1pqAwwNk3vqHBW6OZsxoTORWGTDR/hX/gVasPBI RgeSOvQLSLXUsLXt6N2Sx/C/uwmT3Q+vwAAehP4zPVzFD3vAPrUxgSq1xPAf2WLJ68Is nDzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687243172; x=1689835172; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=auJ6EJaNEhBlb5WUEu9u5pzfD1n3KesDYvPGRacKRpY=; b=iSGDB3pNs7zFw1ehzjGsbi1LuRJT3nc/Dsu4iXag3WmPczQrkjYsTCssWYKgcPss5y 4c1TH+Rxt2jptCrVCpMIOsR6TkIb41GLGyTOvoK/W+FzKVETMPMqt/o6m8MVAaJKZzbC Z5sBfC0akX1iq5Yi9abHe/WdGvGN2ljNcgLIJaguEpmvm3c90Pmzm0LQJ7lXqMUsNCaK FSXSY8egDnfGueTtPOwv+nOkHwiOyQxA0e2a9IQfL6HGEtLqewIfKB90TXVKT9sc9OY2 AzWu/MwzsqpMDNUvnirj8Ps9YM6AuUra+buqhYzcdSfkeFniUy9R1wIXesh2J6gT58Rs rcJQ== X-Gm-Message-State: AC+VfDz0v9zYVP2EE9UVLkFgdpTgZ74gGYVE/Uq4zsIpEu8L+tWVEpVL sA7rqn0TFgMbf2r7XwQPuvkCuQ== X-Google-Smtp-Source: ACHHUZ7MXbwUUZMP5G5VW1Wv8zl+x/+Um3sJyQyvUnyO9ywOp/LLZEb0Mxk8lkxfS1aPkLdMl9HoVQ== X-Received: by 2002:a05:6808:198a:b0:39e:deb3:e1f with SMTP id bj10-20020a056808198a00b0039edeb30e1fmr6248467oib.40.1687243171988; Mon, 19 Jun 2023 23:39:31 -0700 (PDT) Received: from [10.94.58.170] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id jn9-20020a170903050900b001b679ec20f2sm843151plb.31.2023.06.19.23.39.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 23:39:31 -0700 (PDT) Message-ID: <8ac1034d-4ddf-86a6-a7dc-769bc5080fac@bytedance.com> Date: Tue, 20 Jun 2023 14:39:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Re: [RFC PATCH net-next] sock: Propose socket.urgent for sockmem isolation Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: Eric Dumazet , Tejun Heo , Christian Warloe , Wei Wang , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Vasily Averin , Kuniyuki Iwashima , Martin KaFai Lau , Xin Long , Jason Xing , Michal Hocko , Alexei Starovoitov , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" References: <20230609082712.34889-1-wuyun.abel@bytedance.com> <4p22vtjrpu4obmbjivgpe635gbpjmhsfisnxghgsson2g6yy5r@ovawhchw7maq> From: Abel Wu In-Reply-To: <4p22vtjrpu4obmbjivgpe635gbpjmhsfisnxghgsson2g6yy5r@ovawhchw7maq> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: m6dy17qqfm6rq9ctyceo86ezgn7y6xja X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 64D8140007 X-HE-Tag: 1687243173-646444 X-HE-Meta: U2FsdGVkX1/stslWtza+hYmDZWOJMP35mcGDOzBKCevoJ8oPudWCxhAPWJIdeVjU1ePHVFMG3fg5jgV72h9862AVs3EfSNhOrfaduMYKZonjzj2O6e1rbkjtsMQ4ZnH3Lrw7/4sYQELF/qG05UiT74xMxd+AVr6RZqkHwHc+gDVEbMGMzwon8f6ugg9oMaMdDUBB/iSPlXRu9O1WlynXbW+sxWzea3uTI4N+MMlulVFJ3Hv8+wReaW8NL+Ph8YVyN8j9mnf1rWEbP6dy0t1SxpmRPhAvcy3tnW3i/uE8vYrxXhcMDO/L+FecnKTAUFh/cNPL4VAHfQ7WEw1EMI0wElte2HPKzkt4cYmM8UrQ9XvApZhvLNHcxAb1GjE9XFBaQ6YWN9P1tFMBL2tPd6MyO/WvjKa7hNuPE5KHNYVE7i59QtxfsOb6pJ7qr/LMq7tQ8GES2MaRgFkKZuhjFRbz8T+3Wn0tPMcEv3eBHhzWTiPTo9i32zVnEFfiyrf4iSy5XZz1OhEDh5PPv1VCivku+dV3DHFKzp/Ww5gQjF5B2BBFAwI3z7Ts53/QnrwX2vkDMrDsyCBjHYxiXukLmIBFIcKBDNsxZJCA1THKEdMwE4DA0wfeezuE0AjEUk4Q1CUqAhEq+CwVq7eJ5c8WjCmWxE/WyHpGuC1SLvuCVoYPwdkXfCvG4i6aNYZKuOHG2QH7buPHMdjpUkqKS/beVxLL1LUvvzowN+edjiagFnvyvxfgare1GqYiMPpkrEL5FK7vSlrVEX04z3AdgfqVF8wujCLVIperaki8dqCY62RDUaD6qce7lNx5IUpGoFKUERTw7hMBLUwNhvgMRBHpUWcOw7zHwlqpVb37m4f7RnutOIX4gSMX1B3IcKjdCzXRlJ8DwY1AOYKQZR2q2FQQXvhYMI1hJqouh/3I4nBOM6jdcH+nYYJ+w9ZvdByKHqYYx60bH5hoyfAhI5rn2asRH+3 hwMQCt/g gBkqu16UGo9E7P3oPCKAEvLqGMjZAZ5omyOvdltDJGCkhlzPgRXAOt1q1Qdyf/ir/yw7RbojbATpkICOI9ROMgZtty0YDdWM3tprHXxZR+WvAhRQTP1ykSY3qOizIKUC8Ca7t4ygnr9nf8fM1+m3yhKm6wstVsFcLkKbLtGDneeaeTvtfcP9UbR02WHg+gJPp0VYPIdZBy0QJ38oDb2Kbj8QQr3dSshu31d/S8M4reRl89i6dHxwYcdVv8xHhT7LPiHKtDpRDQnG9/BADzzubKeN1lXg8I0lzwY2VbhOgnibrAVHEsZ0DLUw1RBOVQhOAikjkqFOPXhfEKYN11OIMbNNHOKUVDQdUqmEblpOq/s8VfGFRYslrObEU/srQ6WJKD2LbrniClM6cvXWni0+z/YFbHm9LRRBMJsTD+Lpphbu2VdhV7tp3txRf8melE4CUISSbeLv3L5wCaSVcw5pgE7HtvY8C/eybiM1y37oe42dFDGbYkcG7HRIMpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, On 6/20/23 1:30 AM, Michal Koutný wrote: > On Tue, Jun 13, 2023 at 02:46:32PM +0800, Abel Wu wrote: >> Memory protection (memory.{min,low}) helps the important jobs less >> affected by memstalls. But once low priority jobs use lots of kernel >> memory like sockmem, the protection might become much less efficient. > > What would happen if you applied memory.{min,low} to the important jobs > and memory.{max,high} to the low prio ones? I might expect that the memory of low prio jobs gets reclaimed first. Specifically we set memory.low to protect the working-set for important jobs. Due to the best-effort behavior of 'low', the important jobs can still be affected if not enough memory reclaimed from the low prio ones. And we don't use 'min' (yet?) because the need for flexibility when memory is tight. Best Regards, Abel