From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5391CC6B05 for ; Thu, 2 Apr 2026 07:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE1AE6B008A; Thu, 2 Apr 2026 03:15:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C92926B008C; Thu, 2 Apr 2026 03:15:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B811C6B0092; Thu, 2 Apr 2026 03:15:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A54826B008A for ; Thu, 2 Apr 2026 03:15:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79322B9383 for ; Thu, 2 Apr 2026 07:15:47 +0000 (UTC) X-FDA: 84612755934.20.08E48ED Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id C2F05C0006 for ; Thu, 2 Apr 2026 07:15:45 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=abkrN80g; spf=pass (imf10.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1775114145; a=rsa-sha256; cv=none; b=qI/PzJ4M5tWWkYoKlhj/0sEgBg1TOBmIkAmXyR2b8LxU1TPr5iw+wtnFhG/tYEpv2XAbSz sWWvEIFdH47tf/JtC5NwQyCFzvhk1j8OHZYQ7PzyxbyZhr/M4UNq69HMj2vsgq5pVOB4ZF ijzp4J1QK6xNxGACKe93qU04geQWlLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1775114145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PCOddpp9DFtN9Ll8S0MEtVB5rAZljK7NGl7kHcED4NI=; b=aeMBUF5wj4ofm8hUgxJc4afVhw07+OyjT5AXB2L+IewScTlm1WPWr81H+6cSpm64s7AohH 3ReSUnIOD1saF614msIIiYUmNBCt7eGuJ69iKmvuh78V2smynTQzTOw/zLuKINkBeOSEyO kVCBE0b1x7kXi+RQ/mHExwePGW7SDX0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=abkrN80g; spf=pass (imf10.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id AF69D44401; Thu, 2 Apr 2026 07:15:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2030C2BC9E; Thu, 2 Apr 2026 07:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775114144; bh=15Rb82sGNFX6qQyj2zyuism7Uxe43HZFCTwkUrfzpQM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=abkrN80gm/tZE3PUps8yrNSOihn0fsB/AtwSkxwzJDcZNYnRsoFBh+6ibRMeEKlyv FGcVjr9zbdEasF3+Q55k9/2ic2WjDx+xv8vlOVVRp/F3yv6eJ2SJ85ayX2F5giwLVh zc3xrcku9aIMyrrNqNplayB39Qhy5b8Asjg5Uf8O7hxL75hGj8HG0Orti7EG4Xfc2H qjVedD0x6hiBasUaH9q7lYKa14IojUeivNW5FNzZoW5RxcWHzCCS9nB7ANhsAYG/7v kMwYBQLs6inrRSG+g2v3N1gAkPMhWAfPMi5MnE76B5UiBXM0IuVwafMMfGYXV9KhOh KqBniwlbsO3LA== Message-ID: <8b6d552e-cdf2-4472-ad26-62cbb575b0fc@kernel.org> Date: Thu, 2 Apr 2026 09:15:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] mm/page_io: rename swap_iocb->pages to swap_iocb->bvecs To: David Carlier , Kairui Song , Chris Li , Andrew Morton , Kemeng Shi , Nhat Pham , Baoquan He , Youngjun Park , NeilBrown Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Matthew Wilcox (Oracle)" References: <20260402061408.36119-1-devnexen@gmail.com> <20260402061408.36119-2-devnexen@gmail.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260402061408.36119-2-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C2F05C0006 X-Stat-Signature: 53az9ofo6zw4jrzafucmmnjwzp6ohkxo X-HE-Tag: 1775114145-953430 X-HE-Meta: U2FsdGVkX19rP+4shFhXf2TLvwNyHZo6zEyUtxuZTuUmbkW5RQ6MxITvdIlNxqZuG74Egw5tbPecI4j0JgqNtYHBEsuDGV0BOJ4aaLFhBAJakERrszu2DNpi7DVzrzzKdTm2u6qTZtTB+Jha4C7tilUlzrvt9GhDJ6og3sfUl56dvJHOyO62lefljoCHAYGatICiFLZ59ObiZag/jvV2bVAblASD4Z1fBpKSBbPraPJR9DoaM2Ld07sCAsDsYD0BL+oxbh1JfbU9NV6j4iRl5hFDAuki8bKlvTtpG4rqSj03V+Wh333hwptMTVNbdLWgRpXDTSnwfiIyk95FgdOZkszQoGoeiWuMT93UjKCvz66TaPlyk+VIImrOmPhc9e6FKy0Kn6O5vRragD/jiaTJesLOBWSrUZ18kCp40N4E34fTWMs/xnB790jw40oqBkt3ORLwH9TE3VoA1+qa4dAU+PdZQa1nnfr3U8uxECHAd5gjGPDAZlOiPrCxF13Rn+9o16M1NHCgA6L9AhdTtxufItYjdXfK3mZrjvOwOw7zeqhw03RPs5DNV8H43jLzPdVubdIRR9GVOUTIwQ8/UrP9G7VlTebOhZmfUg9CXaq/0BPX7WTU7Hq4rZBoQygwYLyk3b0tSElVY9JtKuXnybfJxdpgdIIoqpGjXdR2UzyPpcQby8s4n5lLk0je62cCAyofsRtd4KhpP7XVjdvMSzFbW5r3QC6k3tB83DPXsQ9M97aetzSLHndi25t8iEGi4rP4OfZXugq25MXCaVAdxMgff7iJSkkofaSQ49a1nbAVD8tQfiyYJi5ZobakapWS3kmEcJj5hxBMYC7puBxcoyxRqaCIyQzUnUJQ6z/3gENRwNTKl6QpWV3YQj98rS4gSSdGTI7Dt7IkB5GplhtwUY4vXuOzKHPTFSJb0qEZZQjvVuS+M1rl5ZpjzX6/FPSRA1USfu/B5FQgc2KtLuI4/Wc MY9ha4ca XDuFQZi7RsF+mmYQ= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/2/26 08:14, David Carlier wrote: > swap_iocb->pages tracks the number of bvec entries (folios), not base > pages. Rename it to bvecs to accurately reflect its purpose. > > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: David Carlier > --- > mm/page_io.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index 1389cd57ca88..e524cb821d04 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -327,7 +327,7 @@ static void bio_associate_blkg_from_page(struct bio *bio, struct folio *folio) > struct swap_iocb { > struct kiocb iocb; > struct bio_vec bvec[SWAP_CLUSTER_MAX]; > - int pages; > + int bvecs; bvec (an array of bvecs) vs bvecs. Hm. Wouldn't it be cleaner to have struct bio_vec bvecs[SWAP_CLUSTER_MAX]; int nr_bvecs; ? -- Cheers, David