From: Mike Frysinger <vapier.adi@gmail.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Stefan Huber <shuber2@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Meerwald <pmeerw@cosy.sbg.ac.at>,
James Morris <jmorris@namei.org>,
William Irwin <wli@movementarian.org>, Mel Gorman <mel@csn.ul.ie>,
Ravikiran G Thirumalai <kiran@scalex86.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@kernel.org
Subject: Re: [PATCH] fix undefined reference to user_shm_unlock
Date: Sat, 12 Sep 2009 07:41:22 -0400 [thread overview]
Message-ID: <8bd0f97a0909120441y764174d3pc78929438492c6dd@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0909121218020.488@sister.anvils>
On Sat, Sep 12, 2009 at 07:21, Hugh Dickins wrote:
> My 353d5c30c666580347515da609dd74a2b8e9b828 "mm: fix hugetlb bug due to
> user_shm_unlock call" broke the CONFIG_SYSVIPC !CONFIG_MMU build of both
> 2.6.31 and 2.6.30.6: "undefined reference to `user_shm_unlock'".
>
> gcc didn't understand my comment! so couldn't figure out to optimize
> away user_shm_unlock() from the error path in the hugetlb-less case,
> as it does elsewhere. Help it to do so, in a language it understands.
thanks, this works for me
> Cc: stable@kernel.org
should go into 2.6.30.7 and 2.6.31.1
-mike
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-09-12 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LRH.2.00.0908241110420.21562@tundra.namei.org>
2009-08-24 12:27 ` [PATCH] mm: fix hugetlb bug due to user_shm_unlock call (fwd) Hugh Dickins
2009-08-24 13:56 ` Stefan Huber
2009-08-24 15:30 ` [PATCH] mm: fix hugetlb bug due to user_shm_unlock call Hugh Dickins
2009-08-25 7:36 ` Mel Gorman
2009-09-11 14:03 ` Mike Frysinger
2009-09-12 11:17 ` Hugh Dickins
2009-09-12 11:21 ` [PATCH] fix undefined reference to user_shm_unlock Hugh Dickins
2009-09-12 11:41 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0909120441y764174d3pc78929438492c6dd@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jmorris@namei.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=pmeerw@cosy.sbg.ac.at \
--cc=shuber2@gmail.com \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=wli@movementarian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).