From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 944A86B004D for ; Sat, 12 Sep 2009 07:41:39 -0400 (EDT) Received: by ywh28 with SMTP id 28so2713946ywh.15 for ; Sat, 12 Sep 2009 04:41:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4A929BF5.2050105@gmail.com> <8bd0f97a0909110703o4d496a45jddc0d7d6fd8674b4@mail.gmail.com> From: Mike Frysinger Date: Sat, 12 Sep 2009 07:41:22 -0400 Message-ID: <8bd0f97a0909120441y764174d3pc78929438492c6dd@mail.gmail.com> Subject: Re: [PATCH] fix undefined reference to user_shm_unlock Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Hugh Dickins Cc: Linus Torvalds , Stefan Huber , Andrew Morton , Peter Meerwald , James Morris , William Irwin , Mel Gorman , Ravikiran G Thirumalai , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org List-ID: On Sat, Sep 12, 2009 at 07:21, Hugh Dickins wrote: > My 353d5c30c666580347515da609dd74a2b8e9b828 "mm: fix hugetlb bug due to > user_shm_unlock call" broke the CONFIG_SYSVIPC !CONFIG_MMU build of both > 2.6.31 and 2.6.30.6: "undefined reference to `user_shm_unlock'". > > gcc didn't understand my comment! so couldn't figure out to optimize > away user_shm_unlock() from the error path in the hugetlb-less case, > as it does elsewhere. =C2=A0Help it to do so, in a language it understand= s. thanks, this works for me > Cc: stable@kernel.org should go into 2.6.30.7 and 2.6.31.1 -mike -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org