From: Yang Shi <yang.shi@linux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: ktkhai@virtuozzo.com, hannes@cmpxchg.org, mhocko@suse.com,
kirill.shutemov@linux.intel.com, hughd@google.com,
shakeelb@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: thp: make deferred split shrinker memcg aware
Date: Thu, 30 May 2019 21:29:40 +0800 [thread overview]
Message-ID: <8c14a749-d94e-754d-656e-24e123ab28c6@linux.alibaba.com> (raw)
In-Reply-To: <20190530120718.52xuxgezkzsmaxqi@box>
On 5/30/19 8:07 PM, Kirill A. Shutemov wrote:
> On Tue, May 28, 2019 at 08:44:22PM +0800, Yang Shi wrote:
>> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
>> index bc74d6a..9ff5fab 100644
>> --- a/include/linux/memcontrol.h
>> +++ b/include/linux/memcontrol.h
>> @@ -316,6 +316,12 @@ struct mem_cgroup {
>> struct list_head event_list;
>> spinlock_t event_list_lock;
>>
>> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> + struct list_head split_queue;
>> + unsigned long split_queue_len;
>> + spinlock_t split_queue_lock;
> Maybe we should wrap there into a struct and have helper that would return
> pointer to the struct which is right for the page: from pgdat or from
> memcg, depending on the situation?
>
> This way we will be able to kill most of code duplication, right?
Yes, it sounds simpler than using list_lru.
>
next prev parent reply other threads:[~2019-05-30 13:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 12:44 [RFC PATCH 0/3] Make deferred split shrinker memcg aware Yang Shi
2019-05-28 12:44 ` [PATCH 1/3] mm: thp: make " Yang Shi
2019-05-28 14:42 ` Kirill Tkhai
2019-05-29 2:43 ` Yang Shi
2019-05-29 8:14 ` Kirill Tkhai
2019-05-29 11:25 ` Yang Shi
2019-06-10 8:23 ` Kirill Tkhai
2019-06-10 17:25 ` Yang Shi
2019-06-13 8:19 ` Kirill Tkhai
2019-06-13 17:53 ` Yang Shi
2019-05-30 12:07 ` Kirill A. Shutemov
2019-05-30 13:29 ` Yang Shi [this message]
2019-05-28 12:44 ` [PATCH 2/3] mm: thp: remove THP destructor Yang Shi
2019-05-28 12:44 ` [PATCH 3/3] mm: shrinker: make shrinker not depend on memcg kmem Yang Shi
2019-05-30 12:08 ` Kirill A. Shutemov
2019-05-30 13:20 ` Yang Shi
2019-05-29 1:22 ` [RFC PATCH 0/3] Make deferred split shrinker memcg aware David Rientjes
2019-05-29 2:34 ` Yang Shi
2019-05-29 21:07 ` David Rientjes
2019-05-30 3:22 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c14a749-d94e-754d-656e-24e123ab28c6@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).