From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6FB8C369DC for ; Tue, 29 Apr 2025 09:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 811E56B0007; Tue, 29 Apr 2025 05:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C4996B000A; Tue, 29 Apr 2025 05:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63C176B000C; Tue, 29 Apr 2025 05:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3DD756B0007 for ; Tue, 29 Apr 2025 05:38:30 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B08E81D071D for ; Tue, 29 Apr 2025 09:38:31 +0000 (UTC) X-FDA: 83386581222.21.51B2BA7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 32C4140004 for ; Tue, 29 Apr 2025 09:38:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FS9Foza2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745919509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AFEFJQCYVd4aNznUmThM6O2Wo4ETnB8U+WYBKRrrkEg=; b=tZ5i01nAk5wL14sfGLuUjnqJKYwUGY6qrih9UDAQtueBNUaK37sSymNn+qSOJJ3q8qwm/7 KJZOfE1P2SHoGZ0yFor3oibrD9S7K7Zpw1CdBOqy6Zb/k42+OtQdQeA9yp0IMIamZB99r6 szF+BRZ3j+DviOGmiiYU5Pm31p6X0Gk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FS9Foza2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745919509; a=rsa-sha256; cv=none; b=jqN3L/KfnT9rnPHt1eer0/yESpaqVjQehR82J23J+weKudNNZiBpWZC9Ms7t56+gn3FjoI YnRSvgr7VYBoKn+TS5q69wuRcrMdng26ipPtPMrxZ2j28wG7vIUWZVNVB2H7uwRSqsQeMz 4UdOeiwkbIMPQd9v6J3lM1HChgb75d0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745919508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AFEFJQCYVd4aNznUmThM6O2Wo4ETnB8U+WYBKRrrkEg=; b=FS9Foza2AgWmItDa/aDYRz7RWIGiO1NGKCCtHvrhqRj/npWKWtQhMOEFvfQ4MfHEEmoI3p P6TAMZQ6igRuV0o75tS7vfYh92yuYGRSpR46T39pFH5hM0k6lksoPSEYQM1bzJmW6iVdYk WKG45aOA6u4mq41UZ9Nmy5OGrCHatRs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-WLkzTPCEP3qCdvgUNUOGzw-1; Tue, 29 Apr 2025 05:38:27 -0400 X-MC-Unique: WLkzTPCEP3qCdvgUNUOGzw-1 X-Mimecast-MFC-AGG-ID: WLkzTPCEP3qCdvgUNUOGzw_1745919506 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39c2da64df9so2564871f8f.0 for ; Tue, 29 Apr 2025 02:38:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745919506; x=1746524306; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AFEFJQCYVd4aNznUmThM6O2Wo4ETnB8U+WYBKRrrkEg=; b=od4msxiJNFht9s5UxBqdwVvOvy02lIPR1zp4Zhyb9g7DwDoj+ruidtYtsVV9B0KMcr ZaY2Dv+Z6oDgaAP51NMSCZaetTbrd7Lv/xyOCySqGXOrqAdJgetAHxAQ+azICo+pjwcS AG/1oA3MeW+SKP6t1M3qfIbAJ4UZMqIFkxVzuigzsWgLfgLFZlq/CvbxXFNhjqN32R9b rfa+TT5ndeninxwPJkNtm5HfejTuV4TcR9ybPRzxn/Zkaf2s9gX1wjG0VNIXX5Md1W1Q aMy0LtpvwA3UOVWbY4t0Je6WzB+TSnKHYK8xgixO6GTMo4UrJHirJdUCQk7sT89CrVPI H5fA== X-Forwarded-Encrypted: i=1; AJvYcCWRn7oT0e5D6201PVWhzI0kpYVe/B8tPO2g733BnXI2sgeThGXugOZXTSfXNGHzQ8G8Qjz0Wb0VkQ==@kvack.org X-Gm-Message-State: AOJu0Yw1x5jnpsuDrzn2W1doemhdgr5h/yjrwWAaWHcpMqKX/XcEfWT1 nTLyjHQd99/0U4GdA0icEOyz72VRXnjVe141eZzxDyi0MWgFMBxS+l4RHeNLJJLbajoWEYlyryE GClOBflxAcerlF8Fp2edn1Q03tgGEI/zavfKyTPx572wfzNq1 X-Gm-Gg: ASbGncst4187eyGtHQidgZXRkemSYmDVc5AQM/CagVL+hoSf8O69i4Zm22n4+umxDGV dTBR8PjJSQ62Iv6C+DlL4ueFzNePsuRgJa5Kj4ML1ZlV3TF6/vIHBknRXTRz6jcOOy3fo2grknN EBfQHKS3rA/1yIzMXGRLvBpWXofaj3GaLTBR0BkliY7VqQ4ms096mdaP9cbiPmL/MEeCt0+QqQk Kdkf7dqFs06v6ajT6e3WuAtLfg16zTnMPV5Y23cZG4YiCYVrGphAVVGn61RJBRmJ148BvTJ1CX6 wRYPllL/FjyPbCcksDd77QJ7d0fnV3SHVDA99priV2kvy8xZ7Mj2RjMxDWKfYJ4QBmxUpL0T4QN rbkTlGHQazwspvbscqQmjVvweX0m/F6to2yNOR0U= X-Received: by 2002:adf:f750:0:b0:39c:dfa:d347 with SMTP id ffacd0b85a97d-3a07aa5ff84mr6709238f8f.2.1745919506032; Tue, 29 Apr 2025 02:38:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYjC5BmfOyv5MOrr5MzYP55muzVFw+dHR7tAqomHmOoTe0l9uVTA1oLuNJicPD81ioL3ylpg== X-Received: by 2002:adf:f750:0:b0:39c:dfa:d347 with SMTP id ffacd0b85a97d-3a07aa5ff84mr6709212f8f.2.1745919505389; Tue, 29 Apr 2025 02:38:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5c9cdsm13341043f8f.87.2025.04.29.02.38.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 02:38:24 -0700 (PDT) Message-ID: <8c268ece-71a7-470a-bf8b-71d3e4920977@redhat.com> Date: Tue, 29 Apr 2025 11:38:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC Patch 0/5] Make anon_vma operations testable To: Lorenzo Stoakes , Wei Yang Cc: akpm@linux-foundation.org, riel@surriel.com, vbabka@suse.cz, harry.yoo@oracle.com, jannh@google.com, baohua@kernel.org, linux-mm@kvack.org References: <20250429090639.784-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GEEpga7VHMioX8flsLccH-oAEEnzufEziz9jpK4ph1U_1745919506 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: g8zcxpsyyhph98tdupaxhjti1s3spxi7 X-Rspamd-Queue-Id: 32C4140004 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745919509-240805 X-HE-Meta: U2FsdGVkX1+571IE1jwEZgbt7Sw8SC/As4XOfGOdOJHB351aaZViQ/7UH+E8mnHPicDMZR4AnXn0N570ze2FRJwlDR0QxHHmvciKfgS7ZOYaqVSpR6wZEbPpt0H7+Zxa8DbfaMItbI2u9geZbZoAnLsgiO7kFPk2FC0FKPHNDOYWdDnCYv1LE1x+C0/obu0wHJ0wD6KGwK+qDJfdIa45L1CPO/FfsnlrYoFNNU3YE4m3WVSB7uU2Rh1e76alY9JKMT52KgBFAODlpWcOKF5VQ0m9fDZF6X2ZWvjWB0dm8yU9TQGfHnxpghS84eg1EXONtsSGxCA/QQPNXHVRk4cpH+vFJXn3cJ/1NV9pRJ/hOQBX1CxH3sCEHu4vY5q+Vgxf4NfxI57GcpC8xmFIW9Gv+Nu3zS5d9Srbm+TVHzXjNpg1JXS3Cmcyg84hxFc2A1QLodyODfF+fv2T8JA6Xjq/2O5GWs0efYkX9+kI0OIN95xMh+0wy0GhSepyeM0+7ToL1lb8kwrVJhHCO60BYwgaMmxsg2hLD+TOSEHuTYCNNpcJ+eIvWgjnMcyDYvgOISCWcWLBkJEXp4MAedRl0sBuSZqNQL5B0jE6xb4Mts5URMKONm0ROGQ22h3IyOiAGu7Rg7dcXBzD+Eic31xTKKCxAqhJhe462aa2FcgUE1OrhwLfeobCn2dpjzlI/cvozM5yahsLEnhjwUYgl0X6vv78uc4QvxpPz6BEPddAJ9eCgo8/nOLeXM4bNwYr2fUe+WdI5BXcNNTdZWKaQ5fUWBRTRuwpAuLXKfrzH+MwXcPjKWjZiXEu7cXpMAegepQiXC0uGKH0lJUS3uP1sSxcKd+q53GfcNc2H7M3hWXEJ3JRqBfQuEHMwq+XhUpbcx7XnMZyW/t1xKZlDWim9O+Z0Mm6lhFz1I+7vP5m5degdnWvFyatPOqYDmofnAdwtvN5lHblGen9NbA04svcNaAeXep jzwfjvUO TEPo7QyaGjayD1QIZrsEc7nplxTb4hMk0ijzcHTaB3i9tPUUoc1Gh9qiQDWNBr1RXcXOz4VdKONq/J/uFOeBbUYebwZwT5w+0f6CvpocUTZW5hAVYr11JdRdLqEao6zcNdar5Xt10roSDOE2DuuXUZuIF7gsIrMiY6OgfYF97DhYqtn8fsP7iXGD32JxpLsydalNswXEQu1DoNYUbGbIDCza6atYvjuJpamOjBppOcKdTqkvk0pHnNK44zHAftTIPF/27RzZpskhOq1eEPt6ZNxstPr2t4kZ53H14wmnKOCkDa39GKvfyBfzSXufEu+0HMbalBJy/RZZW7o7qt8vh8GBVPaX84MaFkpKuFKGkKp/qT4h0f+9remuDWJzleFlalL6fIQiIKRtO71qygQ7yMML54pXouD5/+vnKvkrf03M34V6GrVwtsxtl8KsBeaKGri86FL92a0G3u8i/BsebuIvzkpC5MhdCbj/0N4p5BG6azdyl2TNarKrCoLnj9FgfCK/lnGasj/hdzuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 11:31, Lorenzo Stoakes wrote: > Wei, > > NACK the whole series. > > I'm really not sure how to get through to you. You were _explicitly_ > advised not to send this series. And yet you've sent it anyway. > > I mean, I appreciate your enthusiasm and the fact you've made tests here > etc. obviously. And you've clearly put a TON of work in. But I just don't > know why you would when explicitly told not to without at least discussing > it first? > > This just isn't a great way of interacting with the community. We're all > human, please try to have some empathy for others here, as I really do try > to have with you as best I can. > > This adds a ton of churn and LOCKS IN assumptions about how anon_vma works, > clashes with other series (most notably series I've been working on), takes > away from efforts I want to make to start to join file-backed and anon > reverse mapping logic, separates the two in such a way as to encourage this > to nonly grow and generally isn't conducive to where I want to go with > rmap. anon_vma, the unloved child. :) I would love to see a simplification that makes it less special, and I can understand how adding tests for the ways it is special can be counter-productive. > > This is part of why I explicitly told you please don't go down this road, > because you're likely to end up doing work that doesn't get used. It's not > a great use of your time either. > > Since there's something useful here in tests, I may at a later date come > back to those. Agreed, skimming over the tests there are some nice diagrams and cases. But I would hope that for most of these cases we could test on a higher level: test our expectations when running real programs that we want to check, especially when performing internal changes on how we handle anon memory + rmap. E.g., do fork(), then test if we can successfully perform rmap lookups/updates (e.g., migrate folio to a different numa node etc). -- Cheers, David / dhildenb