Re: [PATCH 2.6.28 1/2] memory: improve find_vma

["Daniel Lowengrub" <lowdanie@gmail.com>]

KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> Hi
>
>> -     /* linked list of VM areas per task, sorted by address */
>> +     /* doubly linked list of VM areas per task, sorted by address */
>>       struct vm_area_struct *vm_next;
>> +     struct vm_area_struct *vm_prev;
>
> if you need "doublly linked list", why don't you use list.h?

list.h implements a circular linked list which is harder to integrate
into the existing code which in many places uses the fact that the
last element in the list points to null. First I want to check if it's
a good idea in general, if it is then I'll try to use the list.h
implementation.
Do you think that the idea is worth building on?  Is there any special
reason that I'm not aware of that this wasn't done originally?
Thanks

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>