From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681E7C46CD2 for ; Tue, 30 Jan 2024 08:41:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 010836B009D; Tue, 30 Jan 2024 03:41:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F02C36B00A1; Tue, 30 Jan 2024 03:41:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7C196B00A2; Tue, 30 Jan 2024 03:41:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C750E6B009D for ; Tue, 30 Jan 2024 03:41:16 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B3071A074A for ; Tue, 30 Jan 2024 08:41:16 +0000 (UTC) X-FDA: 81735332952.06.ED3EB50 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8F21240012 for ; Tue, 30 Jan 2024 08:41:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z0zfKq4o; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706604074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WTLnFRdfrnxQwRE7F4TUEf4XESOHlEYGkt2XMSp/gnM=; b=VTN3B/7vNgBQlxBq21RZfMVZJkOvZJJJDrn6REN9dqAybghUkoJYzB9gLaabLPizlJJ67s cFxEqp0aXTQTtzGDkZDI4vMXC5hByMXyhus4MDUw3Cn+tFW/UXxbfrsZbaVxD/EB1vrTAP NV7cmvyMoS4toREzFwKfjOnSOkqBQME= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706604074; a=rsa-sha256; cv=none; b=HSUBttSh/j0BJfMwsuShYxDj8nIbo2wo9jC0VyxAQmJzYG3w4dwTd8JAj8CCIo8zIaOKrD jaNlP4Qqu0kqNYZsnkyhsC/cPBoEAcvRDR2BBMQu4r+1rIA2GM5QTlMTEJPldt05LvemKW p7gZo6x2yUaxYdQ2mtwggBc68ANIvig= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z0zfKq4o; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706604073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WTLnFRdfrnxQwRE7F4TUEf4XESOHlEYGkt2XMSp/gnM=; b=Z0zfKq4oBalWOLPmUNNft8DS8cK3ioork54OPHtmg2zrfs8QwttfknxaLdBc4iuwssShTa noCZ7ut/HTkMucwtE9rceUFkgF5GcZqiBCgVfFEthwVfFpwLOzIXhQB6mTHszpNxwkadHx mCq6HRdtTeOMPNsjjDzFgskcxySL31U= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-hzyLNL9QPw25ZZ_odKuuGQ-1; Tue, 30 Jan 2024 03:41:11 -0500 X-MC-Unique: hzyLNL9QPw25ZZ_odKuuGQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5111b864decso314315e87.1 for ; Tue, 30 Jan 2024 00:41:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706604070; x=1707208870; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WTLnFRdfrnxQwRE7F4TUEf4XESOHlEYGkt2XMSp/gnM=; b=CJTWDu+ZDAw+k9NIyPe2CSghL1VdINgqw7uVdR6F4vWV7RSJFQp52ZuUGEnlSdz0pr Gv2TbOo0BCrCRLzF7MPg/q13qJI9dKR9L9FjMf3BenszZs2Hf/vU03nDRLiKL6mfsoP7 KNL3NyPODJIjMp+Wvf/PFLy0O0O/lxNYpgrmTID0CxO3eA7xhkvdS4nXRUyRk25dMfYI bHFeSDkjGzo1AIP+qdlwZcnrG5p+ClmqEgkUntohNerVNpPbYHI8IfYlDukYHWEPrTO2 AfpVI4q5eAoHUO2t15Ikq+rIv33bSAORDaSKWogzq75tDo7I0gvRxFOO8sKDrp8DzLlJ W2tQ== X-Gm-Message-State: AOJu0YzjXRokha4M7pzm0joefsJKnW9MuMuBOWSDD4AF3OK44gRUPDNd B9y9iz60PiJufdTQfj8llkizZ5Nnn3TvCNlTn1DmW7UePJjnksvy56bLD9IEcIb+l/9Vo8cQtEk gDD3vj6lNtv8lnpch+2iusIBoTzxXKogsHRX3cnzoz30jaUG5 X-Received: by 2002:a05:6512:e9b:b0:510:ee2d:c185 with SMTP id bi27-20020a0565120e9b00b00510ee2dc185mr5566820lfb.13.1706604070370; Tue, 30 Jan 2024 00:41:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcI8ngN1g9WgPokS7RyiEf1XgLiCDm+dXR+CkC1Oa7Yg/aFBEbTGjE1f71utFB2RtdPFKXlQ== X-Received: by 2002:a05:6512:e9b:b0:510:ee2d:c185 with SMTP id bi27-20020a0565120e9b00b00510ee2dc185mr5566802lfb.13.1706604069964; Tue, 30 Jan 2024 00:41:09 -0800 (PST) Received: from ?IPV6:2003:cb:c708:2700:bdf6:739b:9f9d:862f? (p200300cbc7082700bdf6739b9f9d862f.dip0.t-ipconnect.de. [2003:cb:c708:2700:bdf6:739b:9f9d:862f]) by smtp.gmail.com with ESMTPSA id p34-20020a05600c1da200b0040f22171921sm838440wms.3.2024.01.30.00.41.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 00:41:09 -0800 (PST) Message-ID: <8d19d635-2f55-4c0d-958b-0640f99ff0ce@redhat.com> Date: Tue, 30 Jan 2024 09:41:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/9] mm/memory: factor out zapping of present pte into zap_present_pte() To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Catalin Marinas , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Michael Ellerman , Christophe Leroy , "Naveen N. Rao" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20240129143221.263763-1-david@redhat.com> <20240129143221.263763-2-david@redhat.com> <40e87333-4da9-4497-a117-9885986e376a@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <40e87333-4da9-4497-a117-9885986e376a@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xjbo77uhkkc4gd3x4wphhfscqtrm8zo6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8F21240012 X-Rspam-User: X-HE-Tag: 1706604074-127146 X-HE-Meta: U2FsdGVkX18o/u/EX/prjAuotZ50CQ99D/6gY/A81AHdQ7cJm/hycY55hbrz7sqkESuifDp0MzKy6/XLk2RBm0Od3CGsuuXoP5oEKWwq3IG1Xs40bYMop5lqZfnCnI2fCxYh4f6mKmtKeGsenfwTQhBQ/o3s4PYDKtP0PiTzqvSeiH4VSkoljtVhfgT3muaEkN3V9RNHmrITWnNP/4QYJF5e6Ge5V0fRGOnyzQakaqDpckFqopLTH5NwqHIt8YzRbWtI19HI6k8hroUJGgIJSki85MQ5m8p+TXMERqfXcbRi4yrxL0uylRMDZjgqI7a5VUVt8Jasrd/JOgwuaLJFX/1Oqa9/9l1ro/R8iVgTfnW4XW1kubkDE4ikGB8unGhiEOj8b0JLemk4fxh5dyI5Ns8I1RDFGoW56HPZ5++rUqH1jB7b9DYdF9XyIdVRcc6fzGAbT6cpuwhxKcK44GamlOEaRvLDtmEaD6Ba69iKdpUWzMPrOybCZxlyuoA8m7Q7QJ2g1+TcevyGaV6MNet6aIYSN5ORbqf92MZcE4pQvl6kHwaateu+0T/tc3xeAkkFE9N2ylMO1m2eu0GAWrRwpGmiAvrhZuv4O00Z6KcQl/jpGW7XbiiXSrWqxNKs8uliQBkR60oBmTPd0pXwGHcicFhhg5fTfMJC2WYp39iU4s2LtZDcZZp10saJlNzrc+ogThZYCxAiK2bF3Vip4lqCRRp9tVc/GJNqfMwmKJluAgfY4hNDaFtGe2SgVUxD7a+7EauQGDiCdrJu/s9UUdkGh1DIvCPs/YwmIPojCcCLelqN5xXv/Naf6o07mrbaOXO+hQNpUP6fWniaK0CNskkk+DcwDc1KE1sbM05k7o22K/qI+vn+4I+RdXFkBnAuoW7A/hGYsdpURH9JUeWuvH3xHzBtpcZcth4Nsyk3GqOlhw6WAvPTvJ1i6fIONaUPIK+87cgk/zyfAgLU8tYw8eN M4MhCP+g MK1T82Gu3edoHMHGcpswx7HItLkqLdlSxs92kyrEG8PsNAkaX1YV90AwebenxU89Pa4yQx6OW+OSe1uUkY7x9jaMIj75hucfUh6+kXd/YnIRaKGLUeJm712PlDK9NrIHTWMPqPoVzAuOuoNRlR4XaalnBMvCxhpd4K32qvBTd+QcKJwavFw1Jf0mXrKRA/l9/O0DGNczr6yS0V4RdTRdCUKnRMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.01.24 09:13, Ryan Roberts wrote: > On 29/01/2024 14:32, David Hildenbrand wrote: >> Let's prepare for further changes by factoring out processing of present >> PTEs. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory.c | 92 ++++++++++++++++++++++++++++++----------------------- >> 1 file changed, 52 insertions(+), 40 deletions(-) >> >> diff --git a/mm/memory.c b/mm/memory.c >> index b05fd28dbce1..50a6c79c78fc 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -1532,13 +1532,61 @@ zap_install_uffd_wp_if_needed(struct vm_area_struct *vma, >> pte_install_uffd_wp_if_needed(vma, addr, pte, pteval); >> } >> >> +static inline void zap_present_pte(struct mmu_gather *tlb, >> + struct vm_area_struct *vma, pte_t *pte, pte_t ptent, >> + unsigned long addr, struct zap_details *details, >> + int *rss, bool *force_flush, bool *force_break) >> +{ >> + struct mm_struct *mm = tlb->mm; >> + bool delay_rmap = false; >> + struct folio *folio; > > You need to init this to NULL otherwise its a random value when calling > should_zap_folio() if vm_normal_page() returns NULL. Right, and we can stop setting it to NULL in the original function. Patch #2 changes these checks, which is why it's only a problem in this patch. Will fix, thanks! -- Cheers, David / dhildenb