From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ACFC54EBD for ; Mon, 9 Jan 2023 19:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A61C78E0002; Mon, 9 Jan 2023 14:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A11C38E0001; Mon, 9 Jan 2023 14:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DA158E0002; Mon, 9 Jan 2023 14:54:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B2398E0001 for ; Mon, 9 Jan 2023 14:54:37 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 84EDCAB242 for ; Mon, 9 Jan 2023 19:54:36 +0000 (UTC) X-FDA: 80336312952.03.01D8C0C Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf09.hostedemail.com (Postfix) with ESMTP id 488F8140019 for ; Mon, 9 Jan 2023 19:54:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FSvdZoh4; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673294074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AdZWE6jY1AcHBWLny/8/wJdOZgqSngi4YtNdU1PsIPI=; b=tbzvE6nmgC1EuksMIHibwqrJxJ4+SadKANUXFdMakRUhFyMjnxbW9Hb+TZyXV8wIWZU4Pw DPpkqdBknxOyry+sq60Vyy64AVTz69dT+/+AtCOTI3JZm3uvsnAf8sUKOncVLRv+BUFmNJ K6yZego76LVJdF2kvuwG4Hrn+daOPGY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FSvdZoh4; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673294074; a=rsa-sha256; cv=none; b=HJlCkG3KSigtZBHaxSn7ttQ3ZKrS/eIzyu/46/KrgU3KYvWiYUItuhlHt04jzXViaWaFIX WVT8h8nchI0roaNmbKFlnr39DA7x8ZoDR7VrXYKlCq0I6u4MtBkpWuJICD9GtRUYHNnCwA H4hzst9hutVwLbRQI56mwFZFekMC0WM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673294074; x=1704830074; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EYmGw8cKylJ3oVUnXbyNAs21ToQ2EjfNHKl2V8Wq3dg=; b=FSvdZoh4795UfZPrk3WIul1ySUgO0h6+DX7CALO+xJPzSjyuUlJ0KCXX Wj3jRvMO85EyWjUoUHLQOJrg/SuO0wybOZXuzCaR7fpbiQpJW/xxRrTEz 2GGZapocfmQ7BV34gP0/A+0ESFQzkfgioDqMLZOElF8Fhm+UsMXNC2Z9J 1Y7ZWDWMnz/l0sPynkIEAVfUPasXjN5PAD9UxF8c3AYMK0MrI+/To34Sx xjlPl+IIe+P6M+mpscyT4R0gGUanYEbxGWz9ZLR7JDzQhMNRieGAwjEAZ 18d3xCXksCLGCGOLDTecZfJGfGZZzgeSEeBFjCQ4EqoPgV8BScfBGe+3Y Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="387414655" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="387414655" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 11:54:32 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="725289770" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="725289770" Received: from swapnadi-mobl2.amr.corp.intel.com (HELO [10.209.29.117]) ([10.209.29.117]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 11:54:31 -0800 Message-ID: <8d1b8738-03d2-b5a6-fd63-a6513db4c86b@intel.com> Date: Mon, 9 Jan 2023 11:54:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 05/16] x86/virt/tdx: Implement functions to make SEAMCALL Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <61b9cc00-d514-df77-0a31-88ec35d73456@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 488F8140019 X-Stat-Signature: kk5ebpe1ik6jbdr7ey648w4b43oxsmxf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673294073-211541 X-HE-Meta: U2FsdGVkX18XVyizuf/4gCdh3Lz8mYBJD+P4jon9ZUH/HkMWxqNd4yo0b52Hm0O3S7SXni+lTTNrXmbV7Aeru6nItXlWrGT6CMd+JXZnfoYvj56rvrqUraZqpVmDjB44B0rSulD/4o+4P59H4odhaVTBh5njLOSOzIlwuJSg4VL417/fqW3poifjvtkFXvnJndoGbG6mdg646WMFJZksp9mh81EX8EnShoGLDE+sibYfKOAA/Wc+eTuMmU6XphcAkXppW5+5QQySnyg53H7Q2PLo7sveJAiZUFT3YfAM0QkD+xYqtE7Co7pHlOmjDRnH3k+/ge365dnQkU0CYBmQi3GwGpN7wJ4oS+QKHpd6HaBzx93XyVUJXIBL2O4vmUl5v166BowKbBATgVVA7fpKXaMy/KM/Cy5AdL/KlkCx5QZvhaMSale0CyBo3OmvXHzfNwS6wBzLus2ryCTJpNGoDJcxF0ZTCd9rBr30ZWN9S4H2uymdLcF2+2z+8GGy/683gUvsBT2FnXygFme3Yd0/R9+nenZCyvwFCYVCqfIuRB6IBi8Wvq9TwrpsPlcqsZRSQCJkR0+HnkcSFo+ri8QnR5/nT5HOb8Q1K0d6H5nP2XmgEKU3pEdG41cIphnT7fG1bF0oGPP21EsMJ+udZUbM2B7cdgbDANOax9yYxH2vuOtE+j0IiE7GSN4RjxsA8xQPEKUoe6LDH+ARlOZrc7KM0UEmxr3YMY457Sc5V1TUit5BLT37+azPUiFjy8SkCmU06Sgrmrp1b1j/t1QWOMMOgzsWjfS06X+nkTthz3rRJQ4TZNG9liiA/+I6ivQVENL61pbaZbPkU53xZSrxzTxIhwqAzSdTephGmpyf8ENnsq3prlhTxJ5Tu/7STlAjCxmJ1YSgNN7tRL+QKl5SicY6+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 02:30, Huang, Kai wrote: >> I don't know that you really _need_ to split this up, but I'm just >> pointing out that mashing three different logical things together makes >> it hard to write a coherent Subject. But, I've seen worse. > Agreed. > > To me seems "Add SEAMCALL infrastructure" is good enough, but I can split up if > you want me to. Everything else being equal, I'd rather have them split up. But, I'm frankly not looking forward to the additional work on my part to review and rework three more patches and changelogs.